Reviewer needed: building langtools on a Mac

[Dr Andrew John Hughes]

On 16:38 Thu 10 Feb     , Gary Meyer wrote:
> 
> On Feb 9, 2011, at 6:48 PM, Jonathan Gibbons wrote:
> 
> > Build folk,
> > 
> > The following fix should make it possible to (again) build langtools on a Mac.   
> > 
> > Dan Smith reports:
> > - When building the GenStubs in OS X, the Java 6 tools classes are in classes.jar, and this shadows $build.bootstrap.dir, which appears in the classpath.  This can be fixed with -Xbootclasspath/p.
> > 
> > Webrev here:
> >     http://cr.openjdk.java.net/~jjg/7018452/webrev/
> > 
> > -- Jon
> 
> 
> I don't know if you will accept me as a code reviewer, but I'm the Java Build Engineer at Apple.  These code diffs look good to me.
> Gary.
> ~~~~~~~~~~~~~~~~~~~~~~~
> Gary Meyer
> Java Software Build Engineer
> gary.meyer at apple.com
> 

Hi Gary, 

Personally, I think it's great that someone who knows the platform
has checked over this patch.

More formally, for the commit, I think it depends on if Oracle gave
you an OpenJDK username yet :-) AFAIK, the 'Reviewed-by' field in
commits has to contain OpenJDK usernames.  See the (incomplete)
developer's guide at http://openjdk.java.net/guide/producingChangeset.html

This may or may not be checked by the jcheck extension Oracle run
on commits.  Given it's proprietary, we really don't know what it does.

Jon, FWIW, I also think the patch looks fine.

Hope that helps,
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37