Need reviewer: Windows use of /safeseh

[Kelly O'Hair]

Point is that the option /SAFESEH is accepted on Windows 64bit and  
does not complain that it does not apply.
And even though it always uses table driven exception handling on  
64bit,  dumpbin output doesn't indicate it does.
Which is fine, I can work around that. The latest webrev makes this a  
Windows 32bit thing only.

-kto

On Feb 15, 2011, at 9:13 PM, Jeroen Frijters wrote:

> Just a minor clarification, SafeSEH is not applicable to x64 (and  
> Itanium) because those platforms always use table driven exception  
> handling (and hence are not vulnerable to exception chain  
> corruption), so it's not really the default, since there is no other  
> option.
>
>> -----Original Message-----
>> From: build-dev-bounces at openjdk.java.net [mailto:build-dev-
>> bounces at openjdk.java.net] On Behalf Of Kelly O'Hair
>> Sent: Wednesday, February 16, 2011 1:29 AM
>> To: build-dev
>> Subject: Re: Need reviewer: Windows use of /safeseh
>>
>>
>> Ran into a minor snag on Windows 64bit, so the webrev has been  
>> updated.
>> Apparently the -safeseh is harmless on 64bit, but the dumpbin /
>> loadconfig never reports that the exception table is safe on 64bit,  
>> even
>> though it is by default. :^(
>>
>> So the safeseh check cannot be done on Windows 64bit.
>>
>> -kto
>>
>> On Feb 15, 2011, at 2:05 PM, Kelly O'Hair wrote:
>>
>>> Need reviewer: Windows use of /safeseh
>>>
>>> Just an addition of /safeseh during links and a check to verify that
>>> the dll and exe files all have a Safe Exception Handler Table.
>>> See http://msdn.microsoft.com/en-us/library/9a89h429.aspx for more
>>> information.
>>>
>>> 7010594: Add /SAFESEH to links on windows to verify safe exceptions
>>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-safeseh/ 
>>> webrev/
>>>
>>> -kto
>