Code review request for 7052122: Update JDK_MINOR_VERSION for JDK 8

David Katleman david.katleman at oracle.com
Wed Jun 8 18:21:40 UTC 2011


On 6/7/2011 8:32 PM, Joe Darcy wrote:
> Please review this change to bump the JDK 8 version number from 1.7 to 
> 1.8:
>
>    7052122: Update JDK_MINOR_VERSION for JDK 8
>    http://cr.openjdk.java.net/~darcy/7052122.0/
>
> Patch below followed by post-GPL text of new langtools test.

Changes are correct.

Thanks for taking care of this Joe.

             Dave

>
> --- old/make/common/shared/Defs.gmk    2011-06-07 20:28:41.000000000 
> -0700
> +++ new/make/common/shared/Defs.gmk    2011-06-07 20:28:41.000000000 
> -0700
> @@ -195,8 +195,8 @@
> endif
>
> ifndef JDK_MINOR_VERSION
> -  JDK_MINOR_VERSION      = 7
> -  PREVIOUS_MINOR_VERSION = 6
> +  JDK_MINOR_VERSION      = 8
> +  PREVIOUS_MINOR_VERSION = 7
> endif
>
> ifndef JDK_MICRO_VERSION
> --- old/make/docs/Makefile    2011-06-07 20:28:42.000000000 -0700
> +++ new/make/docs/Makefile    2011-06-07 20:28:41.000000000 -0700
> @@ -223,6 +223,9 @@
> ifeq ($(JDK_MINOR_VERSION),6)
>   JDK_IS_FCS = true
> endif
> +ifeq ($(JDK_MINOR_VERSION),7)
> +  JDK_IS_FCS = true
> +endif
> ifeq ($(JDK_IS_FCS),false)
>   ifneq ($(MILESTONE), fcs)
>     DRAFT_HEADER = 
> <br><strong>DRAFT $(MILESTONE)-$(BUILD_NUMBER)</strong>
>
> /*
> * @test
> * @bug 7025809
> * @summary Test latest and latestSupported
> * @author  Joseph D. Darcy
> */
>
> import javax.lang.model.SourceVersion;
> import static javax.lang.model.SourceVersion.*;
>
> /**
> * Verify latest[Supported] behavior.
> */
> public class TestSourceVersion {
>    public static void main(String... args) {
>        if (SourceVersion.latest() != RELEASE_8 ||
>            SourceVersion.latestSupported() != RELEASE_8)
>            throw new RuntimeException("Unexpected release value(s) 
> found:\n" +
>                                       "latest:\t" + 
> SourceVersion.latest() + "\n" +
>                                       "latestSupported:\t" + 
> SourceVersion.latestSupported());
>    }
> }
>



More information about the build-dev mailing list