Need reviewer: demo fixes from a long time ago ...

[Kelly O'Hair]

On Mar 15, 2011, at 3:50 PM, Mandy Chung wrote:

> On 3/15/11 2:25 PM, Kelly O'Hair wrote:
>> Need reviewer for these 2 demo fixes:
>> 
>> 6685150: make/mkdemo/jpda/Makefile creates jpda.jar and src.zip instead of examples.jar
>> 6710813: SwingSet2 source display tabs do not work since JDK 7 b20
>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-demos/webrev/
>> 
> make/common/Demo.gmk
>    line 256: should we skip invoking javac cmd ifeq ($(DEMO_ONLY_SRC),true)?
>       Probably not because we want to make sure the demo compiles.
>       A comment might help.

Oops, it is on it's way, but I did want to make sure it compiles.

>    line 258-268: nit: not aligned with line 256 - probably space vs tab difference.

Ah, Makefiles, the only safe haven for TAB characters...  ;^)

-kto

> 
> Other than that, looks good.
> 
> Mandy
> 
>> The SwingSet2 demo was special because it includes it's sources inside the jar file.
>> 
>> The jpda demo was special in that it historically only included sources in it's jar, and
>> was called examples.jar.
>> 
>> -kto
>> 
>