Need reviewer: openjdk7 Build README

David Holmes David.Holmes at oracle.com
Tue Mar 22 03:47:31 UTC 2011


Hi Kelly,

Can't comment on technical accuracy but it seems to read fine and html 
seems ok. A couple of minor textual nits:

- Cross-references to the "building GNU make" section should say 
"Building" with a capital B (and even have the cross-ref in double-quotes)

- For <b>X64</b>, builds, ->  For <b>X64</b> builds, (extraneous comma)

- For the 3 tips on Windows VS2010 use a nested list

- C:/temp is just an example -> C:\temp is just ... ?


Now a couple of technical content queries:

- noticed minimum build env lists gcc 4, but that has to be gcc 4.3 now 
for a JDK build.

- Under "Build Information" it states "Building the OpenJDK is done with 
a gmake command" but I think it should say "a GNU make command". The 
example can then clarify that it is a Solaris example and so uses gmake 
as the name of thje command

Cheers,
David

Kelly O'Hair said the following on 03/22/11 12:51:
> Need reviewer: openjdk7 Build README
> 
> 6896934: README: Document how the drop source bundles work for jaxp/jaxws
> 6896978: README: Updates to openjdk README-builds.html
> 6903517: README: OpenJDK additions needed - cygwin issues
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-READMEs/webrev/
> 
> -kto
> 



More information about the build-dev mailing list