7009599: need reviewer

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Mar 25 02:08:24 UTC 2011


I need a build-dev reviewer for this patch.

This is a simple patch to langtools/make/build.xml to stop inappropriate 
files getting into tools.jar.

> diff -r 83260b3305ac make/build.xml
> --- a/make/build.xml    Thu Mar 24 16:14:30 2011 -0700
> +++ b/make/build.xml    Thu Mar 24 19:00:16 2011 -0700
> @@ -806,6 +806,9 @@
> <exclude name="**/*.java"/>
> <exclude name="**/*.properties"/>
> <exclude name="**/*-template"/>
> + <exclude name="**/*.rej"/>
> + <exclude name="**/*.orig"/>
> + <exclude name="**/overview.html"/>
> <exclude name="**/package.html"/>
> </fileset>
> </copy>

The first two lines (*.rej, *.orig) are primarily for the benefit of 
developers and developer builds, since official builds never contain 
such files.   The last line (overview.html) is needed for all builds to 
prevent a couple of such files making it all the way into tools.jar. (Oops.)

Tested by comparing the list of contents of tools.jar before/after the 
fix, and since overview.html is involved as well, verified that the 
generated docs are unaffected (specifically for the Mirror API.)

-- Jon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20110324/e642828b/attachment.htm>


More information about the build-dev mailing list