Request for review: do not use --sync with df during sanity check
Dr Andrew John Hughes
ahughes at redhat.com
Wed May 4 21:43:07 UTC 2011
On 17:35 Wed 04 May , Omair Majid wrote:
> Hi,
>
> Can someone please review the following webrev?
>
> http://cr.openjdk.java.net/~omajid/webrevs/no-sync/01/
>
> It modifies the sanity check (under linux) to use df without --sync when
> it computes the free space. This is what is done in the solaris case.
> The accuracy gained by using --sync is probably not worth the
> performance loss caused by flushing disk buffers.
>
> The patch was originally written by Andrew John Hughes
> (ahughes at redhat.com) and we have had this in icedtea6 for almost a year now.
>
> Thanks,
> Omair
Let's see if you do better than I did...
http://mail.openjdk.java.net/pipermail/build-dev/2010-June/003056.html
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
More information about the build-dev
mailing list