Need reviewers: 7043700: Regression for IcedTea builds (e.g. ALT_OUTPUTDIR)
Omair Majid
omajid at redhat.com
Fri May 13 16:35:21 UTC 2011
On 05/12/2011 10:00 PM, Kelly O'Hair wrote:
>
> On May 12, 2011, at 4:33 PM, Omair Majid wrote:
>
>> Hi Kelly,
>>
>> On 05/12/2011 04:39 PM, Kelly O'Hair wrote:
>>>
>>> Need reviewers. (Omair, you will want to verify this works for IcedTea).
>>>
>>> Some background: this changeset:
>>> http://hg.openjdk.java.net/jdk7/jdk7/rev/47f6b7db1882
>>> Created some issues for people setting ALT_OUTPUTDIR to a vanilla path like /tmp/foobar.
>>> The expectation was that a debug build would show up in /tmp/foobar-debug, but it was showing
>>> up in /tmp/OS-ARCH-debug.
>>> The original changeset was mostly dealing with a Windows issue where you cannot just append
>>> characters to an existing path and expect that path to be valid, so a technique of doing a /../ was used.
>>>
>>> This fix tries to make it a bit more obvious what is going on, although I have to admit it's a confusing
>>> situation regardless.
>>>
>>> 7043700: Regression for IcedTea builds
>>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-outdebug-7043700/webrev/
>>>
>
> I have updated the webrev.
>
Thanks for the fix Kelly. The updated webrev fixes both debug and
non-debug builds using ALT_OUTPUTDIR for me.
Thanks!
Omair
More information about the build-dev
mailing list