Build portability: enable or disable warnings

[Andrew Haley]

On 05/16/2011 06:52 PM, Kelly O'Hair wrote:
> 
> On May 16, 2011, at 10:12 AM, Andrew Haley wrote:
> 
>> On 05/16/2011 05:50 PM, Dmitry Samersoff wrote:
>>> Andrew,
>>>
>>> I guess we can add to build system something like
>>>
>>> ALT_COMPILER_FLAGS
>>>
>>> and turn on all warnings and -Werror by default.
>>>
>>> Having zero-warning build is good practice and it's not too costly.
>>
>> It'd drive you mad.  gcc's -Wall is really not suitable to be enabled
>> by default; it was never intended for that.
> 
> But there is probably a set of warnings or options, e.g.
>    -Wall  -Wno-this  -Wno-that -Werror
> that might be suitable to standardize on, right?

I think so, but you have to allow for semi-crazy distros that patch
gcc in interesting ways.

> Although, that might be a different list with each gcc release as I have noticed.

Yes.

> We need a  -Wall-the-warnings-that-are-really-important-to-fix  ;^)

Indeed.  Every year or two we gcc maintainers argue about what set
that would be...

Andrew.