(XS) Request for review: 7109092 - link changes for embedded builds
Alan Bateman
Alan.Bateman at oracle.com
Thu Nov 24 10:45:01 UTC 2011
On 23/11/2011 06:55, David Holmes wrote:
> We need to make an adjustment to the link instructions used for
> libjava in embedded builds, as defined in Defs-embedded.gmk
>
> webrev: http://cr.openjdk.java.net/~dholmes/7109092/webrev/
>
> Summary: system soft-float libraries need not have the level of
> accuracy required by Java floating-point semantics. On those platforms
> we have a custom soft-float library to provide the necessary accuracy.
> This change updated the linker instructions to use that library when
> linking libjava (really fdlibm is what needs it).
>
> The VM has been using a similar library for a while now.
>
> I currently have this as a child of jdk8/tl/jdk so would prefer to
> push there, but can switch to jdk8/build/jdk if the build-dev folks
> feel strongly about it.
Looks okay to me, as you say, libjvm.so is linked the same way. I don't
think it matters which integration forest you use for this, jdk8/tl/jdk
is fine.
-Alan.
More information about the build-dev
mailing list