please review fix for 7116322, enhance javac make rule with a little bit of instrumentation

[David Holmes]

Hi Stuart,

On 29/11/2011 10:42 AM, Stuart Marks wrote:
> Please review this change to add to the javac make rule some messages
> about the number of files being compiled, the current working directory,
> and a new message to demarcate the end of javac output.
>
> This will help capture and analyze javac output, in particular, warning
> messages.
> diff -r 6fbd69f8e3ab make/common/Rules.gmk
> --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000
> +++ b/make/common/Rules.gmk Mon Nov 28 16:34:34 2011 -0800
> @@ -236,9 +236,10 @@
> @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \
> $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \
> $(CAT) $<.filtered; \
> - $(ECHO) "# Running javac:"; \
> + $(ECHO) "# Running javac: `$(WC) -l < $<.filtered` files; in `pwd`"; \

Can we do this without running wc a second time?

Also shouldn't the current working directory be known from when the 
current sub-dir is entered by make?

David
-----


> $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR)
> @$<.filtered; \
> $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \
> + $(ECHO) "# javac finished"; \
> fi
> @$(java-vm-cleanup)