jdk/src/solaris - time to re-visit it?

[Steve Poole]

On Mon, 2011-11-28 at 17:20 +0100, Fredrik Öhrström wrote:
> 2011-11-28 16:46, Ulf Zibis skrev:
> > I guess you meant:
> > --shared
> > --posix
> >        |--SYSV
> >        |    |--solaris
> >        |    |--aix
> >        |
> >        |--gnu
> >        |    |--linux
> >        |    |
> >        |--BSD
> >             |--darwin
> >             |--freebsd
> >
> > --winapi
> >      |--win32
> >      |--wince
> >
> > against current ...
> > --share
> > --linux
> > --solaris
> > --windows
> >
> 
> The directory structure ought to be more flat than
> the possible combinations that form a product.
> 
> For example if:
> HOST_API = posix winapi
> HOST_OS = solaris aix gnu linux darwin freebsd windows wince
> HOST_OS_PEDIGREE = SYSV GNU BSD
> 
> then the directories are stored flat under src:
> 
> --src
>      |--share
>      |--posix
>      |--winapi
>      |--SYSV
>      |--GNU
>      |--BSD
>      |--solaris
>      |--aix
>      |--gnu
>      |--linux
>      |--darwin
>      |--freebsd
>      |--windows
>      |--wince
> 
I think that make sense. This is one of these discussions in which there
is no simple answer. Trying to architect a directory structure to match
all the possible combinations (now and for the future) is likely just to
make things even more complicated.

This approach is simple and makes it easy for new platforms to just drop
in.

> Then, when compiling, the union of the directories and files below
> the selected src subdirectories, form the source of the product.
> For example:
>     share,posix,BSD,darwin
>     share,posix,GNU,linux
>     share,posix,GNU,gnu
>     share,winapi,windows
> 
> This gives less confusion about which subdirs to src/posix
> are configuration directories, and which are posix directories with code.
> 

I do like this approach -especially if the union of directories per
platform is well documented and visible. That would really help
understand the impact when someone has to change a file in one of these
subdirectories.

> //Fredrik
>