code review request: 7092627: use agentvm mode instead of samevm in regtests

Weijun Wang weijun.wang at oracle.com
Wed Sep 21 11:09:29 UTC 2011



On 09/21/2011 06:29 PM, Alan Bateman wrote:
> Weijun Wang wrote:
>> Hi Dmitry
>>
>> Webrev updated at
>>
>> http://cr.openjdk.java.net/~weijun/7092627/webrev.01/
>>
>> Also, a new variable CONCURRENCY is added so that you can run tests in
>> multiple VMs. The value can be a number or "auto" which uses
>> Runtime.getRuntime().availableProcessors() as the value.
>>
>> No change for MangleStepTest.java and ParentLoggersTest.java in this
>> version.
> Great to see this changed to agentvm mode and thanks for adding the
> CONCURRENCY variable which I think will be much more useful than gmake -j.
>
> One thing in the Makefile is that it defaults to jtreg 4.0 when JT_HOME
> isn't set and I think you need 4.1 to get agentvm mode.

Correct.

>
> Also shouldn't you also s/SAMEVM/AGENTVM/ so that there are no longer
> any references to samevm?

Is that necessary? That would also need s/samevm/agentvm/ and 
s/RunSamevmBatch/RunAgentvmBatch/. :)

-Max

>
> -Alan



More information about the build-dev mailing list