RFR (and sponsor): java.lang.annotation.ContainerAnnotation is not built with the JDK (7158930)

[Joel Borggrén-Franck]

Thanks for the review Kelly

cheers
/Joel

On 5 apr 2012, at 17:09, Kelly O'Hair wrote:

> Looks ok to me.
> 
> -kto
> 
> On Apr 4, 2012, at 10:27 AM, Joel Borggrén-Franck wrote:
> 
>> Hi,
>> 
>> java.lang.annotation.ContainerAnnotation.java that was added with CR 7151008 is not built and added to rt.jar.
>> 
>> I suspect this is because the source directory java/lang/annotation is not in the AUTO_FILES_JAVA_DIRS list in the Makefile for reflection and annotations, make/java/java/reflect/Makefile . Also the ContainerAnnotaion class is not referenced from the JDK.
>> 
>> I have posted a webrev for a fix that adds this directory:
>> 
>> http://cr.openjdk.java.net/~jfranck/7158930/webrev.00/
>> 
>> This seems to work, with this addition ContainerAnnotation gets compiled and included in rt.jar and rt. jar contains exactly 1 more file than before the patch.
>> 
>> cheers
>> /Joel
>