Request for Review: Execute the build logger with the help of a shell if the x permission is not set

Fredrik Öhrström oehrstroem at gmail.com
Fri Apr 20 17:56:59 UTC 2012


Looks good!

2012/4/20 Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com>:
> In the build-infra hg repo, we allowed execute permission to be set on
> files, including common/bin/logger.sh, which is called by the Makefile.
>
> The official hg repos strip this bit, so when integrating to the build
> forest, this was lost, causing the Makefile to fail since it can't execute
> logger.sh.
>
> This fix looks if the x permission is there, otherwise it calls logger.sh
> using the shell.
>
> Webrev:
> http://cr.openjdk.java.net/~ihse/logger.sh-missing-x-permission/webrev.00/
>
> /Magnus
>



More information about the build-dev mailing list