Request for Review: Execute the build logger with the help of a shell if the x permission is not set

Dmitry Samersoff Dmitry.Samersoff at oracle.com
Wed Apr 25 15:23:16 UTC 2012


Magnus,

Fix looks good for me.

The only question - why we should patch both configure.ac
and configure ?

I believe we generate configure from configure.ac

-Dmitry


On 2012-04-25 17:32, Magnus Ihse Bursie wrote:
> On 2012-04-23 18:01, Dmitry Samersoff wrote:
>> Magnus,
>>
>> I'm second to Kelly.
>> We shouldn't have executable scripts in repository.
> 
> Ok, so here comes a new, even simpler patch. :-)
> 
> http://cr.openjdk.java.net/~ihse/logger.sh-missing-x-permission/webrev.01/
> 
> /Magnus
> 


-- 
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...



More information about the build-dev mailing list