RFR: 7190512 Fix for 7181175 broke hotspot/make/windows/create.bat builds.

Tim Bell tim.bell at oracle.com
Sat Aug 11 02:12:06 UTC 2012


On 08/10/12 14:08, Daniel D. Daugherty wrote:
> On 8/10/12 3:07 PM, Tim Bell wrote:
>> I wrote:
>>> Hello all-
>>>
>>> After the fixes for 7181175 hit the hotspot-rt forest, users noticed 
>>> that hotspot/make/windows/create.bat builds were broken.
>>>
>>> This is a supplemental fix that restores building using that .bat 
>>> file.  Note that this is not on the 'product' build path at all - 
>>> this is something HotSpot developers use to get a fast build of 
>>> their VM changes.
>>>
>>> Dan - as gatekeeper-of-the-month, would you be able to take this?
>>
>> D'oh - here is the webrev.  It is a one-line fix:
>>
>> http://cr.openjdk.java.net/~tbell/7190512/webrev.00/
>>
>> Tim
>
> One-line addition of two double quotes... Gotta love Windows.
>
> Thumbs up! 

Thanks, Dan

make/windows/create.bat and make/windows/build.bat both work OK for me 
with this change.

I am not going to worry about make/windows/cross_build.bat because our 
Itanium systems were powered off in 2008.

Tim




More information about the build-dev mailing list