[7u6] Request for approval for CR 7157855: jvisualvm.1 not included in binaries

Andrew Hughes ahughes at redhat.com
Mon Aug 20 17:57:50 UTC 2012


----- Original Message -----
> This fix is also addressed in jdk8 at the same time.
> 
> Bug: http://bugs.sun.com/view_bug.do?bug_id=7157855
> Webrev: http://cr.openjdk.java.net/~mfang/7157855/
> Reviewers: katleman, thurka
> 
> thanks,
> 
> -michael
> 

Do you have a link to where this was reviewed?  I don't see it in my inbox.

There is a flaw in this patch.  jvisualvm is not part of OpenJDK so the man
page should not be installed if building OpenJDK.

The same bug had to be rectified for javaws in 7021314: Build should not install javaws man page.

I'll post a webrev but basically it needs to be surrounded by an #ifndef OPENJDK.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07




More information about the build-dev mailing list