Review Request: 8004281: build-infra: Move all jar creation to images target and put jars in images/lib

Kelly O'Hair kelly.ohair at oracle.com
Mon Dec 3 15:37:00 UTC 2012


looks good

-kto

On Dec 3, 2012, at 4:57 AM, Erik Joelsson wrote:

> Good catch!
> 
> New webrev:
> http://cr.openjdk.java.net/~erikj/8004281/webrev.02/
> 
> /Erik
> 
> On 2012-12-03 12:57, David Holmes wrote:
>> In CreateJars.gmk there is a typo:
>> 
>> 654         $(isntall-file)
>> 
>> So that path mustn't be being tested
>> 
>> David
>> ------
>> 
>> On 3/12/2012 7:23 PM, Erik Joelsson wrote:
>>> This patch moves all jar file creation in jdk (except demos) to
>>> CreateJars.gmk, which is called by the images target. All the jar files
>>> are put in images/lib instead of being spread between jdk/lib and
>>> images/lib. This makes images creation simpler since all jar files can
>>> be found in one place.
>>> 
>>> http://cr.openjdk.java.net/~erikj/8004281/webrev.01/
>>> 
>>> /Erik




More information about the build-dev mailing list