Review Request: JDK-8004145: build-infra: hgforest.sh cannot be interrupted safely.
Fredrik Öhrström
fredrik.ohrstrom at oracle.com
Wed Dec 5 12:54:31 UTC 2012
Ok, I have added code to deal with s p a c e in the path to hg, so that
the script
works with tortoisehg on windows. Tested on Windows,Linux and Solaris.
http://cr.openjdk.java.net/~ohrstrom/webrev-8004145-hgforest-v2
//Fredrik
2012-12-04 09:42, Erik Joelsson skrev:
> I've been using this for a while now and on windows, when using
> tortoisehg, I've noticed that a lot of error output is generated. It
> doesn't seem to affect the results (it concludes that the python
> script couldn't be found), so it's not crucial, just annoying. The
> reason for the errors is the old classic, space in directories
> (/cygdrive/c/Program Files/TortoiseHG/hg.exe).
>
> /Erik
>
> On 2012-12-03 17:34, Kelly O'Hair wrote:
>> Nicely done. Looks good.
>>
>> You do realize that the "you touched it last" rule may apply here in
>> the future? ;^)
>>
>> -kto
>>
>> On Nov 29, 2012, at 5:17 AM, Fredrik Öhrström wrote:
>>
>>> This patch makes sure that pressing ctrl-c when running "sh
>>> get_source.sh" actually
>>> sends a nice TERM signal to the background mercurial processes so
>>> that they can do
>>> a nice rollback, if they need to. Really useful, when that clone has
>>> stalled, because
>>> your network is down, and you want to stop and retry later.
>>>
>>> http://cr.openjdk.java.net/~ohrstrom/webrev-8004145-hgforest/
>>>
>>> //Fredrik
>>>
>>>
More information about the build-dev
mailing list