Review Request: 8001753: build-infra: mismatch with full debug symbol control for hotspot
Erik Joelsson
erik.joelsson at oracle.com
Tue Dec 11 08:54:09 UTC 2012
On 2012-12-11 02:24, David Holmes wrote:
> On 11/12/2012 1:11 AM, Erik Joelsson wrote:
>> This patch makes it possible to disable FDS in hotspot using the new
>> build system, by translating the controlling variables in spec.gmk to
>> what hotspot is expecting in hotspot-spec.gmk.
>
> Well I would have described it as "Enabling hotspot to use the FDS
> settings established at configure time" but ok :)
>
>> http://cr.openjdk.java.net/~erikj/8001753/webrev.01/
>
> Looks okay to me. Do we now have a fully consistent use of true/false
> vs yes/no for various flags?
>
Thanks!
No, there are still a couple of more. I didn't want to change other
flags with this bug. I will file a bug (unless there is one already) to
unify the rest.
/Erik
More information about the build-dev
mailing list