Review request: 8005096: Move a few source files in swing/beaninfo and in a demo.

Sergey Malenkov Sergey.Malenkov at oracle.com
Tue Dec 18 12:39:28 UTC 2012


Hi Fredrik,

Looks OK to me.  But there are a lot of images in the 
make/tools/swing-beans/beaninfo/images folder.  Could you please check 
the make/javax/swing/beaninfo/SwingBeans.gmk file to ensure that the 
dt.jar library will be packed correctly?

Also I think that moving of java files from the 
make/tools/swing-beans/beaninfo folder is redundant, because we could 
copy them to the expected folder from the current location.

Thanks,
SAM

On 16.12.2012 1:01, Fredrik Öhrström wrote:
>   A few source files, coming from the generated swing BeanInfo files are generated and stored into the wrong source directory, where the path does not correspond to the expected package path. This is unfortunate and makes it impossible for the smart javac wrapper to predict which source files belong to which package.
>
> There is also two small files in a demo, with the same problem.
>
> The fix is simple, move a few files (4) and make sure the generated files end up in the correct source directory.
>
> http://cr.openjdk.java.net/~ohrstrom/webrev-8005096-move-a-few-files/
>
> //Fredrik
>



More information about the build-dev mailing list