Review Request: 8001895: build-infra: Make JDK_BUILD_NUMBER and MILESTONE customizable

[Kelly O'Hair]

Looks ok to me.

---
I'm sure this stuff will come back to haunt you (us?) again and again. ;^)

-kto

On Dec 31, 2012, at 8:31 AM, Erik Joelsson wrote:

> New webrev with support for overriding MILESTONE and JDK_BUILD_NUMBER on make command line. I'm not sure I like this feature, but it's better it does what you would expect than just making things inconsistent.
> 
> http://cr.openjdk.java.net/~erikj/8001895/webrev.root.02/
> 
> /Erik
> 
> On 2012-12-31 11:29, Erik Joelsson wrote:
>> 
>> 
>> On 2012-12-31 11:06, Erik Joelsson wrote:
>>> On 2012-12-30 23:47, David Holmes wrote:
>>>> Erik,
>>>> 
>>>> On 30/12/2012 9:55 PM, Erik Joelsson wrote:
>>>>> I've added configure options for milestone and build number so that they
>>>>> can be customized.
>>>>> 
>>>>> http://cr.openjdk.java.net/~erikj/8001895/webrev.root.01/
>>>> 
>>>> Can we still override with make time variable setting?
>>> Overriding at the make command line won't work at this point since the logic for all the derived version strings are still in configure. I know there are flaws in this design and I would really like to solve it better. That work just needs to be prioritized at this point.
>> For at least MILESTONE and BUILD_NUMBER, this looks rather easily fixable so that RELEASE and FULL_VERSION get their final values in spec.gmk instead. I'm working on this.
>> 
>> /Erik
>>>> 
>>>> Will this be going straight into jdk8/build? I need these changes to merge in with the profiles work asap.
>>>> 
>>> The plan is to push this to jdk8/build as soon as the review says ok. Hoping today.
>>>> Thanks,
>>>> David
>>>> 
>>>>> /Erik