Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS
Tim Bell
tim.bell at oracle.com
Mon Jul 2 15:56:10 UTC 2012
On 06/27/12 15:26, John Coomes wrote:
>
> I only looked at the hotspot changes, which are fine.
> One minor request. In hotspot/make/windows/makefiles/defs.make:
>
> 215 else
> 216 ifeq ($(USING_MINGW), true)
> 217 ABS_OUTPUTDIR := $(shell $(CD) $(OUTPUTDIR);$(PWD))
> 218 ABS_BOOTDIR := $(shell $(CD) $(BOOTDIR);$(PWD))
> 219 ABS_GAMMADIR := $(shell $(CD) $(GAMMADIR);$(PWD))
> 220 ABS_OS_MAKEFILE := $(shell $(CD) $(HS_MAKE_DIR)/$(OSNAME);$(PWD))/build.make
> 221 else
>
> You can append line 216 to 215, e.g.,
>
> 215 else ifeq ($(USING_MINGW), true)
>
> which eliminates some indentation and an endif, and I find easier to
> read.
>
> -John
Done. Thanks for the review.
Tim
More information about the build-dev
mailing list