RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

[David Holmes]

Hi Tim,

On 3/07/2012 1:52 PM, Tim Bell wrote:
> All-
>
> This is the hotspot-only portion of the changes to allow building on
> Windows with any of MKS, Cygwin, or MinGW/MSYS as the 'Unix-like' shell
> environment:
>
> http://cr.openjdk.java.net/~tbell/7181175/webrev.00/
>
> A Windows-only JPRT build/test run was successful: job
> 2012-07-02-230003.tbell.hotspot

Did you try both -release 7 and -release 8? There are additional build 
platforms for 8 (Windows versions) though both use VS2010.

> Bug fix #7152336 [1] will be used to update the other repos after these
> changes are in hotspot.
>
> I'd like a quick review from some HS runtime members, and then I will

I'm concerned by a few changes in sa.make.

First all of the changes from \ to /. I can't help but think this was 
left at \ for a reason. Do we know this works on all build platforms? 
Further we still use \ in other makefiles so surely they all need to be 
fixed - eg see adlc.make (the existing inconsistency here is surprising 
and disturbing)

Second this seems wrong:

  "$(COMPILE_RMIC)" -classpath ...

If COMPILE_RMIC is re-defined as "rmic <some-arg>" then the above will 
fail to execute. Plus didn't you already handle the spaces-in-paths 
problem in rules.make when you defined COMPILE_RMIC?

Third the changing of the compiler options from /opt to -opt. In 
compile.make we use /opt for everything. So either your change is 
unnecessary, or there seems to be a lot of other changes needed. ???

> need to ask for a volunteer to push the change in (unless I can do that
> myself by submitting to JPRT... glad to do it if it is OK).

Sorry but you don't have Committer status, nor Author status for the HSX 
project, so will need a sponsor for this contribution.

Cheers,
David
-----

> Thanks in advance-
>
> Tim Bell
>
>
> [1] http://cr.openjdk.java.net/~tbell/7152336/webrev.02/
>