[OpenJDK 2D-Dev] <AWT Dev> Review: Removing GenerateNativeHeader where not needed

Phil Race philip.race at oracle.com
Mon Jul 9 22:02:41 UTC 2012


Fine by me.

-phil.

On 7/4/2012 5:32 AM, Anthony Petrov wrote:
> Looks good to me. Although most of the changes are in Java2D code, so 
> I'm also CC'ing 2d-dev@ to take a look.
>
> -- 
> best regards,
> Anthony
>
> On 7/3/2012 10:23 PM, Erik Joelsson wrote:
>> The build infra project added the use of the annotation 
>> GenerateNativeHeader. It was addded to java classes without native 
>> methods that were listed in the old makefiles as needing headers 
>> generated for them. It was noted then that some of those classes 
>> didn't actually need native headers. To clean things up, we have 
>> tried to identify the empty headers and removed the annotation for 
>> those classes.
>>
>> http://cr.openjdk.java.net/~erikj/build-infra-m1.2/webrev-jdk-awt/ 
>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1.2/webrev-jdk-awt/>




More information about the build-dev mailing list