RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS
Kelly O'Hair
kelly.ohair at oracle.com
Tue Jul 17 21:29:19 UTC 2012
On Jul 2, 2012, at 10:07 PM, David Holmes wrote:
> Second this seems wrong:
>
> "$(COMPILE_RMIC)" -classpath ...
>
> If COMPILE_RMIC is re-defined as "rmic <some-arg>" then the above will fail to execute. Plus didn't you already handle the spaces-in-paths problem in rules.make when you defined COMPILE_RMIC?
I think COMPILE_RMIC is already defined to have quotes in it's definition,
http://cr.openjdk.java.net/~tbell/7181175/webrev.00/make/windows/makefiles/rules.make.sdiff.html
I don't think you need quotes here too.
-kto
More information about the build-dev
mailing list