Reqest for Review: Fix bug in FDS on Solaris

[David Holmes]

Hi Magnus,

On 5/06/2012 1:00 AM, Magnus Ihse Bursie wrote:
> As previously discussed here, there is a bug basically disabling FDS on
> Solaris.
>
> Here is a webrev for a patch from Jonas Oreland
> (jonas.oreland at oracle.com; he's not on this list though).
>
> http://cr.openjdk.java.net/~ihse/fds-solaris-bugfix/webrev.00/
>
> Jonas has done some reasonable amount of testing, looking at command
> lines and making sure they seem alright, and checking that debug
> information is added to output.

This stuff gives me a headache. The changes themselves seem to be okay. 
Though in working through this I am left perplexed as, as far as I can 
see, the variables CFLAGS_DBG and CXXFLAGS_DBG never end up getting used 
anywhere ???

I also can't convince myself if things are correct if TCOV_BUILD is 
defined (whatever that is!) because it disable -g but then FDS will set 
-xs. That said maybe those debug flags never get used anyway.

David
-----

> I have reviewed it myself and find it OK.
>
> Kelly: if this get's OK in the reviews (for my part I'm satisfied if
> Daniel says OK), can you push it into the build forest?
>
> /Magnus