RFR - 7163471: Licensee source bundle failed around 7u4
Nils Loodin
nils.loodin at oracle.com
Tue Jun 5 11:42:07 UTC 2012
You're right. I'll fix and then push.
Thanks a lot David!
Regards,
Nils Loodin
On Jun 5, 2012, at 12:52 , David Holmes wrote:
> Hi Nils,
>
> On 4/06/2012 7:10 PM, Nils Loodin wrote:
>> http://cr.openjdk.java.net/~nloodin/71663471/webrev.00/
>>
>> Simple fix, check if the directory exist or not, and if not don't build
>> that subdirectory.
>>
>> Modelled the mechanic after another makefile in the jdk.
>
> Seems okay. One minor nit:
>
> JFR_SRCDIRS_EXIST = $(shell \
>
> should be
>
> JFR_SRCDIRS_EXIST := $(shell \
>
> so it is only evaluated once (which it would be in this case anyway, but as a general rule ...)
>
> David
More information about the build-dev
mailing list