Reqest for Review: Fix bug in FDS on Solaris

Daniel D. Daugherty daniel.daugherty at oracle.com
Tue Jun 5 14:41:43 UTC 2012


On 6/4/12 9:00 AM, Magnus Ihse Bursie wrote:
> As previously discussed here, there is a bug basically disabling FDS 
> on Solaris.
>
> Here is a webrev for a patch from Jonas Oreland 
> (jonas.oreland at oracle.com; he's not on this list though).
>
> http://cr.openjdk.java.net/~ihse/fds-solaris-bugfix/webrev.00/
>
> Jonas has done some reasonable amount of testing, looking at command 
> lines and making sure they seem alright, and checking that debug 
> information is added to output.
>
> I have reviewed it myself and find it OK.
>
> Kelly: if this get's OK in the reviews (for my part I'm satisfied if 
> Daniel says OK), can you push it into the build forest?

Sorry for the delay. Yesterday was my b-day so I took the day off
to celebrate with my family.

Change looks fine to me.

Magnus, thanks for finding this issue.

Jonas, thanks for providing a fix.

Magnus/Kelly, this fix can either come in thru the build repo or
I can push it via T&L. It will take longer to become available
via T&L...

Please let me know how you guys would prefer this be handled.

Dan



More information about the build-dev mailing list