Reqest for Review: Fix bug in FDS on Solaris

[Daniel D. Daugherty]

On 6/7/12 6:47 PM, Kelly O'Hair wrote:
> On Jun 6, 2012, at 12:45 PM, Daniel D. Daugherty wrote:
>
>> On 6/5/12 8:41 AM, Daniel D. Daugherty wrote:
>>> On 6/4/12 9:00 AM, Magnus Ihse Bursie wrote:
>>>> As previously discussed here, there is a bug basically disabling FDS on Solaris.
>>>>
>>>> Here is a webrev for a patch from Jonas Oreland (jonas.oreland at oracle.com; he's not on this list though).
>>>>
>>>> http://cr.openjdk.java.net/~ihse/fds-solaris-bugfix/webrev.00/
>>>>
>>>> Jonas has done some reasonable amount of testing, looking at command lines and making sure they seem alright, and checking that debug information is added to output.
>>>>
>>>> I have reviewed it myself and find it OK.
>>>>
>>>> Kelly: if this get's OK in the reviews (for my part I'm satisfied if Daniel says OK), can you push it into the build forest?
>>> Sorry for the delay. Yesterday was my b-day so I took the day off
>>> to celebrate with my family.
>>>
>>> Change looks fine to me.
>>>
>>> Magnus, thanks for finding this issue.
>>>
>>> Jonas, thanks for providing a fix.
>>>
>>> Magnus/Kelly, this fix can either come in thru the build repo or
>>> I can push it via T&L. It will take longer to become available
>>> via T&L...
>>>
>>> Please let me know how you guys would prefer this be handled.
>> I've imported Jonas' patch into my local T&L clone, built the bits on
>> Solaris X86, compared the build logs for "all", "debug" and "fastdebug",
>> and compared the sizes of the "all" .diz files with the previous build:
>>
>> - the '-g' and '-xs' options are showing up where expected
>> - '-xO4' is changed to '-xO2' where expected
>> - the .diz files are now bigger since they have more debug info in them;
>>   a combination of effects from '-g' and '-xs'
>>
>> I'm not on the build-dev alias, but I checked pipermail and I don't see
>> any new posts after my last one. I also checked:
>>
>>     http://hg.openjdk.java.net/jdk8/build/jdk
>>
>> and I don't see any sign of this fix already being pushed. I did a search
>> for bugs mentioning FDS and I don't see a new one covering this issue.
>> I'll file a new bug for the issue shortly.
>>
>> I see that Jonas has an OpenJDK user name so I'll list him as the author;
>> I'll list Magnus, David H., Kelly and myself as reviewers.
>>
>> Have I missed anything?
> Nope.
>
> I'm going to let you take this on.  I have some other alligators to kill right now.

The fix is already in JDK8 T&L and 7u6...

Dan