Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

[John Coomes]

Tim Bell (tim.bell at oracle.com) wrote:
> I went over the open changes again and removed some debug code left in
> by mistake, updated copyright dates and fixed a few typos.  Here is an
> updated webrev:
> 
>      http://cr.openjdk.java.net/~tbell/7152336/webrev.01/
> 
> These changes are building in both 32 and 64 bit mode on my Windows 7 
> system.
> 
> jtreg test runs of the '-automatic -noshell' tests under test/java/lang 
> test/java/math test/java/util ran as expected (2 failures, both known 
> bugs).

I only looked at the hotspot changes, which are fine.
One minor request.  In hotspot/make/windows/makefiles/defs.make:

 215 else
 216   ifeq ($(USING_MINGW), true)
 217     ABS_OUTPUTDIR   := $(shell $(CD) $(OUTPUTDIR);$(PWD))
 218     ABS_BOOTDIR     := $(shell $(CD) $(BOOTDIR);$(PWD))
 219     ABS_GAMMADIR    := $(shell $(CD) $(GAMMADIR);$(PWD))
 220     ABS_OS_MAKEFILE := $(shell $(CD) $(HS_MAKE_DIR)/$(OSNAME);$(PWD))/build.make
 221   else

You can append line 216 to 215, e.g.,

 215 else ifeq ($(USING_MINGW), true)

which eliminates some indentation and an endif, and I find easier to
read.

-John

> Thanks in advance for your review and feedback - I'd like to get these 
> changes in soon.
> 
> Tim Bell
> 
> 
> On 06/13/12 22:31, Tim Bell wrote:
> > Hello everyone-
> >
> > Kelly asked me to pick up on bug #/7152336 "//Enable builds on Windows 
> > with MinGW/MSYS"/, and this email thread:
> >
> > http://mail.openjdk.java.net/pipermail/build-dev/2012-April/thread.html#6083 
> >
> >
> > As David pointed out, we will need at least one other bug # for the 
> > hotspot changes.  That said, this is enough to get me started.
> >
> > Hi Volker:
> >
> > I have applied the patches originally from your posting.  Many thanks 
> > for that:
> > http://cr.openjdk.java.net/~simonis/MinGW_MSYS.v1/
> >
> > With a few modifications (keep cpio for non MinGW/Msys builds, keep 
> > MKS as an option), the proposed changes are visible here for review:
> >
> >   http://cr.openjdk.java.net/~tbell/7152336/webrev.00/
> >
> > For reference, my test build log is visible here:
> >
> > http://cr.openjdk.java.net/~tbell/7152336/webrev.00/full_control_build_no_docs.log 
> >
> >
> > Additional test builds on JPRT (our internal build apparatus) verified 
> > that I didn't regress the existing build.
> >
> > Abbreviated jtreg [1] testing on this build was successful:
> >
> > $ /d/tools/jdk8/7152336/windows-i586/bin/java -jar 
> > /d/tools/jtreg-internal/jtreg/lib/jtreg.jar -automatic -noshell 
> > test/java/lang test/java/math test/java/util
> > Directory "JTreport" not found: creating
> > Directory "JTwork" not found: creating
> > Directory "JTwork\scratch" not found: creating
> > Test results: passed: 698; failed: 1; error: 5
> > Report written to D:\tools\jdk8\7152336\jdk\JTreport\html\report.html
> > Results written to D:\tools\jdk8\7152336\jdk\JTwork
> > Error: Some tests failed or other problems occurred.
> >
> > The failing test (java/lang/Math/WorstCaseTests.java) is due to a 
> > known regression: 7174532 
> > <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7174532> 
> > "jdk/test/java/lang/Math/WorstCaseTests.java failing on x86"
> >
> > The 5 error tests are all ignored until bug xxxxxxx (for some value of 
> > x) is resolved.
> >
> > Thanks in advance for your review and feedback -
> >
> > Tim Bell
> >
> > [1]  http://openjdk.java.net/projects/code-tools/
> >
>