Review Request: 7141246 build-infra merge: Introduce new JVM_VARIANT* to control which kind of jvm gets built

[David Holmes]

Erik,

On 12/03/2012 10:18 PM, Erik Joelsson wrote:
> http://cr.openjdk.java.net/~erikj/7141246/webrev.01/
> <http://cr.openjdk.java.net/%7Eerikj/7141246/webrev.01/>
> 267 lines changed: 119 ins; 40 del; 108 mod; 4676 unch

You seem to have included the MINIMAL VM changes in here. Those changes 
have not been pushed to the mainline and are not yet to be pushed. If 
you want to push these build-infra changes you will need to factor out 
the MINIMAL VM stuff - else wait.

David
-----

> 7141246 build-infra merge: Introduce new JVM_VARIANT* to control which
> kind of jvm gets built
>
> The build-infra project is starting to move into jdk8. For the hotspot
> build to stay compatible with the changes, the variables used to control
> which kind of jvm gets built needs to be cleaned up. We propose the
> following scheme:
>
> JVM_VARIANT={server,client,zero etc}
> JVM_VARIANT_SERVER={true,false}
> JVM_VARIANT_CLIENT={true,false}
> etc.
>
> With this scheme it becomes possible to choose any type of jvm, while
> the current scheme can't support only server on 32-bit platform.
>
> Readability in makefile source is much improved with removal of double
> negations.
>
> Backwards compatibility is kept by translating the old variables
> (ZERO_BUILD, BUILD_ONLY_CLIENT etc) to the new variables in make/defs.gmk.
>
>
> Additional note: This change will not make all combinations valid or
> buildable. However, some previously impossible variations are now
> possible, most notably skipping client or kernel on 32-bit hosts.
>
> /Erik