Review Request: Build-infra M1

[Jonathan Gibbons]

Erik, Fredrik,

The need to run GenStubs in the LangTools build is a somewhat transient 
one. During JDK 7 we needed it; right now, we don't, but based on the 
work going into other forests, we will need it again soon, when Lambda 
and Jigsaw make it into JDK 8.

In the proposed Makefiles, the use of GenStubs is unconditional, relying 
on the list of files in lines 132-139 on the new langtools Makefile.  It 
might be better if that list was pulled up into a separate make 
variable, and then the use of GenStubs could be conditional on the list 
being non-empty.

-- Jon

On 03/21/2012 07:07 AM, Erik Joelsson wrote:
> As outlined in [1], the build-infra project would like to push the 
> current work into jdk8 in order to expose it to a wider audience. The 
> webrevs are made against the jdk8/build forest. In each repository, 
> there are two kinds of changes:
>
> 1. Changes to old makefiles and source code to be compatible with the 
> new build.
> 2. The new makefiles
>
> For corba, jaxp and jaxws, all changes of category 1 have already gone 
> in. For langtools, we are awaiting one more change for introducing the 
> GenerateNativeHeader annotation. For hotspot, all necessary changes 
> have been pushed into hotspot-rt. For jdk, there are two webrevs, one 
> with everything and one with just the category 1 changes, to make it 
> easier to see them. Finally for the root repository there are only new 
> files in the common subdir.
>
> root, configure script and makefiles:
> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-root-new/ 
> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-root-new/>
>
> langtools, 1 new makefile:
> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-langtools-new/ 
> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-langtools-new/>
>
> langtools, GenerateNativeHeader annotation (this is already going in 
> through tools, but adding it here for reference as the jdk changes 
> depend on it)
> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-langtools-nativeheader/ 
> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-langtools-nativeheader/>
>
> corba, 1 new makefile:
> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-corba-new/ 
> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-corba-new/>
>
> jaxp, 1 new makefile
> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jaxp-new/ 
> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-jaxp-new/>
>
> jaxws, 1 new makefile
> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jaxws-new/ 
> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-jaxws-new/>
>
> jdk, just the changes to old files
> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jdk-other/ 
> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-jdk-other/>
>
> jdk, all changes including a partial copy of the old makefiles.
> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jdk-new/ 
> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-jdk-new/>
>
> Of course, if you prefer you can look at the new makefiles directly in 
> the build-infra/jdk8 repository forest too.
>
> These changes should not affect the old build at all. To build using 
> the new build system, change directory to "common/makefiles" and:
>
> ../autoconf/configure
> make
> (make images)
>
> State of the new build (the old build should of course be unaffected):
>
>     * Linux 32bit: Works
>     * Linux 64bit: Works
>     * Windows 32bit: Works
>     * Windows 64bit: Works
>     * Solaris i586: Builds but launchers currently unusable
>
> Some notes:
>
>     * The old and new build (on linux x64) produce very close to equal
>       results.  There is a comparison script in
>       common/bin/compareimage.sh with which this can be checked.
>     * Not all makefiles in jdk have been converted yet, for those that
>       haven't been, a copy of the old files are used.
>     * Not all promised features in the java compilation are active and
>       ready in this milestone. Most notably, it's still not using more
>       than one cpu and the nifty new dependency tracking is disabled.
>       A clean build is still pretty fast, but incremental builds
>       aren't as good as they will be yet.
>     * On windows, only cygwin is currently supported.
>
> Now please share your feedback!
>
> /Erik
>
> [1] 
> http://mail.openjdk.java.net/pipermail/build-infra-dev/2012-March/000571.html
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20120321/9267d00d/attachment.htm>