Review Request: Build-infra M1

Fri Mar 30 13:11:34 UTC 2012

Editorial comments like this one in the langtools makefile are 
inappropriate and should be removed.

   53 # (By the way, resource bundles are silly, get rid of them, read the properties directly instead.)

-- Jon

On 03/30/2012 12:56 PM, Erik Joelsson wrote:
> Updated one webrev
>
> root:
> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-root-new.02/ 
> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-root-new.02/>
>
> * Legal headers on all files except compress.post, compress.pre and 
> uncompress.sed.
> * Fixed check for static c++ linking, was supposed to be fixed already 
> but the change had somehow disappeared.
>
> /Erik
>
>
> On 2012-03-29 16:05, Erik Joelsson wrote:
>> Updated webrevs:
>>
>> root, configure script and makefiles:
>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-root-new.01/ 
>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-root-new.01/>
>>
>> langtools, 1 new makefile:
>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-langtools-new.01/ 
>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-langtools-new.01/>
>>
>> corba, 1 new makefile:
>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-corba-new.01/ 
>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-corba-new.01/>
>>
>> jaxp, 1 new makefile
>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jaxp-new.01/ 
>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-jaxp-new.01/>
>>
>> jaxws, 1 new makefile
>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jaxws-new.01/ 
>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-jaxws-new.01/>
>>
>> jdk, all changes including a partial copy of the old makefiles
>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jdk-new.01/ 
>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-jdk-new.01/>
>>
>> General changes:
>> * Added link to documentation to README-builds.html. It's currently 
>> just a short user guide but we plan to expand on this over the next 
>> week. http://openjdk.java.net/projects/build-infra/guide.html
>> * Fixed legal headers.
>> * Cleanup of variable names in configure.
>> * Numerous bugfixes.
>>
>> The GenerateNativeHeaders change has made it into jdk8-master but 
>> hasn't gone into the build forest yet. Same goes for our last hotspot 
>> build change (JVM_VARIANT*). Both of these are needed for the new 
>> build to function properly.
>>
>> Now please share your comments. Especially regarding what information 
>> you would like to see in the documentation.
>>
>> /Erik
>>
>>
>> On 2012-03-21 15:07, Erik Joelsson wrote:
>>> As outlined in [1], the build-infra project would like to push the 
>>> current work into jdk8 in order to expose it to a wider audience. 
>>> The webrevs are made against the jdk8/build forest. In each 
>>> repository, there are two kinds of changes:
>>>
>>> 1. Changes to old makefiles and source code to be compatible with 
>>> the new build.
>>> 2. The new makefiles
>>>
>>> For corba, jaxp and jaxws, all changes of category 1 have already 
>>> gone in. For langtools, we are awaiting one more change for 
>>> introducing the GenerateNativeHeader annotation. For hotspot, all 
>>> necessary changes have been pushed into hotspot-rt. For jdk, there 
>>> are two webrevs, one with everything and one with just the category 
>>> 1 changes, to make it easier to see them. Finally for the root 
>>> repository there are only new files in the common subdir.
>>>
>>> root, configure script and makefiles:
>>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-root-new/ 
>>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-root-new/>
>>>
>>> langtools, 1 new makefile:
>>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-langtools-new/ 
>>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-langtools-new/>
>>>
>>> langtools, GenerateNativeHeader annotation (this is already going in 
>>> through tools, but adding it here for reference as the jdk changes 
>>> depend on it)
>>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-langtools-nativeheader/ 
>>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-langtools-nativeheader/>
>>>
>>> corba, 1 new makefile:
>>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-corba-new/ 
>>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-corba-new/>
>>>
>>> jaxp, 1 new makefile
>>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jaxp-new/ 
>>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-jaxp-new/>
>>>
>>> jaxws, 1 new makefile
>>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jaxws-new/ 
>>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-jaxws-new/>
>>>
>>> jdk, just the changes to old files
>>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jdk-other/ 
>>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-jdk-other/>
>>>
>>> jdk, all changes including a partial copy of the old makefiles.
>>> http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jdk-new/ 
>>> <http://cr.openjdk.java.net/%7Eerikj/build-infra-m1/webrev-jdk-new/>
>>>
>>> Of course, if you prefer you can look at the new makefiles directly 
>>> in the build-infra/jdk8 repository forest too.
>>>
>>> These changes should not affect the old build at all. To build using 
>>> the new build system, change directory to "common/makefiles" and:
>>>
>>> ../autoconf/configure
>>> make
>>> (make images)
>>>
>>> State of the new build (the old build should of course be unaffected):
>>>
>>>     * Linux 32bit: Works
>>>     * Linux 64bit: Works
>>>     * Windows 32bit: Works
>>>     * Windows 64bit: Works
>>>     * Solaris i586: Builds but launchers currently unusable
>>>
>>> Some notes:
>>>
>>>     * The old and new build (on linux x64) produce very close to
>>>       equal results.  There is a comparison script in
>>>       common/bin/compareimage.sh with which this can be checked.
>>>     * Not all makefiles in jdk have been converted yet, for those
>>>       that haven't been, a copy of the old files are used.
>>>     * Not all promised features in the java compilation are active
>>>       and ready in this milestone. Most notably, it's still not
>>>       using more than one cpu and the nifty new dependency tracking
>>>       is disabled. A clean build is still pretty fast, but
>>>       incremental builds aren't as good as they will be yet.
>>>     * On windows, only cygwin is currently supported.
>>>
>>> Now please share your feedback!
>>>
>>> /Erik
>>>
>>> [1] 
>>> http://mail.openjdk.java.net/pipermail/build-infra-dev/2012-March/000571.html
>>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20120330/96421e3e/attachment.htm>