code review request for minor FDS tweak (7157296, 7158067)

Daniel D. Daugherty daniel.daugherty at oracle.com
Fri Mar 30 17:32:28 UTC 2012


Greetings,

In my recent Full Debug Symbols changes, I added the new
ENABLE_FULL_DEBUG_SYMBOLS build flag. I originally implemented
this flag to disable debug info for all build configs which
doesn't make a whole lot of sense for non-product builds. After all
what's a debug build without debug info? (Pretty much the same
thing as a product build).

As is usual, I have one bug to track the hotspot repo changes and
another bug to track the other repos:

     7157296 3/4 FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect
                 OPT builds
     7158067 4/4 FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect
                 product builds

Here are the webrev URLs:

http://cr.openjdk.java.net/~dcubed/fds_revamp/7157296-webrev/0-jdk8-root/
http://cr.openjdk.java.net/~dcubed/fds_revamp/7158067-webrev/0-jdk8-hotspot/
http://cr.openjdk.java.net/~dcubed/fds_revamp/7157296-webrev/0-jdk8-jdk/

Thanks, in advance, for any review comments.

Dan




More information about the build-dev mailing list