From kelly.ohair at oracle.com Tue May 1 22:19:04 2012 From: kelly.ohair at oracle.com (Kelly Ohair) Date: Tue, 1 May 2012 15:19:04 -0700 Subject: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files In-Reply-To: <4F98FAD2.7030808@oracle.com> References: <4F97FFC3.3090509@oracle.com> <4F9817D6.8080701@oracle.com> <4F989F8F.6000905@oracle.com> <4F98FAD2.7030808@oracle.com> Message-ID: <5740792D-2EBF-49A5-9511-E37710FD522F@oracle.com> Magnus, Do you still need this integrated? I can integrate the exact same changset to awt, 2d, and build forests if you want. -kto Sent from my iPhone On Apr 26, 2012, at 0:35, Magnus Ihse Bursie wrote: > On 2012-04-26 03:06, Jim Graham wrote: >> Can we remove these "empty JNI" classes from a list of "javah" classes somewhere so that we don't waste time generating the empty JNI headers? > > Good idea -- that's exactly what is being done in the new build system (the build-infra project)! :-) > > We added a new option to javac, which generates JNI headers automatically, if they are needed -- basically, if the class contains native methods *). So header generation is made always when needed and only when needed, quickly and as a part of normal compilation. > > Since these classes didn't have any native methods, the header files were not generated, and the compile of the native code failed since the #include pointed to non-exisiting files. > > *) Actually, sometimes classes with constants but without native methods are needed. In this case, the new annotation @GenerateNativeHeader is needed. > > /Magnus From luchsh at linux.vnet.ibm.com Wed May 2 08:27:48 2012 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Wed, 02 May 2012 16:27:48 +0800 Subject: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt Message-ID: <4FA0F004.3090407@linux.vnet.ibm.com> Hi build-dev, I've got a minor change to fix an invalid path from README.txt of MemoryMonitor demo, could anybody please help to take a look? http://cr.openjdk.java.net/~luchsh/7165722/ Best regards! - Jonathan From Alan.Bateman at oracle.com Wed May 2 08:36:37 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 02 May 2012 09:36:37 +0100 Subject: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt In-Reply-To: <4FA0F004.3090407@linux.vnet.ibm.com> References: <4FA0F004.3090407@linux.vnet.ibm.com> Message-ID: <4FA0F215.2040605@oracle.com> On 02/05/2012 09:27, Jonathan Lu wrote: > Hi build-dev, > > I've got a minor change to fix an invalid path from README.txt of > MemoryMonitor demo, could anybody please help to take a look? > > http://cr.openjdk.java.net/~luchsh/7165722/ > > Best regards! > - Jonathan > 7165722 was submitted as an incident and I've moved it to the right place. Also cc'ing serviceability-dev as that is where these java.lang.management demos came from. The patch looks fine and I assume Charles will push it for you. -Alan. From artem.ananiev at oracle.com Wed May 2 16:30:18 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Wed, 2 May 2012 09:30:18 -0700 (PDT) Subject: First build-infra push to jdk8 -- try out the new build system! In-Reply-To: <4F9A8C4A.8010305@oracle.com> References: <4F86A4CB.4000908@oracle.com> <4F9A4CE3.5080104@oracle.com> <4F9A5AA8.5050905@oracle.com> <4F9A6D67.10206@oracle.com> <4F9A7921.5020303@oracle.com> <4F9A7B8E.1070108@oracle.com> <4F9A8C4A.8010305@oracle.com> Message-ID: <4FA1611A.6070707@oracle.com> On 4/27/2012 4:08 PM, Magnus Ihse Bursie wrote: > On 2012-04-27 12:57, Artem Ananiev wrote: >> >> On 4/27/2012 2:46 PM, David Holmes wrote: >>> Could it be that the parallelism of the new build is simply too high for >>> your system - hence you get memory exhaustion? >> >> Yes, that's possible, because my desktop has 4Gb RAM. Number of CPU >> cores is only 2, though, so it's not massively parallel. I'm now >> building in 32-bit mode, will check if it helps. > > Try running configure with --with-num-cores=1 to disable parallel builds. > You can also try reducing memory usage by setting > --with-memory-size=1024 (=1 GB) or some other number; I'm not sure > though on exactly in what parts of the build that number is respected, > though. With --with-num-cores=1 the build is much slower, but fails in the same place. --with-memory-size=1024 doesn't help as well... Thanks, Artem > /Magnus From david.katleman at oracle.com Wed May 2 22:54:55 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 22:54:55 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20120502225455.3CD0A470FA@hg.openjdk.java.net> Changeset: 47aa0ddc9126 Author: katleman Date: 2012-04-26 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/47aa0ddc9126 Added tag jdk8-b36 for changeset 6a6ba0a07f33 ! .hgtags Changeset: b2972095a4b1 Author: katleman Date: 2012-05-02 15:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/b2972095a4b1 Merge From david.katleman at oracle.com Wed May 2 22:54:58 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 22:54:58 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b36 for changeset a5a61f259961 Message-ID: <20120502225459.76EAE470FB@hg.openjdk.java.net> Changeset: 83fac66442cf Author: katleman Date: 2012-04-26 14:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/83fac66442cf Added tag jdk8-b36 for changeset a5a61f259961 ! .hgtags From david.katleman at oracle.com Wed May 2 22:55:53 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 22:55:53 +0000 Subject: hg: jdk8/build/hotspot: Added tag jdk8-b36 for changeset 50b4400ca1ec Message-ID: <20120502225555.F0B51470FC@hg.openjdk.java.net> Changeset: bfcf92bfefb8 Author: katleman Date: 2012-04-26 14:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bfcf92bfefb8 Added tag jdk8-b36 for changeset 50b4400ca1ec ! .hgtags From david.katleman at oracle.com Wed May 2 22:56:40 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 22:56:40 +0000 Subject: hg: jdk8/build/jaxp: 2 new changesets Message-ID: <20120502225644.F2145470FD@hg.openjdk.java.net> Changeset: c388369cf4da Author: katleman Date: 2012-04-26 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/c388369cf4da Added tag jdk8-b36 for changeset cfd288fe1d3e ! .hgtags Changeset: 90204bfab4e2 Author: katleman Date: 2012-05-02 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/90204bfab4e2 Merge From david.katleman at oracle.com Wed May 2 22:56:48 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 22:56:48 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b36 for changeset 89b36c658e39 Message-ID: <20120502225650.D4BCC470FE@hg.openjdk.java.net> Changeset: b05a948db1b6 Author: katleman Date: 2012-04-26 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/b05a948db1b6 Added tag jdk8-b36 for changeset 89b36c658e39 ! .hgtags From david.katleman at oracle.com Wed May 2 22:56:57 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 22:56:57 +0000 Subject: hg: jdk8/build/jdk: Added tag jdk8-b36 for changeset 45da9cb055ee Message-ID: <20120502225707.8BA71470FF@hg.openjdk.java.net> Changeset: 9e82ac15ab80 Author: katleman Date: 2012-04-26 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9e82ac15ab80 Added tag jdk8-b36 for changeset 45da9cb055ee ! .hgtags From david.katleman at oracle.com Wed May 2 22:57:57 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 02 May 2012 22:57:57 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b36 for changeset 94bbaa67686f Message-ID: <20120502225759.BBDD947100@hg.openjdk.java.net> Changeset: 5891b38985e8 Author: katleman Date: 2012-04-26 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/5891b38985e8 Added tag jdk8-b36 for changeset 94bbaa67686f ! .hgtags From luchsh at linux.vnet.ibm.com Thu May 3 02:00:06 2012 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Thu, 03 May 2012 10:00:06 +0800 Subject: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt In-Reply-To: <4FA0F215.2040605@oracle.com> References: <4FA0F004.3090407@linux.vnet.ibm.com> <4FA0F215.2040605@oracle.com> Message-ID: <4FA1E6A6.6030505@linux.vnet.ibm.com> Thanks a lot, Alan. I'll go to serviceability-dev list for further discussion. Best regards! - Jonathan Lu On 05/02/2012 04:36 PM, Alan Bateman wrote: > On 02/05/2012 09:27, Jonathan Lu wrote: >> Hi build-dev, >> >> I've got a minor change to fix an invalid path from README.txt of >> MemoryMonitor demo, could anybody please help to take a look? >> >> http://cr.openjdk.java.net/~luchsh/7165722/ >> >> Best regards! >> - Jonathan >> > 7165722 was submitted as an incident and I've moved it to the right > place. Also cc'ing serviceability-dev as that is where these > java.lang.management demos came from. > > The patch looks fine and I assume Charles will push it for you. > > -Alan. > From xerox.time.tech at gmail.com Thu May 3 20:02:26 2012 From: xerox.time.tech at gmail.com (Xin Tong) Date: Thu, 3 May 2012 16:02:26 -0400 Subject: Build openJDK with Developer Options Message-ID: I built openJDK. but i found that some of the options are not enabled. i.e. in my build, only product options are available, develop options are not. How can I build a openJDK with the develop options enabled ? I also do not want a debug build, as the overall performance of debug build and prod build could be very different. Thanks Xin From david.holmes at oracle.com Fri May 4 10:02:08 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 04 May 2012 20:02:08 +1000 Subject: Build openJDK with Developer Options In-Reply-To: References: Message-ID: <4FA3A920.9040908@oracle.com> On 4/05/2012 6:02 AM, Xin Tong wrote: > I built openJDK. but i found that some of the options are not enabled. > i.e. in my build, only product options are available, develop options > are not. How can I build a openJDK with the develop options enabled ? > I also do not want a debug build, as the overall performance of debug > build and prod build could be very different. You would build a fastdebug build to get the develop options but be faster than a debug build. If you want develop options in a product build then you would have to change them to product options - even then you'd need to be sure that the code that implements those options is available in a product build. David From dalibor.topic at oracle.com Fri May 4 10:45:09 2012 From: dalibor.topic at oracle.com (dalibor.topic at oracle.com) Date: Fri, 04 May 2012 10:45:09 +0000 Subject: hg: jdk8/build: 7154130: Add Mac OS X Instructions to README-builds.html Message-ID: <20120504104509.7C53F4714F@hg.openjdk.java.net> Changeset: 2f06b15e2439 Author: ewendeli Date: 2012-05-03 14:17 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/2f06b15e2439 7154130: Add Mac OS X Instructions to README-builds.html Reviewed-by: ohair Contributed-by: edvard.wendelin at oracle.com ! README-builds.html From kelly.ohair at oracle.com Fri May 4 15:25:55 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 4 May 2012 08:25:55 -0700 Subject: Build openJDK with Developer Options In-Reply-To: <4FA3A920.9040908@oracle.com> References: <4FA3A920.9040908@oracle.com> Message-ID: <04914B6D-68AF-4A99-93FD-3294AB6E86D3@oracle.com> What do you consider "develop options"? -kto On May 4, 2012, at 3:02 AM, David Holmes wrote: > On 4/05/2012 6:02 AM, Xin Tong wrote: >> I built openJDK. but i found that some of the options are not enabled. >> i.e. in my build, only product options are available, develop options >> are not. How can I build a openJDK with the develop options enabled ? >> I also do not want a debug build, as the overall performance of debug >> build and prod build could be very different. > > You would build a fastdebug build to get the develop options but be faster than a debug build. If you want develop options in a product build then you would have to change them to product options - even then you'd need to be sure that the code that implements those options is available in a product build. > > David From david.holmes at oracle.com Sun May 6 11:56:35 2012 From: david.holmes at oracle.com (David Holmes) Date: Sun, 06 May 2012 21:56:35 +1000 Subject: Build openJDK with Developer Options In-Reply-To: <04914B6D-68AF-4A99-93FD-3294AB6E86D3@oracle.com> References: <4FA3A920.9040908@oracle.com> <04914B6D-68AF-4A99-93FD-3294AB6E86D3@oracle.com> Message-ID: <4FA666F3.2070503@oracle.com> On 5/05/2012 1:25 AM, Kelly O'Hair wrote: > What do you consider "develop options"? I'm presuming we are referring to the Hotspot "develop" flags defined in globals.hpp and friends. David > -kto > > On May 4, 2012, at 3:02 AM, David Holmes wrote: > >> On 4/05/2012 6:02 AM, Xin Tong wrote: >>> I built openJDK. but i found that some of the options are not enabled. >>> i.e. in my build, only product options are available, develop options >>> are not. How can I build a openJDK with the develop options enabled ? >>> I also do not want a debug build, as the overall performance of debug >>> build and prod build could be very different. >> >> You would build a fastdebug build to get the develop options but be faster than a debug build. If you want develop options in a product build then you would have to change them to product options - even then you'd need to be sure that the code that implements those options is available in a product build. >> >> David > From xerox.time.tech at gmail.com Mon May 7 04:49:25 2012 From: xerox.time.tech at gmail.com (Xin Tong) Date: Mon, 7 May 2012 00:49:25 -0400 Subject: Build openJDK with Developer Options In-Reply-To: <4FA666F3.2070503@oracle.com> References: <4FA3A920.9040908@oracle.com> <04914B6D-68AF-4A99-93FD-3294AB6E86D3@oracle.com> <4FA666F3.2070503@oracle.com> Message-ID: yes, that is right. i figured out that fastdebug is the one i want. Thanks Xin On Sun, May 6, 2012 at 7:56 AM, David Holmes wrote: > On 5/05/2012 1:25 AM, Kelly O'Hair wrote: >> >> What do you consider "develop options"? > > > I'm presuming we are referring to the Hotspot "develop" flags defined in > globals.hpp and friends. > > David > > >> -kto >> >> On May 4, 2012, at 3:02 AM, David Holmes wrote: >> >>> On 4/05/2012 6:02 AM, Xin Tong wrote: >>>> >>>> I built openJDK. but i found that some of the options are not enabled. >>>> i.e. in my build, only product options are available, develop options >>>> are not. How can I build a openJDK with the develop options enabled ? >>>> I also do not want a debug build, as the overall performance of debug >>>> build and prod build could be very different. >>> >>> >>> You would build a fastdebug build to get the develop options but be >>> faster than a debug build. If you want develop options in a product build >>> then you would have to change them to product options - even then you'd need >>> to be sure that the code that implements those options is available in a >>> product build. >>> >>> David >> >> > From littlee at linux.vnet.ibm.com Wed May 9 03:29:12 2012 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Wed, 09 May 2012 11:29:12 +0800 Subject: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt In-Reply-To: <4FA1E6A6.6030505@linux.vnet.ibm.com> References: <4FA0F004.3090407@linux.vnet.ibm.com> <4FA0F215.2040605@oracle.com> <4FA1E6A6.6030505@linux.vnet.ibm.com> Message-ID: <4FA9E488.9020908@linux.vnet.ibm.com> Hi Jonathan, The patch is committed @ Changeset: abb63b7357a1 Author: luchsh Date: 2012-05-09 11:19 +0800 URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abb63b7357a1 7165722: Invalid path in MemoryMonitor demo's README.txt Reviewed-by: alanb, sla Please verify it and thank you all for reviewing. On 05/03/2012 10:00 AM, Jonathan Lu wrote: > Thanks a lot, Alan. > > I'll go to serviceability-dev list for further discussion. > > Best regards! > > - Jonathan Lu > > On 05/02/2012 04:36 PM, Alan Bateman wrote: >> On 02/05/2012 09:27, Jonathan Lu wrote: >>> Hi build-dev, >>> >>> I've got a minor change to fix an invalid path from README.txt of >>> MemoryMonitor demo, could anybody please help to take a look? >>> >>> http://cr.openjdk.java.net/~luchsh/7165722/ >>> >>> Best regards! >>> - Jonathan >>> >> 7165722 was submitted as an incident and I've moved it to the right >> place. Also cc'ing serviceability-dev as that is where these >> java.lang.management demos came from. >> >> The patch looks fine and I assume Charles will push it for you. >> >> -Alan. >> > -- Yours Charles From kelly.ohair at oracle.com Wed May 9 18:13:08 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 9 May 2012 11:13:08 -0700 Subject: Need reviewer - get_source.sh changes Message-ID: This change does not impact any openjdk use, but helps the Oracle engineers get off the forest extension (fclone command) if they want to. Changes the get_source.sh script so that you can provide an optional server replacement path for http://hg.openjdk.java.net and fetching the so called "closed" repositories. 7167593: Changed get_source.sh to allow for getting full oracle jdk repo forest http://cr.openjdk.java.net/~ohair/openjdk8/get_source/webrev/ -kto From david.katleman at oracle.com Wed May 9 23:43:05 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 09 May 2012 23:43:05 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20120509234305.5545747207@hg.openjdk.java.net> Changeset: 2eeb9fac7dfc Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/2eeb9fac7dfc Added tag jdk8-b37 for changeset b2972095a4b1 ! .hgtags Changeset: d939bd0ab13c Author: katleman Date: 2012-05-09 16:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/d939bd0ab13c Merge From david.katleman at oracle.com Wed May 9 23:43:13 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 09 May 2012 23:43:13 +0000 Subject: hg: jdk8/build/corba: 6 new changesets Message-ID: <20120509234317.F2B9E47208@hg.openjdk.java.net> Changeset: c6c0b1047985 Author: jmelvin Date: 2012-04-16 17:10 -0400 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/c6c0b1047985 7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6 Summary: On Mac OS X, align system property "os.arch" with Apple legacy JDKs. Also, improve os.name string matching by using .contains() method instead of .startsWith(). This fix spans multiple repositories. Reviewed-by: dcubed, phh, ohair, katleman ! make/common/shared/Platform.gmk Changeset: 9cdcc0152526 Author: coffeys Date: 2012-04-20 17:34 +0100 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/9cdcc0152526 7161925: sjava files in corba don't have copyright string and legal notice Reviewed-by: chegar Contributed-by: misha.bykov at oracle.com ! src/share/classes/com/sun/corba/se/impl/orbutil/DefineWrapper.sjava ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLTypesUtil_save.sjava Changeset: df0c7369a86b Author: lana Date: 2012-04-26 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/df0c7369a86b Merge Changeset: 4a653e435441 Author: lana Date: 2012-05-01 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/4a653e435441 Merge Changeset: 2d2f6b0f855b Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/2d2f6b0f855b Added tag jdk8-b37 for changeset 83fac66442cf ! .hgtags Changeset: b8cbfb31139f Author: katleman Date: 2012-05-09 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/b8cbfb31139f Merge From david.katleman at oracle.com Wed May 9 23:44:56 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 09 May 2012 23:44:56 +0000 Subject: hg: jdk8/build/hotspot: 20 new changesets Message-ID: <20120509234539.6E54947209@hg.openjdk.java.net> Changeset: 4ee58fcab520 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4ee58fcab520 Added tag jdk8-b37 for changeset bfcf92bfefb8 ! .hgtags Changeset: 3c91f2c9fd21 Author: amurillo Date: 2012-04-20 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3c91f2c9fd21 7163193: new hotspot build - hs24-b09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f3a4ee95783b Author: kevinw Date: 2012-04-20 14:55 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f3a4ee95783b 7162488: VM not printing unknown -XX options Reviewed-by: dholmes, kamg ! src/share/vm/runtime/arguments.cpp + test/runtime/7162488/Test7162488.sh Changeset: 29ee40a082d3 Author: sla Date: 2012-04-23 13:30 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/29ee40a082d3 7162063: libsaproc debug print should format size_t correctly on 64bit platform Reviewed-by: rbackman, mgronlun, dholmes ! agent/src/os/linux/ps_core.c Changeset: f33c4d0f4c9e Author: dcubed Date: 2012-04-23 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f33c4d0f4c9e Merge Changeset: d652a62d6e03 Author: dcubed Date: 2012-03-23 11:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d652a62d6e03 7102323: RFE: enable Full Debug Symbols Phase 1 on Solaris Summary: Add support for ENABLE_FULL_DEBUG_SYMBOLS and ZIP_DEBUGINFO_FILES build flags. Add support for .diz files. Reviewed-by: dholmes, ohair, sspitsyn ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/product.make ! make/windows/makefiles/sa.make Changeset: 744728c16316 Author: dcubed Date: 2012-04-03 09:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/744728c16316 7158067: FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect product builds Summary: Build option FULL_DEBUG_SYMBOLS=0 only affects product builds. Reviewed-by: ohair, jmelvin, sspitsyn ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/defs.make ! make/solaris/Makefile ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 74c359c4a9e5 Author: dcubed Date: 2012-04-24 15:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/74c359c4a9e5 Merge ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/product.make Changeset: d6c393b0164b Author: dcubed Date: 2012-04-25 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d6c393b0164b 7164344: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows Summary: Disable FDS by default on Solaris; disable ZIP_DEBUGINFO_FILES by default on Windows. Reviewed-by: acorn, sspitsyn ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 973046802b6f Author: dlong Date: 2012-04-26 16:24 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/973046802b6f 7162955: Attach api on Solaris, too many open files Summary: Release server-side socket after client receives it. Reviewed-by: sla, dsamersoff, dcubed, acorn Contributed-by: dean.long at oracle.com ! src/os/solaris/vm/attachListener_solaris.cpp Changeset: 6f0612ea55ce Author: jprovino Date: 2012-05-02 15:47 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6f0612ea55ce Merge Changeset: 9f059abe8cf2 Author: jmasa Date: 2012-03-29 19:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9f059abe8cf2 7131629: Generalize the CMS free list code Summary: Make the FreeChunk, FreeList, TreeList, and BinaryTreeDictionary classes usable outside CMS. Reviewed-by: brutisso, johnc, jwilhelm Contributed-by: coleen.phillimore at oracle.com - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp + src/share/vm/memory/binaryTreeDictionary.cpp + src/share/vm/memory/binaryTreeDictionary.hpp + src/share/vm/memory/freeBlockDictionary.cpp + src/share/vm/memory/freeBlockDictionary.hpp + src/share/vm/memory/freeList.cpp + src/share/vm/memory/freeList.hpp ! src/share/vm/memory/generationSpec.cpp ! src/share/vm/precompiled/precompiled.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 8a2e5a6a19a4 Author: johnc Date: 2012-04-25 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8a2e5a6a19a4 7143490: G1: Remove HeapRegion::_top_at_conc_mark_count Summary: Removed the HeapRegion::_top_at_conc_mark_count field. It is no longer needed as a result of the changes for 6888336 and 7127706. Refactored the closures that finalize and verify the liveness counting data so that common functionality was placed into a base class. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegion.inline.hpp Changeset: f69a5d43dc19 Author: jmasa Date: 2012-04-25 09:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f69a5d43dc19 7164144: Fix variable naming style in freeBlockDictionary.* and binaryTreeDictionary* Summary: Fix naming style to be consistent with the predominant hotspot style. Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/binaryTreeDictionary.hpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeBlockDictionary.hpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp Changeset: ee89f2110312 Author: jmasa Date: 2012-04-25 15:51 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ee89f2110312 Merge Changeset: 48fac5d60c3c Author: brutisso Date: 2012-04-25 12:36 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/48fac5d60c3c 7163848: G1: Log GC Cause for a GC Reviewed-by: johnc, jwilhelm, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: bb18e8eecb7e Author: jcoomes Date: 2012-05-04 10:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bb18e8eecb7e Merge - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp Changeset: 7d5ec8bf38d1 Author: amurillo Date: 2012-05-04 14:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7d5ec8bf38d1 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp Changeset: 4e6554041847 Author: amurillo Date: 2012-05-04 14:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4e6554041847 Added tag hs24-b09 for changeset 7d5ec8bf38d1 ! .hgtags Changeset: 637c3f5f068f Author: amurillo Date: 2012-05-09 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/637c3f5f068f Merge ! .hgtags From david.katleman at oracle.com Wed May 9 23:47:16 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 09 May 2012 23:47:16 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b37 for changeset 90204bfab4e2 Message-ID: <20120509234719.230E94720A@hg.openjdk.java.net> Changeset: 5bbe0cb6f2f2 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/5bbe0cb6f2f2 Added tag jdk8-b37 for changeset 90204bfab4e2 ! .hgtags From david.katleman at oracle.com Wed May 9 23:47:25 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 09 May 2012 23:47:25 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b37 for changeset b05a948db1b6 Message-ID: <20120509234728.D67E34720B@hg.openjdk.java.net> Changeset: ac1ba3b56775 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/ac1ba3b56775 Added tag jdk8-b37 for changeset b05a948db1b6 ! .hgtags From david.katleman at oracle.com Wed May 9 23:49:27 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 09 May 2012 23:49:27 +0000 Subject: hg: jdk8/build/jdk: 48 new changesets Message-ID: <20120509235747.133554720D@hg.openjdk.java.net> Changeset: 8e3fb7dd21cd Author: skovatch Date: 2012-04-25 12:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8e3fb7dd21cd 7128699: Fix bundle name so it contains the bugfix number in the name. Reviewed-by: robilad ! make/common/Release-macosx.gmk Changeset: 919be2f7fd6e Author: cgruszka Date: 2012-04-27 14:37 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/919be2f7fd6e Merge Changeset: 762661efef30 Author: jgodinez Date: 2012-04-24 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/762661efef30 7157659: [macosx] Landscape Printing orientation doesn't work Reviewed-by: bae, prr ! src/macosx/native/sun/awt/PrinterView.m Changeset: cdaadcc2c6a4 Author: jgodinez Date: 2012-04-26 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cdaadcc2c6a4 7013850: Please change the mnemonic assignment system to avoid translation issue Reviewed-by: prr, mfang ! src/share/classes/sun/print/ServiceDialog.java ! src/share/classes/sun/print/resources/serviceui.properties ! src/share/classes/sun/print/resources/serviceui_de.properties ! src/share/classes/sun/print/resources/serviceui_es.properties ! src/share/classes/sun/print/resources/serviceui_fr.properties ! src/share/classes/sun/print/resources/serviceui_it.properties ! src/share/classes/sun/print/resources/serviceui_ja.properties ! src/share/classes/sun/print/resources/serviceui_ko.properties ! src/share/classes/sun/print/resources/serviceui_pt_BR.properties ! src/share/classes/sun/print/resources/serviceui_sv.properties ! src/share/classes/sun/print/resources/serviceui_zh_CN.properties ! src/share/classes/sun/print/resources/serviceui_zh_TW.properties Changeset: c2d29a375871 Author: lana Date: 2012-04-26 18:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c2d29a375871 Merge Changeset: 4a19075bb989 Author: lana Date: 2012-05-02 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4a19075bb989 Merge Changeset: 44beb8a52aec Author: zhouyx Date: 2012-04-20 10:34 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/44beb8a52aec 7129742: Unable to view focus in Non-Editable TextArea Summary: Make sure the cursor is visible by setVisible(true) Reviewed-by: rupashka, alexp ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java + test/java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java Changeset: dfa2ea47257d Author: luchsh Date: 2012-04-20 13:13 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dfa2ea47257d 7055065: NullPointerException when sorting JTable with empty cell Reviewed-by: rupashka ! src/share/classes/javax/swing/JTable.java + test/javax/swing/JTable/7055065/bug7055065.java Changeset: 738b32fc3ef1 Author: anthony Date: 2012-04-24 17:47 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/738b32fc3ef1 7150109: [macosx] the Frame showed incomplete. Summary: Open-source the tests Reviewed-by: art + test/java/awt/Frame/FrameStateTest/FrameStateTest.html + test/java/awt/Frame/FrameStateTest/FrameStateTest.java Changeset: 9ed029a0326d Author: anthony Date: 2012-04-24 19:12 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9ed029a0326d 7163898: add isLoggable() check to doLog() Summary: Add the check and return immediately if it's false Reviewed-by: anthony, mchung, sla Contributed-by: Nicolas Carranza ! src/share/classes/sun/util/logging/PlatformLogger.java Changeset: 4a0f6ef43a09 Author: anthony Date: 2012-04-24 20:39 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4a0f6ef43a09 7131021: [macosx] Consider using system properties to pass arguments from the launcher to AWT/SplashScreen Summary: Document the environment variables and add tests Reviewed-by: ksrini ! src/macosx/bin/java_md_macosx.c + test/tools/launcher/EnvironmentVariables.java ! test/tools/launcher/TestHelper.java + test/tools/launcher/TestSpecialArgs.java Changeset: 36fd5078198b Author: alexsch Date: 2012-04-25 16:48 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/36fd5078198b 7163482: [macosx] Regtest closed/javax/swing/JTree/4908142/bug4908142.java intermittent failure Reviewed-by: rupashka + test/javax/swing/JTree/4908142/bug4908142.java Changeset: f1d1dab11a06 Author: leonidr Date: 2012-04-25 18:15 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f1d1dab11a06 7154480: [macosx] Not all popup menu items are visible Reviewed-by: art ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/sun/awt/SunToolkit.java Changeset: 340cda7e1430 Author: luchsh Date: 2012-04-26 12:39 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/340cda7e1430 7154030: java.awt.Component.hide() does not repaint parent component Reviewed-by: rupashka ! src/share/classes/javax/swing/JComponent.java + test/javax/swing/JComponent/7154030/bug7154030.java Changeset: 6314933aeaa9 Author: alexp Date: 2012-04-26 21:16 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6314933aeaa9 7124210: [macosx] Replacing text in a TextField does generate an extra TextEvent Reviewed-by: serb ! src/macosx/classes/sun/lwawt/LWTextAreaPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java Changeset: 4184e5cbf46e Author: alexp Date: 2012-04-26 21:25 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4184e5cbf46e 7124328: [macosx] javax.swing.JDesktopPane.getAllFramesInLayer returns unexpected value Reviewed-by: anthony ! src/share/classes/javax/swing/JDesktopPane.java Changeset: d148d3d194af Author: lana Date: 2012-04-26 18:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d148d3d194af Merge Changeset: bbbf4e63562b Author: dcherepanov Date: 2012-05-02 13:53 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bbbf4e63562b 7154062: [macosx] Mouse cursor isn't updated in applets Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/macosx/CCursorManager.java ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java ! src/macosx/native/sun/awt/CCursorManager.m Changeset: 0fad89bd606b Author: alexsch Date: 2012-05-02 17:54 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0fad89bd606b 7154048: [macosx] At least drag twice, the toolbar can be dragged to the left side Reviewed-by: anthony, leonidr ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTView.h ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Mouse/EnterExitEvents/DragWindowOutOfFrameTest.java + test/java/awt/Mouse/EnterExitEvents/DragWindowTest.java + test/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java ! test/java/awt/regtesthelpers/Util.java Changeset: f906d6068b43 Author: lana Date: 2012-05-02 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f906d6068b43 Merge Changeset: 7b023213681c Author: psandoz Date: 2012-04-19 14:05 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7b023213681c 7162262: (fs) Typo in java.nio.file.Path class description Reviewed-by: alanb ! src/share/classes/java/nio/file/Path.java Changeset: 77b35c5c4b95 Author: jmelvin Date: 2012-04-16 18:09 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/77b35c5c4b95 7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6 Summary: On Mac OS X, align system property "os.arch" with Apple legacy JDKs. Also, improve os.name string matching by using .contains() method instead of .startsWith(). This fix spans multiple repositories. Reviewed-by: dcubed, phh, ohair, katleman ! make/common/Defs-macosx.gmk ! make/common/shared/Platform.gmk ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/share/classes/java/nio/Bits.java ! src/share/classes/java/util/prefs/Preferences.java ! src/share/classes/sun/awt/OSInfo.java ! src/share/classes/sun/font/FontUtilities.java ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! src/share/classes/sun/print/PSPrinterJob.java ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/Credentials.java ! src/share/classes/sun/security/provider/ByteArrayAccess.java ! src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java ! src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! test/demo/jvmti/DemoRun.java ! test/java/io/File/GetXSpace.java ! test/java/lang/ProcessBuilder/Basic.java ! test/java/lang/ProcessBuilder/Zombies.java ! test/java/lang/invoke/InvokeGenericTest.java ! test/java/lang/management/OperatingSystemMXBean/GetSystemLoadAverage.java ! test/java/nio/channels/FileChannel/Size.java ! test/java/nio/channels/FileChannel/Transfer.java ! test/java/nio/file/FileSystem/Basic.java ! test/sun/nio/ch/SelProvider.java ! test/tools/launcher/TestHelper.java Changeset: 079bb040b2ee Author: coleenp Date: 2012-04-19 10:53 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/079bb040b2ee Merge Changeset: 404c8e097ae9 Author: vinnie Date: 2012-04-19 16:58 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/404c8e097ae9 7162823: Modify the list of excluded tests (ProblemList Reviewed-by: alanb ! test/ProblemList.txt Changeset: bc51d0569ccd Author: khazra Date: 2012-04-19 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bc51d0569ccd 7162385: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing again Summary: Enable finding "foo1.jar" Reviewed-by: chegar ! test/sun/net/www/protocol/jar/B4957695.java Changeset: 715f50872ae7 Author: khazra Date: 2012-04-19 18:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/715f50872ae7 7158636: InterfaceAddress.getBroadcast() returns invalid broadcast address on WLAN Summary: Update Windows native code to infer WLAN interface type in Windows Vista and later Reviewed-by: chegar, alanb ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface.h Changeset: c3905c1f5da7 Author: zhouyx Date: 2012-04-20 16:11 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c3905c1f5da7 7159982: ZipFile uses static for error message when malformed zip file encountered Reviewed-by: alanb, dholmes ! src/share/native/java/util/zip/ZipFile.c ! src/share/native/java/util/zip/zip_util.c Changeset: ec9876082b4e Author: ksrini Date: 2012-04-22 06:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ec9876082b4e 6981776: Pack200 must support -target 7 bytecodes Summary: pack200 implementation of JSR-200 updated for JSR-292 changes Reviewed-by: jrose, ksrini Contributed-by: john.r.rose at oracle.com, kumar.x.srinivasan at oracle.com ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/ClassWriter.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/TLGlobals.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bands.h ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/defines.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.h ! test/tools/pack200/AttributeTests.java ! test/tools/pack200/PackageVersionTest.java ! test/tools/pack200/Utils.java - test/tools/pack200/dyn.jar ! test/tools/pack200/pack200-verifier/data/README ! test/tools/pack200/pack200-verifier/data/golden.jar ! test/tools/pack200/pack200-verifier/make/build.xml ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: c2da01f0bdc1 Author: alanb Date: 2012-04-22 19:09 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c2da01f0bdc1 7163395: jdk8/tl no longer builds on Mac Reviewed-by: chegar, ohair, ksrini - src/macosx/bin/amd64/jvm.cfg + src/macosx/bin/x86_64/jvm.cfg Changeset: 07dab8d9e34a Author: alanb Date: 2012-04-22 19:12 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/07dab8d9e34a Merge - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 1980be18d0f8 Author: alanb Date: 2012-04-22 21:22 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1980be18d0f8 7132924: (dc) DatagramChannel.disconnect throws SocketException with IPv4 socket and IPv6 enabled [macosx] Reviewed-by: chegar ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/solaris/native/sun/nio/ch/DatagramChannelImpl.c ! src/windows/native/sun/nio/ch/DatagramChannelImpl.c + test/java/nio/channels/DatagramChannel/Disconnect.java Changeset: fd22345bf1bf Author: sla Date: 2012-04-23 16:34 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fd22345bf1bf 7163524: Add SecTaskAccess attribute to jstack [macosx] Reviewed-by: dholmes ! make/launchers/Makefile.launcher Changeset: 2c35304e885a Author: youdwei Date: 2012-04-24 21:06 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2c35304e885a 7163865: Performance improvement for DateFormatSymbols.getZoneIndex(String) Reviewed-by: okutsu ! src/share/classes/java/text/DateFormatSymbols.java Changeset: f68c854fa584 Author: ksrini Date: 2012-04-24 10:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f68c854fa584 7151434: java -jar -XX crashes java launcher Reviewed-by: mchung, darcy ! src/share/bin/java.c ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java Changeset: fcdbd1f34309 Author: khazra Date: 2012-04-24 14:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fcdbd1f34309 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup() Summary: Get default interface for Mac OS X when interface is not set Reviewed-by: chegar ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/net_util_md.c Changeset: 3e398b549cea Author: khazra Date: 2012-04-25 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3e398b549cea 7160242: (prefs) Preferences.remove(null) does not throw NPE [macosx] Summary: Insert null check of argument in remove()'s implementation Reviewed-by: forax, chegar, alanb ! src/macosx/classes/java/util/prefs/MacOSXPreferences.java + test/java/util/prefs/RemoveNullKeyCheck.java Changeset: 108a02a57b75 Author: khazra Date: 2012-04-26 12:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/108a02a57b75 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion Summary: Enable user to read/write preferences to persistent storage Reviewed-by: alanb ! src/macosx/classes/java/util/prefs/MacOSXPreferences.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java Changeset: 1cdcca9f3530 Author: lana Date: 2012-04-26 14:21 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1cdcca9f3530 Merge Changeset: f0842ed897c3 Author: xuelei Date: 2012-04-27 04:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f0842ed897c3 6996372: synchronizing handshaking hash Summary: remove the unnecessary synchronization. Also reviewed by David Schlosnagle (schlosna at gmail.com) Reviewed-by: weijun ! src/share/classes/sun/security/util/DisabledAlgorithmConstraints.java Changeset: c22b2f9066dd Author: alanb Date: 2012-05-01 11:17 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c22b2f9066dd 7164570: (fs) WatchService queues CREATE event but not DELETE event for very short lived files [sol11] Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/SolarisWatchService.java + test/java/nio/file/WatchService/MayFlies.java Changeset: 71fdf32fdc65 Author: xuelei Date: 2012-05-01 03:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/71fdf32fdc65 7158688: Typo in SSLContext Spec Reviewed-by: weijun, wetmore ! src/share/classes/javax/net/ssl/SSLContext.java Changeset: 6c9c3d7ce9e2 Author: lana Date: 2012-05-01 11:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6c9c3d7ce9e2 Merge Changeset: 46e0bd218fcc Author: mchung Date: 2012-05-01 19:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/46e0bd218fcc 7164376: Replace use of sun.security.action.LoadLibraryAction with System.loadLibrary Reviewed-by: alanb, mullan, prr ! src/macosx/classes/apple/launcher/JavaAppLauncher.java ! src/macosx/classes/apple/security/KeychainStore.java ! src/macosx/classes/com/apple/concurrent/LibDispatchNative.java ! src/macosx/classes/com/apple/eawt/Application.java ! src/macosx/classes/com/apple/eio/FileManager.java ! src/macosx/classes/com/apple/laf/AquaFileView.java ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/com/apple/laf/AquaNativeResources.java ! src/macosx/classes/com/apple/laf/ScreenMenu.java ! src/macosx/classes/com/apple/laf/ScreenPopupFactory.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/macosx/classes/sun/lwawt/macosx/CAccessibility.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/java/awt/SplashScreen.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/event/NativeLibLoader.java ! src/share/classes/java/awt/image/ColorModel.java ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/DatagramPacket.java ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/NetworkInterface.java ! src/share/classes/sun/awt/NativeLibLoader.java ! src/share/classes/sun/awt/image/JPEGImageDecoder.java ! src/share/classes/sun/awt/image/NativeLibLoader.java ! src/share/classes/sun/java2d/Disposer.java ! src/share/classes/sun/management/ManagementFactoryHelper.java ! src/share/classes/sun/net/sdp/SdpSupport.java ! src/share/classes/sun/net/spi/DefaultProxySelector.java ! src/share/classes/sun/nio/ch/Util.java - src/share/classes/sun/security/action/LoadLibraryAction.java ! src/share/classes/sun/security/krb5/SCDynamicStoreConfig.java ! src/share/classes/sun/security/smartcardio/PCSC.java ! src/share/classes/sun/tracing/dtrace/JVM.java ! src/solaris/classes/sun/management/FileSystemImpl.java ! src/solaris/classes/sun/net/dns/ResolverConfigurationImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java ! src/solaris/classes/sun/print/CUPSPrinter.java ! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/management/FileSystemImpl.java ! src/windows/classes/sun/net/dns/ResolverConfigurationImpl.java ! src/windows/classes/sun/print/Win32PrintServiceLookup.java ! src/windows/classes/sun/security/smartcardio/PlatformPCSC.java Changeset: d78c6095dc98 Author: vinnie Date: 2012-05-02 14:50 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d78c6095dc98 7087021: TEST: com/sun/crypto/provider/Mac/MacClone.java failed on Solaris sparc 5.10 Reviewed-by: mullan ! test/com/sun/crypto/provider/Mac/MacClone.java Changeset: 717582c056f3 Author: lana Date: 2012-05-02 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/717582c056f3 Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java ! test/tools/launcher/TestHelper.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: bc0f9e693620 Author: lana Date: 2012-05-08 13:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bc0f9e693620 Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 185821106403 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/185821106403 Added tag jdk8-b37 for changeset 9e82ac15ab80 ! .hgtags Changeset: c45f3509a707 Author: katleman Date: 2012-05-09 13:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c45f3509a707 Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java From david.katleman at oracle.com Thu May 10 00:00:09 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 10 May 2012 00:00:09 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b37 for changeset 5891b38985e8 Message-ID: <20120510000014.C7FF64720E@hg.openjdk.java.net> Changeset: 1f224f160aa8 Author: katleman Date: 2012-05-09 13:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/1f224f160aa8 Added tag jdk8-b37 for changeset 5891b38985e8 ! .hgtags From erik.joelsson at oracle.com Thu May 10 07:36:32 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 10 May 2012 09:36:32 +0200 Subject: Need reviewer - get_source.sh changes In-Reply-To: References: Message-ID: <4FAB7000.7050804@oracle.com> That will certainly be convenient. I've tried it and it works for me. Code looks good. /Erik On 2012-05-09 20:13, Kelly O'Hair wrote: > This change does not impact any openjdk use, but helps the Oracle engineers get off the > forest extension (fclone command) if they want to. > > Changes the get_source.sh script so that you can provide an optional server replacement > path for http://hg.openjdk.java.net and fetching the so called "closed" repositories. > > 7167593: Changed get_source.sh to allow for getting full oracle jdk repo forest > http://cr.openjdk.java.net/~ohair/openjdk8/get_source/webrev/ > > -kto From chris.hegarty at oracle.com Thu May 10 08:09:15 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 10 May 2012 09:09:15 +0100 Subject: Need reviewer - get_source.sh changes In-Reply-To: <4FAB7000.7050804@oracle.com> References: <4FAB7000.7050804@oracle.com> Message-ID: <4FAB77AB.4030201@oracle.com> On 10/05/2012 08:36, Erik Joelsson wrote: > That will certainly be convenient. I've tried it and it works for me. > Code looks good. +1, thanks Kelly. Anything that aids the migration off the forest extension can only be a good thing. The changes look fine to me. -Chris. > /Erik > > On 2012-05-09 20:13, Kelly O'Hair wrote: >> This change does not impact any openjdk use, but helps the Oracle >> engineers get off the >> forest extension (fclone command) if they want to. >> >> Changes the get_source.sh script so that you can provide an optional >> server replacement >> path for http://hg.openjdk.java.net and fetching the so called >> "closed" repositories. >> >> 7167593: Changed get_source.sh to allow for getting full oracle jdk >> repo forest >> http://cr.openjdk.java.net/~ohair/openjdk8/get_source/webrev/ >> >> -kto From staffan.larsen at oracle.com Thu May 10 10:35:09 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 10 May 2012 12:35:09 +0200 Subject: Need reviewer - get_source.sh changes In-Reply-To: References: Message-ID: <18B8EF43-3F41-4001-A798-0302657E6589@oracle.com> Looks good! /Staffan On 9 maj 2012, at 20:13, Kelly O'Hair wrote: > > This change does not impact any openjdk use, but helps the Oracle engineers get off the > forest extension (fclone command) if they want to. > > Changes the get_source.sh script so that you can provide an optional server replacement > path for http://hg.openjdk.java.net and fetching the so called "closed" repositories. > > 7167593: Changed get_source.sh to allow for getting full oracle jdk repo forest > http://cr.openjdk.java.net/~ohair/openjdk8/get_source/webrev/ > > -kto From kelly.ohair at oracle.com Thu May 10 15:26:45 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Thu, 10 May 2012 15:26:45 +0000 Subject: hg: jdk8/build: 7167593: Changed get_source.sh to allow for getting full oracle jdk repo forest Message-ID: <20120510152645.62B4D47229@hg.openjdk.java.net> Changeset: 955a3e8ed4f0 Author: ohair Date: 2012-05-10 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/955a3e8ed4f0 7167593: Changed get_source.sh to allow for getting full oracle jdk repo forest Reviewed-by: erikj, asaha, chegar, sla, dholmes, mbykov, coleenp ! get_source.sh ! make/scripts/hgforest.sh From Sergey.Bylokhov at oracle.com Thu May 10 15:57:51 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 10 May 2012 19:57:51 +0400 Subject: First build-infra push to jdk8 -- try out the new build system! In-Reply-To: <4F86A4CB.4000908@oracle.com> References: <4F86A4CB.4000908@oracle.com> Message-ID: <4FABE57F.7090109@oracle.com> Hi, Magnus. I tried to use the new building system to build jdk 8 on windows 7 x64 and found that freetype2 library is necessary, but as far I understand it should not be necessary for closed jdk. 12.04.2012 13:47, Magnus Ihse Bursie wrote: > The build-infra project [1] has been working for a while with creating > a new build system. The goals of the project include, but are not > limited to, improved build performance and improved ease of use. > > The first part of this project has now been pushed to the jdk8 master > forest. This means that the new build system is available for you to > try out! The old build system is still there, and if you want to > continue to use it, you will notice no difference (for now...). > > But if you are interested in trying the new build system, we welcome > you to experiment with it! The basic operation is: > cd common/makefiles > ../autoconf/configure > make > > More information is available in the new build README [2]. If you want > to try the new build system, please read it first. > > Please note that the new build system is not yet complete. We do not > yet have full platform support, nor are all parts of the old build > converted (but then we fall back on the old build system), and there > are likely to be bugs. Most of all, we need to have exposure on a wide > range of different build systems, since the reality is always so much > messier than you'd want to believe. :-) Please help us to resolve such > issues early by trying the new build system! > > Any questions or discussions on the new build system should be sent to > build-dev at openjdk.java.net. > > /Magnus > > [1] http://openjdk.java.net/projects/build-infra/index.html > [2] http://openjdk.java.net/projects/build-infra/guide.html > From kelly.ohair at oracle.com Thu May 10 20:42:14 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 10 May 2012 13:42:14 -0700 Subject: Need reviewer - get_source.sh changes In-Reply-To: <18B8EF43-3F41-4001-A798-0302657E6589@oracle.com> References: <18B8EF43-3F41-4001-A798-0302657E6589@oracle.com> Message-ID: I messed up somehow, the sed command is misbehaving on me constructing the extra repo path. I have changed the logic to sed out the tail of the default path, then just glue that to the extra path. Unfortunately, I pushed the first set of changes (could have sworn it worked on the Mac) so I need to do another CR 7167976: Fix broken get_source.sh script http://cr.openjdk.java.net/~ohair/openjdk8/get_source2/webrev/ -kto On May 10, 2012, at 3:35 AM, Staffan Larsen wrote: > Looks good! > > /Staffan > > On 9 maj 2012, at 20:13, Kelly O'Hair wrote: > >> >> This change does not impact any openjdk use, but helps the Oracle engineers get off the >> forest extension (fclone command) if they want to. >> >> Changes the get_source.sh script so that you can provide an optional server replacement >> path for http://hg.openjdk.java.net and fetching the so called "closed" repositories. >> >> 7167593: Changed get_source.sh to allow for getting full oracle jdk repo forest >> http://cr.openjdk.java.net/~ohair/openjdk8/get_source/webrev/ >> >> -kto > From senseneyj at mail.nih.gov Thu May 10 21:48:34 2012 From: senseneyj at mail.nih.gov (Senseney, Justin (NIH/CIT) [E]) Date: Thu, 10 May 2012 17:48:34 -0400 Subject: RFE: 64 bit pointers needed Message-ID: <0CADA15E942196438C242C19FA72B4FC046E8796CB@NIHMLBX01.nih.gov> Title: RFE: 64 bit pointers needed Author: Justin Senseney Organization: National Institutes of Health Owner: Justin Senseney Created: 2012/04/17 Type: Feature State: Draft Exposure: Open Component: core/lang Scope: JDK JSR: TBD RFE: 4963452 (4850923, 4880587, 4088441, 6292967) Discussion: compiler-dev at openjdk.java.net Start: 2012/Q3 Depends: Blocks: Effort: XL Duration: L Template: 1.0 Internal-refs: Reviewed-by: Endorsed-by: Funded-by: Summary ------- As per the Java Language Specification, section 10.4, all array access in Java is done by using an int as index. Since an int is a signed 32bit value, this limits the total number of addressable elements of an array to 2**31 (about 2 billion). It should be possible to address an array using 64bit values. Goals ----- Improved handling of large datasets that need to be stored in contiguous arrays. Non-Goals --------- Not changing existing range of Integer Success Metrics --------------- Able to compile boolean[] a = new boolean[Long.MAX_VALUE]; Motivation ---------- While having access to 2 billion entries may seem sufficient, there are very compelling performance reasons to be able to use more in a single array. As an example, consider a square n*n matrix, stored as an array (either row or column major, doesn't matter which). Since an array stores at most 2**31 entries, this means that n=sqrt(2**31)=46341, thus the matrix cannot be very large. For multidimensional arrays this is an even more severe limitation (3d Tensors could at most be of size 1290). Description ----------- The scope of this work is extensive, however the solution may be quite technically feasible. Alternatives ------------ A workaround is to use an array of arrays (ie. double[][]). However there is no guarantee that successive rows will be laid of linearly in memory, and therefore performance may be severely penalized. Experimentally, performance may suffer by a factor of over 2, often far greater. Also, most existing matrix packages (ie. LAPACK) assumes linear storage, and are thus incompatible with a double[][] storage (requires double[]). Calling a LAPACK routine with a jagged storage thus requires extra array copying and memory allocation, and can further decrease performance and increase memory requirements. Testing ------- It should be possible to address arrays using 64bit integers (long?), as this provides a seamless transition for users of 64bit computers. Risks and Assumptions --------------------- Use of array of array constructs (use double[][] instead of double[]) possible as workaround. This feature is well implemented in C/C++ without any problem, so should be quite technically feasible to implement. Dependences ----------- None none. Impact ------ My group has requested this feature for several years. It is currently listed as one of the top 25 RFEs on http://bugs.sun.com/top25_rfes.do. Please help Java maintain its relevance by implementing this. I have several image processing applications that are severely limited by this bug, these images cannot be opened in most Java applications. These include electron microscopy and micro-CT images where storage of a single slice requires more entries than allowable in a Java array. Thank you for considering this RFE, Justin Senseney BIRSS/ISL/DCB/CIT/NIH 301-594-5887 301-480-0028 (fax) Building 12A/2015 http://mipav.cit.nih.gov http://dcb.cit.nih.gov/~senseneyj http://image.nih.gov -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.bosschaert at gmail.com Fri May 11 07:54:14 2012 From: david.bosschaert at gmail.com (David Bosschaert) Date: Fri, 11 May 2012 08:54:14 +0100 Subject: Fwd: Intermittent errors while building OpenJDK Message-ID: Some people on the Penrose project are seeing intermittent build problems, like for example the one below. It's happening on Linux, I haven't tried platforms. Are other people seeing this too? Thanks, David ---------- Forwarded message ---------- From: David Bosschaert Date: 9 May 2012 14:29 Subject: Re: Intermittent errors while building OpenJDK/Penrose To: penrose-dev at openjdk.java.net This seems to be somewhat related to the number of processors available to the compilation process. I'm typically working inside a Virtual Machine (VirtualBox) and reducing the number of processors available from 2 to 1 seems to have resolved the issue. A bit worrying... David On 8 May 2012 11:34, David Bosschaert wrote: > Hi, > > I'm regularly getting build problems like this one. Restarting the > build after this generally works, but its very odd. The error below is > just one example, I've seen different ones popping up here and there. > Anyone else seeing this too, or is it only me? > > Thanks, > > David > > An exception has occurred in the compiler (1.8.0-internal). Please > file a bug at the Java Developer Connection > (http://java.sun.com/webapps/bugreport) ?after checking the Bug Parade > for duplicates. Include your program and the following diagnostic in > your report. ?Thank you. > java.lang.AbstractMethodError > ? ? ? ?at com.sun.tools.javac.code.Type$MethodType.accept(Type.java:880) > ? ? ? ?at com.sun.tools.javac.code.Types$DefaultTypeVisitor.visit(Types.java:3705) > ? ? ? ?at com.sun.tools.javac.code.Types.isSameType(Types.java:610) > ? ? ? ?at com.sun.tools.javac.comp.Check.checkConflicts(Check.java:2284) > ? ? ? ?at com.sun.tools.javac.comp.Lower$1.visitMethodDef(Lower.java:648) > ? ? ? ?at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:736) > ? ? ? ?at com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:50) > ? ? ? ?at com.sun.tools.javac.tree.TreeScanner.scan(TreeScanner.java:58) > ? ? ? ?at com.sun.tools.javac.tree.TreeScanner.visitClassDef(TreeScanner.java:142) > ? ? ? ?at com.sun.tools.javac.comp.Lower$1.visitClassDef(Lower.java:665) > ? ? ? ?at com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:658) > ? ? ? ?at com.sun.tools.javac.comp.Lower.checkConflicts(Lower.java:638) > ? ? ? ?at com.sun.tools.javac.comp.Lower.translateTopLevelClass(Lower.java:3713) > ? ? ? ?at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1429) > ? ? ? ?at com.sun.tools.javac.main.JavaCompiler.desugar(JavaCompiler.java:1307) > ? ? ? ?at com.sun.tools.javac.main.JavaCompiler.compile2(JavaCompiler.java:904) > ? ? ? ?at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:863) > ? ? ? ?at com.sun.tools.javac.main.Main.compile(Main.java:472) > ? ? ? ?at com.sun.tools.javac.main.Main.compile(Main.java:389) > ? ? ? ?at com.sun.tools.javac.main.Main.compile(Main.java:378) > ? ? ? ?at com.sun.tools.javac.main.Main.compile(Main.java:369) > ? ? ? ?at com.sun.tools.javac.Main.compile(Main.java:76) > ? ? ? ?at com.sun.tools.javac.Main.main(Main.java:61) From nils.loodin at oracle.com Fri May 11 11:08:37 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 11 May 2012 13:08:37 +0200 Subject: Fwd: test_gamma on osx References: <8162FF33-C939-4B33-B308-50309710DC1E@oracle.com> Message-ID: <0D619475-AF3C-4E45-B9A9-DD4F5E7308A8@oracle.com> I cannot get test_gamma to work at all without this patch. I have tested it on three different macs. DYLD_LIBRARY_PATY seems directly copied from LD_LIBRARY_PATH on linux, and references a lot of dirs not present on osx. Will you consider this for inclusion? The lines were added, as David Holmes points out, with the bug 7125793: MAC: test_gamma should always work. This was a larger patch that affects lots of different files however, and this removes just part of that. Regards, Nils Loodin diff --git a/make/bsd/makefiles/buildtree.make b/make/bsd/makefiles/buildtree.make --- a/make/bsd/makefiles/buildtree.make +++ b/make/bsd/makefiles/buildtree.make @@ -471,11 +471,6 @@ echo "unset LD_LIBRARY_PATH_32"; \ echo "unset LD_LIBRARY_PATH_64"; \ echo ""; \ - echo "if [ \"$(OS_VENDOR)\" = \"Darwin\" ]; then "; \ - echo " DYLD_LIBRARY_PATH=.:$${DYLD_LIBRARY_PATH:+$$DYLD_LIBRARY_PATH:}\$${JAVA_HOME}/jre/lib/native_threads:\$${JAVA_HOME}/jre/lib:$${DYLD_LIBRARY_PATH:+$$DYLD_LIBRARY_PATH:}\$${JAVA_HOME}/jre/lib/${LIBARCH}/native_threads:\$${JAVA_HOME}/jre/lib/${LIBARCH}:${GCC_LIB}"; \ - echo " export DYLD_LIBRARY_PATH"; \ - echo "fi"; \ - echo ""; \ echo "# Use the gamma launcher and JAVA_HOME to run the test"; \ echo ""; \ echo "./\$${GAMMA_PROG} $(TESTFLAGS) Queens < /dev/null"; \ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From magnus.ihse.bursie at oracle.com Fri May 11 14:47:00 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Fri, 11 May 2012 16:47:00 +0200 Subject: Request for Review: Fix sed expression in compare-images target Message-ID: <4FAD2664.7030302@oracle.com> The Release Engineering team in Oracle encountered a problem when building in a path that contained the character "@". Normally, having strange names in the directory where you are building is not a good idea, but in this case the path was created by the Hudson CI system. The problem is a single sed expression, basically "sed -s at ...@..@". I changed this to "sed -s|...|...|", a character that is much less likely to actually appear in a filename. Webrev here: http://cr.openjdk.java.net/~ihse/fix-compare-image-sed/webrev.00/ Kelly, if this is accepted by reviewers, can you create a bug and push this? /Magnus From kelly.ohair at oracle.com Fri May 11 15:21:44 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 11 May 2012 15:21:44 +0000 Subject: hg: jdk8/build/jdk: 7168208: Change use of @ in one sed command involving paths to different character Message-ID: <20120511152222.9F28F4728D@hg.openjdk.java.net> Changeset: c2d9166f3284 Author: ihse Date: 2012-05-11 08:21 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c2d9166f3284 7168208: Change use of @ in one sed command involving paths to different character Reviewed-by: ohair ! make/common/Release.gmk From kelly.ohair at oracle.com Fri May 11 15:25:20 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 11 May 2012 08:25:20 -0700 Subject: Request for Review: Fix sed expression in compare-images target In-Reply-To: <4FAD2664.7030302@oracle.com> References: <4FAD2664.7030302@oracle.com> Message-ID: Done: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c2d9166f3284 To clarify, this is a surgical fix to one sed command to deal with Hudson adding @ characters to pathnames. I'm still of the opinion that adding @ characters to paths is a bad idea, but this change is harmless and helps the RE team with their use of Hudson. Let's hope they don't start adding | characters to path names, or worse, spaces. ;^) -kto On May 11, 2012, at 7:47 AM, Magnus Ihse Bursie wrote: > The Release Engineering team in Oracle encountered a problem when building in a path that contained the character "@". Normally, having strange names in the directory where you are building is not a good idea, but in this case the path was created by the Hudson CI system. > > The problem is a single sed expression, basically "sed -s at ...@..@". I changed this to "sed -s|...|...|", a character that is much less likely to actually appear in a filename. > > Webrev here: > > http://cr.openjdk.java.net/~ihse/fix-compare-image-sed/webrev.00/ > > Kelly, if this is accepted by reviewers, can you create a bug and push this? > > /Magnus > From erik.joelsson at oracle.com Fri May 11 16:05:50 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 11 May 2012 18:05:50 +0200 Subject: Request for Review: Fix sed expression in compare-images target In-Reply-To: <4FAD2664.7030302@oracle.com> References: <4FAD2664.7030302@oracle.com> Message-ID: <4FAD38DE.7020905@oracle.com> Looks good to me On 2012-05-11 16:47, Magnus Ihse Bursie wrote: > The Release Engineering team in Oracle encountered a problem when > building in a path that contained the character "@". Normally, having > strange names in the directory where you are building is not a good > idea, but in this case the path was created by the Hudson CI system. > > The problem is a single sed expression, basically "sed -s at ...@..@". I > changed this to "sed -s|...|...|", a character that is much less > likely to actually appear in a filename. > > Webrev here: > > http://cr.openjdk.java.net/~ihse/fix-compare-image-sed/webrev.00/ > > Kelly, if this is accepted by reviewers, can you create a bug and push > this? > > /Magnus > From kelly.ohair at oracle.com Sat May 12 00:53:08 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Sat, 12 May 2012 00:53:08 +0000 Subject: hg: jdk8/build: 7167976: Fix broken get_source.sh script Message-ID: <20120512005309.0069D472AF@hg.openjdk.java.net> Changeset: 8a4e92c10a9a Author: ohair Date: 2012-05-11 17:52 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/8a4e92c10a9a 7167976: Fix broken get_source.sh script Reviewed-by: tbell ! make/scripts/hgforest.sh From magnus.ihse.bursie at oracle.com Mon May 14 08:18:53 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Mon, 14 May 2012 10:18:53 +0200 Subject: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files In-Reply-To: <5740792D-2EBF-49A5-9511-E37710FD522F@oracle.com> References: <4F97FFC3.3090509@oracle.com> <4F9817D6.8080701@oracle.com> <4F989F8F.6000905@oracle.com> <4F98FAD2.7030808@oracle.com> <5740792D-2EBF-49A5-9511-E37710FD522F@oracle.com> Message-ID: <4FB0BFED.8000107@oracle.com> On 2012-05-02 00:19, Kelly Ohair wrote: > Magnus, > > Do you still need this integrated? > I can integrate the exact same changset to awt, 2d, and build forests if you want. Yes, I still like to have this integrated. (Sorry for the slow response, it's been a bit low on the priority list.) Otherwise we need to add a @GenerateNativeHeaders annotation to a class that only generates an empty header file, and that looks kind of silly. :-) /Magnus From magnus.ihse.bursie at oracle.com Mon May 14 09:49:50 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Mon, 14 May 2012 11:49:50 +0200 Subject: First build-infra push to jdk8 -- try out the new build system! In-Reply-To: <4F883C57.60004@oracle.com> References: <4F86A4CB.4000908@oracle.com> <4F877CFA.4090704@oracle.com> <4F87ECD3.9070107@oracle.com> <4F883C57.60004@oracle.com> Message-ID: <4FB0D53E.2000303@oracle.com> On 2012-04-13 16:46, Jonathan Gibbons wrote: > On 04/13/2012 02:07 AM, Magnus Ihse Bursie wrote: >> >> As for the --with-num-cores, yes, it is a configure time option. The >> underlying assumption is that your hardware doesn't really change, >> and if your build system is too weak, it will be too weak at >> configure time and at all make times. With that said, it is always >> possible (and not very hard) to re-run configure if you need to tweak >> such a parameter. >> > > As a developer, my machoine may not change, but my expectations may. > Sometimes I want a build to run in the background while I pursue other > activities, whether tetris, browsing, or working on the next bug > fix. Other times, I need the build ASAP. So while your underlying > assumption is good for batch build systems, it may not always be true > on developer machines. We have now implemented the possibitlity to override the default parallelism using the standard make -j option. In short, if you just type "make" you will be using the number of cores detected by (or explicitely configured in) configure, which will make the default build be as fast as possible. If you want to make a slower build but save some CPU power for other processes, you can run e.g. "make -j 2". This will force the makefiles to only run 2 parallel processes, or even "make -j 1" which will disable parallelism. If you want to have it the other way round, namely having slow builds default and override with fast if you're impatient, you should call configure with --with-num-cores=2, making 2 the default. If you want to run with more cores, run "make -j 8" or just "make -j"; the latter will let make determine the maximum number of parallel jobs. This features is currently implemented in the build-infra forest, but it is scheduled for merging into the build forest at the next push. (Webrev coming up soon...) /Magnus From vmikheev at excelsior-usa.com Fri May 11 06:38:42 2012 From: vmikheev at excelsior-usa.com (Vitaly Mikheev) Date: Fri, 11 May 2012 13:38:42 +0700 Subject: 64 bit pointers needed References: <0CADA15E942196438C242C19FA72B4FC046E8796CB@NIHMLBX01.nih.gov> Message-ID: Such a radical change in the language is unlikely feasible. Maybe, resurrection of JSR-83 http://www.jcp.org/en/jsr/detail?id=83 implemented via compiler intrinsics would be a viable option. A motivation why it was rejected ("The proposal requires at least 82 new classes, and this seems inappropriate for the J2SE core...") looks a little bit outdated today. Regards, --Vitaly ------------------------------------------------------------- Vitaly V. Mikheev Tel :+7 (383) 330 55 08 (7AM-3PM GMT) CTO Fax :+1 (509) 271 52 05 Excelsior LLC E-mail :vmikheev at excelsior-usa.com Web: http://www.excelsior-usa.com/ -----Original Message----- From: discuss-bounces at openjdk.java.net [mailto:discuss-bounces at openjdk.java.net] On Behalf Of Senseney, Justin (NIH/CIT) [E] Sent: Friday, May 11, 2012 4:49 AM To: jep-submit at openjdk.java.net Cc: OpenJDK discuss; Gandler,William (NIH/CIT) [E]; build-dev build-dev; compiler-dev at openjdk.java.net Subject: RFE: 64 bit pointers needed Title: RFE: 64 bit pointers needed Author: Justin Senseney Organization: National Institutes of Health Owner: Justin Senseney Created: 2012/04/17 Type: Feature State: Draft Exposure: Open Component: core/lang Scope: JDK JSR: TBD RFE: 4963452 (4850923, 4880587, 4088441, 6292967) Discussion: compiler-dev at openjdk.java.net Start: 2012/Q3 Depends: Blocks: Effort: XL Duration: L Template: 1.0 Internal-refs: Reviewed-by: Endorsed-by: Funded-by: Summary ------- As per the Java Language Specification, section 10.4, all array access in Java is done by using an int as index. Since an int is a signed 32bit value, this limits the total number of addressable elements of an array to 2**31 (about 2 billion). It should be possible to address an array using 64bit values. Goals ----- Improved handling of large datasets that need to be stored in contiguous arrays. Non-Goals --------- Not changing existing range of Integer Success Metrics --------------- Able to compile boolean[] a = new boolean[Long.MAX_VALUE]; Motivation ---------- While having access to 2 billion entries may seem sufficient, there are very compelling performance reasons to be able to use more in a single array. As an example, consider a square n*n matrix, stored as an array (either row or column major, doesn't matter which). Since an array stores at most 2**31 entries, this means that n=sqrt(2**31)=46341, thus the matrix cannot be very large. For multidimensional arrays this is an even more severe limitation (3d Tensors could at most be of size 1290). Description ----------- The scope of this work is extensive, however the solution may be quite technically feasible. Alternatives ------------ A workaround is to use an array of arrays (ie. double[][]). However there is no guarantee that successive rows will be laid of linearly in memory, and therefore performance may be severely penalized. Experimentally, performance may suffer by a factor of over 2, often far greater. Also, most existing matrix packages (ie. LAPACK) assumes linear storage, and are thus incompatible with a double[][] storage (requires double[]). Calling a LAPACK routine with a jagged storage thus requires extra array copying and memory allocation, and can further decrease performance and increase memory requirements. Testing ------- It should be possible to address arrays using 64bit integers (long?), as this provides a seamless transition for users of 64bit computers. Risks and Assumptions --------------------- Use of array of array constructs (use double[][] instead of double[]) possible as workaround. This feature is well implemented in C/C++ without any problem, so should be quite technically feasible to implement. Dependences ----------- None none. Impact ------ My group has requested this feature for several years. It is currently listed as one of the top 25 RFEs on http://bugs.sun.com/top25_rfes.do. Please help Java maintain its relevance by implementing this. I have several image processing applications that are severely limited by this bug, these images cannot be opened in most Java applications. These include electron microscopy and micro-CT images where storage of a single slice requires more entries than allowable in a Java array. Thank you for considering this RFE, Justin Senseney BIRSS/ISL/DCB/CIT/NIH 301-594-5887 301-480-0028 (fax) Building 12A/2015 http://mipav.cit.nih.gov http://dcb.cit.nih.gov/~senseneyj http://image.nih.gov From pierre at pingtimeout.fr Sat May 12 13:52:39 2012 From: pierre at pingtimeout.fr (Pierre Laporte) Date: Sat, 12 May 2012 15:52:39 +0200 Subject: Solaris-only flag with newer gcc = build failed Message-ID: Hi OpenJDK people ! I tried to build the latest version of OpenJDK on my machine, but ran into a problem during the compilation. The error I got was "gcc: error: unrecognized command line option '-mimpure-text'". I am not a C/C++ programmer but I found out that this option is for Solaris only. It is used at line 70 in the file ./jdk/make/common/shared/Compiler-gcc.gmk It seems that the problem is related to gcc v4.7, which is the version I used. I found a JIRA on JRuby where a user had the same problem (see "References" below). I removed that option form the file Compiler-gcc.gmk and the build was successful. Was that the right thing to do or should I expect JVM crashes ? I did not try to build the package using older versions of gcc, so I suppose that previous versions did tolerate the presence of this flag even if it is useful only on Solaris. Can someone confirm this ? Sources : - http://gcc.gnu.org/onlinedocs/gcc/Option-Summary.html - http://jira.codehaus.org/browse/JRUBY-6633 Regards. -- Pierre Laporte pierre at pingtimeout.fr http://www.pingtimeout.fr/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From kelly.ohair at oracle.com Mon May 14 16:50:22 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 14 May 2012 09:50:22 -0700 Subject: First build-infra push to jdk8 -- try out the new build system! In-Reply-To: <4FB0D53E.2000303@oracle.com> References: <4F86A4CB.4000908@oracle.com> <4F877CFA.4090704@oracle.com> <4F87ECD3.9070107@oracle.com> <4F883C57.60004@oracle.com> <4FB0D53E.2000303@oracle.com> Message-ID: On May 14, 2012, at 2:49 AM, Magnus Ihse Bursie wrote: > On 2012-04-13 16:46, Jonathan Gibbons wrote: >> On 04/13/2012 02:07 AM, Magnus Ihse Bursie wrote: >>> >>> As for the --with-num-cores, yes, it is a configure time option. The underlying assumption is that your hardware doesn't really change, and if your build system is too weak, it will be too weak at configure time and at all make times. With that said, it is always possible (and not very hard) to re-run configure if you need to tweak such a parameter. >>> >> >> As a developer, my machoine may not change, but my expectations may. Sometimes I want a build to run in the background while I pursue other activities, whether tetris, browsing, or working on the next bug fix. Other times, I need the build ASAP. So while your underlying assumption is good for batch build systems, it may not always be true on developer machines. > > We have now implemented the possibitlity to override the default parallelism using the standard make -j option. In short, if you just type "make" you will be using the number of cores detected by (or explicitely configured in) configure, which will make the default build be as fast as possible. The only issue I have seen with this involves systems with lots of processors, but not enough disk, or swap, or ram capacity to back up that many C++ compilations at the same time. Historically this 'what's the best make -j N' setting has been difficult with all the different systems out there. I have seen builds go faster with -j 16 than with -j 32 on a 64 processor machine, simply because of the disk contention. To make matters more complicated, the systems are getting faster all around, so many of my measurements of the past don't make much sense. So I would say, use the default until it becomes too painful to use it (the system starts to lockup), then back it down to a comfortable setting. In other words, you may need to play with it on some systems. -kto > > If you want to make a slower build but save some CPU power for other processes, you can run e.g. "make -j 2". This will force the makefiles to only run 2 parallel processes, or even "make -j 1" which will disable parallelism. > > If you want to have it the other way round, namely having slow builds default and override with fast if you're impatient, you should call configure with --with-num-cores=2, making 2 the default. If you want to run with more cores, run "make -j 8" or just "make -j"; the latter will let make determine the maximum number of parallel jobs. > > This features is currently implemented in the build-infra forest, but it is scheduled for merging into the build forest at the next push. (Webrev coming up soon...) > > /Magnus > From david.holmes at oracle.com Tue May 15 02:35:38 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 15 May 2012 12:35:38 +1000 Subject: Solaris-only flag with newer gcc = build failed In-Reply-To: References: Message-ID: <4FB1C0FA.3090100@oracle.com> Hi Pierre, Only just saw your email turn up on the list! This is bug 7150392 and was fixed about 6 weeks ago. From the eval: This option is causing some confusion as it was listed as a GCC sparc option and so we had concerns about its need on linux-sparc, but then it was changed to a Solaris2 option in 2010: http://gcc.gnu.org/onlinedocs/gcc/Solaris-2-Options.html#index-mimpure_002dtext-2103 http://old.nabble.com/Correctly-document-Solaris-2-options-td29851048.html So it's applicability to linux-sparc is unclear. As we only used this option for linux builds and not Solaris builds I find this even more confusing! --- Cheers, David Holmes On 12/05/2012 11:52 PM, Pierre Laporte wrote: > Hi OpenJDK people ! > > I tried to build the latest version of OpenJDK on my machine, but ran > into a problem during the compilation. > The error I got was "gcc: error: unrecognized command line option > '-mimpure-text'". > > I am not a C/C++ programmer but I found out that this option is for > Solaris only. It is used at line 70 in the > file ./jdk/make/common/shared/Compiler-gcc.gmk > It seems that the problem is related to gcc v4.7, which is the version I > used. I found a JIRA on JRuby where a user had the same problem (see > "References" below). > > I removed that option form the file Compiler-gcc.gmk and the build > was successful. Was that the right thing to do or should I expect JVM > crashes ? > > I did not try to build the package using older versions of gcc, so I > suppose that previous versions did tolerate the presence of this flag > even if it is useful only on Solaris. Can someone confirm this ? > > Sources : > - http://gcc.gnu.org/onlinedocs/gcc/Option-Summary.html > - http://jira.codehaus.org/browse/JRUBY-6633 > > Regards. > > -- > > Pierre Laporte > pierre at pingtimeout.fr > http://www.pingtimeout.fr/ From magnus.ihse.bursie at oracle.com Tue May 15 11:34:01 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 15 May 2012 13:34:01 +0200 Subject: Fwd: Request for Review: Make the Queens test ("test in build") an option that can be disabled In-Reply-To: <4FB10306.3090206@oracle.com> References: <4FB10306.3090206@oracle.com> Message-ID: <4FB23F29.8050906@oracle.com> An HTML attachment was scrubbed... URL: From martijnverburg at gmail.com Tue May 15 13:11:54 2012 From: martijnverburg at gmail.com (Martijn Verburg) Date: Tue, 15 May 2012 14:11:54 +0100 Subject: Build error on jdk8/tl project - Thread.o:(.data.rel+0xbc): undefined reference to JVM_SetNativeThreadName In-Reply-To: <4F6FC58C.3000902@oracle.com> References: <4F6B48FB.5090602@oracle.com> <4F6C153A.1050001@oracle.com> <4F6C4C3B.8080508@oracle.com> <4F6F0B82.8090509@oracle.com> <4F6FC58C.3000902@oracle.com> Message-ID: Hi all, Cheers, Martijn > > >> >> >> The 2nd option would be the most up to date I guess but seems a bit >> chicken and egg.. > > I normally use the latest jdk8 binary, but as I said above, sometimes it > still fails. In this case, do a full build and save the j2sdk-image > directory somewhere as later ALT_IMPORT_JDK_PATH. There is no chicken and > egg problem here, you use the full build output as IMPORT of a jdk-only > build, and full build does not need an IMPORT at all, and either a full > build or a jdk-only build depends on a previous veriosn of JDK as BOOTDIR. > > Please note there is a bug in our build script that if you already have > tl/build/{platform} existing, a jdk/make build might fail (at some point in > smartcard or security, random). Please rename (or move) the > tl/build/{platform} directory before starting a jdk-only build. I've been continuing the work to execute a full build followed by a partial build. However, I think I'm still blocked by an issue. Full Build: ---------------- I set the following env vars export LANG=C export ALT_BOOTDIR=/usr/lib/jvm/java-7-openjdk-amd64 I execute a full build of the cloned code base from http://hg.openjdk.java.net/jdk8/tl (after get_sources.sh is run) and that all works fine Partial Build: ---------------- # Create a backup of the full build (as per Weijun's recommendation) cp -R /home/openjdk/projects/jdk8_tl/build/linux-amd64 /home/openjdk/projects/jdk8_tl/build/linux-amd64_backup # Set the ALT_JDK_IMPORT_PATH to point to the j2sk-image backup of the full build export ALT_JDK_IMPORT_PATH=/home/openjdk/projects/jdk8_tl/build/linux-amd64_backup/j2sdk-image # Run the warnings build make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000" &> build.log It builds up to a point, but then has the problem where it's looking for due to directory structure issues (it's looking too far back up the directory tree basically). -------------------- /bin/mkdir -p ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned rm -f ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar /usr/lib/jvm/java-7-openjdk-amd64/bin/jar cf ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar -C ../../../../build/linux-amd64/tmp/sun/sun.security.ec/classes sun/security/ec \ -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m ../../../../build/linux-amd64/tmp/sun/sun.security.ec/classes/sun/security/ec : no such file or directory make[3]: *** [../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar] Error 1 make[3]: Leaving directory `/home/openjdk/projects/jdk8_tl/jdk/make/sun/security/ec' make[2]: *** [all] Error 1 make[2]: Leaving directory `/home/openjdk/projects/jdk8_tl/jdk/make/sun/security' make[1]: *** [all] Error 1 make[1]: Leaving directory `/home/openjdk/projects/jdk8_tl/jdk/make/sun' make: *** [all] Error 1 -------------- Apart from ALT_JDK_IMPORT_PATH are there any other env vars I need to set in order to have a partial build run (using the full build as a base)? Cheers, Martijn From sean.coffey at oracle.com Tue May 15 13:41:48 2012 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 15 May 2012 14:41:48 +0100 Subject: Build error on jdk8/tl project - Thread.o:(.data.rel+0xbc): undefined reference to JVM_SetNativeThreadName In-Reply-To: References: <4F6B48FB.5090602@oracle.com> <4F6C153A.1050001@oracle.com> <4F6C4C3B.8080508@oracle.com> <4F6F0B82.8090509@oracle.com> <4F6FC58C.3000902@oracle.com> Message-ID: <4FB25D1C.4080902@oracle.com> Martijn, there's a pretty annoying build bug around the security build area that I think you've hit. I haven't had time to look into it in detail yet. I think Max's suggestion is to *move* the top level build directory to a new name (not copy it). Basically a jdk8_tl/build/linux-amd64 and jdk8_tl/jdk/build/linux-amd64 structure don't co-exist well together. regards, Sean. On 15/05/2012 14:11, Martijn Verburg wrote: > Hi all, > > > Cheers, > Martijn > >> >> >>> >>> >>> The 2nd option would be the most up to date I guess but seems a bit >>> chicken and egg.. >> I normally use the latest jdk8 binary, but as I said above, sometimes it >> still fails. In this case, do a full build and save the j2sdk-image >> directory somewhere as later ALT_IMPORT_JDK_PATH. There is no chicken and >> egg problem here, you use the full build output as IMPORT of a jdk-only >> build, and full build does not need an IMPORT at all, and either a full >> build or a jdk-only build depends on a previous veriosn of JDK as BOOTDIR. >> >> Please note there is a bug in our build script that if you already have >> tl/build/{platform} existing, a jdk/make build might fail (at some point in >> smartcard or security, random). Please rename (or move) the >> tl/build/{platform} directory before starting a jdk-only build. > I've been continuing the work to execute a full build followed by a > partial build. However, I think I'm still blocked by an obvious missing env VAR> issue. > > Full Build: > ---------------- > I set the following env vars > > export LANG=C > export ALT_BOOTDIR=/usr/lib/jvm/java-7-openjdk-amd64 > > I execute a full build of the cloned code base from > http://hg.openjdk.java.net/jdk8/tl (after get_sources.sh is run) and > that all works fine > > Partial Build: > ---------------- > > # Create a backup of the full build (as per Weijun's recommendation) > cp -R /home/openjdk/projects/jdk8_tl/build/linux-amd64 > /home/openjdk/projects/jdk8_tl/build/linux-amd64_backup > > # Set the ALT_JDK_IMPORT_PATH to point to the j2sk-image backup of the > full build > export ALT_JDK_IMPORT_PATH=/home/openjdk/projects/jdk8_tl/build/linux-amd64_backup/j2sdk-image > > # Run the warnings build > make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= > OTHER_JAVACFLAGS="-Xmaxwarns 10000"&> build.log > > It builds up to a point, but then has the problem where it's looking > for due to directory structure issues (it's looking too far back up > the directory tree basically). > > -------------------- > > /bin/mkdir -p ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned > rm -f ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar > /usr/lib/jvm/java-7-openjdk-amd64/bin/jar cf > ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar > -C ../../../../build/linux-amd64/tmp/sun/sun.security.ec/classes > sun/security/ec \ > -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions > -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m > -J-XX:MaxPermSize=160m > ../../../../build/linux-amd64/tmp/sun/sun.security.ec/classes/sun/security/ec > : no such file or directory > make[3]: *** [../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar] > Error 1 > make[3]: Leaving directory > `/home/openjdk/projects/jdk8_tl/jdk/make/sun/security/ec' > make[2]: *** [all] Error 1 > make[2]: Leaving directory > `/home/openjdk/projects/jdk8_tl/jdk/make/sun/security' > make[1]: *** [all] Error 1 > make[1]: Leaving directory `/home/openjdk/projects/jdk8_tl/jdk/make/sun' > make: *** [all] Error 1 > > -------------- > > Apart from ALT_JDK_IMPORT_PATH are there any other env vars I need to > set in order to have a partial build run (using the full build as a > base)? > > Cheers, > Martijn From weijun.wang at oracle.com Tue May 15 14:33:24 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Tue, 15 May 2012 22:33:24 +0800 Subject: Build error on jdk8/tl project - Thread.o:(.data.rel+0xbc): undefined reference to JVM_SetNativeThreadName In-Reply-To: References: <4F6B48FB.5090602@oracle.com> <4F6C153A.1050001@oracle.com> <4F6C4C3B.8080508@oracle.com> <4F6F0B82.8090509@oracle.com> <4F6FC58C.3000902@oracle.com> Message-ID: <4FB26934.1050706@oracle.com> This looks like the bug I mentioned. You should move the jdk8_tl/build/linux-amd64 directory to somewhere else. -Weijun On 05/15/2012 09:11 PM, Martijn Verburg wrote: > Hi all, > > > Cheers, > Martijn > >> >> >>> >>> >>> The 2nd option would be the most up to date I guess but seems a bit >>> chicken and egg.. >> >> I normally use the latest jdk8 binary, but as I said above, sometimes it >> still fails. In this case, do a full build and save the j2sdk-image >> directory somewhere as later ALT_IMPORT_JDK_PATH. There is no chicken and >> egg problem here, you use the full build output as IMPORT of a jdk-only >> build, and full build does not need an IMPORT at all, and either a full >> build or a jdk-only build depends on a previous veriosn of JDK as BOOTDIR. >> >> Please note there is a bug in our build script that if you already have >> tl/build/{platform} existing, a jdk/make build might fail (at some point in >> smartcard or security, random). Please rename (or move) the >> tl/build/{platform} directory before starting a jdk-only build. > > I've been continuing the work to execute a full build followed by a > partial build. However, I think I'm still blocked by an obvious missing env VAR> issue. > > Full Build: > ---------------- > I set the following env vars > > export LANG=C > export ALT_BOOTDIR=/usr/lib/jvm/java-7-openjdk-amd64 > > I execute a full build of the cloned code base from > http://hg.openjdk.java.net/jdk8/tl (after get_sources.sh is run) and > that all works fine > > Partial Build: > ---------------- > > # Create a backup of the full build (as per Weijun's recommendation) > cp -R /home/openjdk/projects/jdk8_tl/build/linux-amd64 > /home/openjdk/projects/jdk8_tl/build/linux-amd64_backup > > # Set the ALT_JDK_IMPORT_PATH to point to the j2sk-image backup of the > full build > export ALT_JDK_IMPORT_PATH=/home/openjdk/projects/jdk8_tl/build/linux-amd64_backup/j2sdk-image > > # Run the warnings build > make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= > OTHER_JAVACFLAGS="-Xmaxwarns 10000"&> build.log > > It builds up to a point, but then has the problem where it's looking > for due to directory structure issues (it's looking too far back up > the directory tree basically). > > -------------------- > > /bin/mkdir -p ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned > rm -f ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar > /usr/lib/jvm/java-7-openjdk-amd64/bin/jar cf > ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar > -C ../../../../build/linux-amd64/tmp/sun/sun.security.ec/classes > sun/security/ec \ > -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions > -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m > -J-XX:MaxPermSize=160m > ../../../../build/linux-amd64/tmp/sun/sun.security.ec/classes/sun/security/ec > : no such file or directory > make[3]: *** [../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar] > Error 1 > make[3]: Leaving directory > `/home/openjdk/projects/jdk8_tl/jdk/make/sun/security/ec' > make[2]: *** [all] Error 1 > make[2]: Leaving directory > `/home/openjdk/projects/jdk8_tl/jdk/make/sun/security' > make[1]: *** [all] Error 1 > make[1]: Leaving directory `/home/openjdk/projects/jdk8_tl/jdk/make/sun' > make: *** [all] Error 1 > > -------------- > > Apart from ALT_JDK_IMPORT_PATH are there any other env vars I need to > set in order to have a partial build run (using the full build as a > base)? > > Cheers, > Martijn From jonathan.gibbons at oracle.com Tue May 15 14:39:46 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 15 May 2012 07:39:46 -0700 Subject: Fwd: Request for Review: Make the Queens test ("test in build") an option that can be disabled In-Reply-To: <4FB23F29.8050906@oracle.com> References: <4FB10306.3090206@oracle.com> <4FB23F29.8050906@oracle.com> Message-ID: <4FB26AB2.4030601@oracle.com> I think it would be good to see a more general proposal for how to handle tests in this new world, and then to see this Queens test be a part of that design. -- Jon On 05/15/2012 04:34 AM, Magnus Ihse Bursie wrote: > I should probably have posted this here as well... > > There is a newer webrev than the one below at: > http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.01/ > > This adds: > * Skip building test_gamma if TEST_IN_BUILD is not enabled > * If cross-compiling, set TEST_IN_BUILD to false instead of making an > early exit in test_gamma. > > /Magnus > > -------- Original Message -------- > Subject: Request for Review: Make the Queens test ("test in build") > an option that can be disabled > Date: Mon, 14 May 2012 15:05:10 +0200 > From: Magnus Ihse Bursie > To: hotspot-dev at openjdk.java.net > > > > As part of the new build system created in the build-infra project, we > want to make it a configurable option wether or not to run the Queens > test as part of the build. > > Here is a patch that introduces a new make variable, TEST_IN_BUILD, > which controls wether to run the Queens test (test_gamma.sh) or not. If > the variable is not explicitely set, it will default to true, mening > that the default behaviour will be as before, that is, to run the Queens > test. However, if you (or configure) explicitely set it to false, the > Queens test will be skipped. > > http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.00 > > /Magnus > -------------- next part -------------- An HTML attachment was scrubbed... URL: From martijnverburg at gmail.com Tue May 15 17:03:12 2012 From: martijnverburg at gmail.com (Martijn Verburg) Date: Tue, 15 May 2012 18:03:12 +0100 Subject: Build error on jdk8/tl project - Thread.o:(.data.rel+0xbc): undefined reference to JVM_SetNativeThreadName In-Reply-To: <4FB26934.1050706@oracle.com> References: <4F6B48FB.5090602@oracle.com> <4F6C153A.1050001@oracle.com> <4F6C4C3B.8080508@oracle.com> <4F6F0B82.8090509@oracle.com> <4F6FC58C.3000902@oracle.com> <4FB26934.1050706@oracle.com> Message-ID: Hi all, Well what do poor Weijun and Sean get for posting useful instructions back in March? They get me not reading them carefully enough! Partial build now works as expected. Thanks for your patience guys, I really need to RTM more closely in future! Cheers, Martijn On 15 May 2012 15:33, Weijun Wang wrote: > This looks like the bug I mentioned. You should move the > jdk8_tl/build/linux-amd64 directory to somewhere else. > > -Weijun > > > On 05/15/2012 09:11 PM, Martijn Verburg wrote: >> >> Hi all, >> >> >> Cheers, >> Martijn >> >>> >>> >>>> >>>> >>>> The 2nd option would be the most up to date I guess but seems a bit >>>> chicken and egg.. >>> >>> >>> I normally use the latest jdk8 binary, but as I said above, sometimes it >>> still fails. In this case, do a full build and save the j2sdk-image >>> directory somewhere as later ALT_IMPORT_JDK_PATH. There is no chicken and >>> egg problem here, you use the full build output as IMPORT of a jdk-only >>> build, and full build does not need an IMPORT at all, and either a full >>> build or a jdk-only build depends on a previous veriosn of JDK as >>> BOOTDIR. >>> >>> Please note there is a bug in our build script that if you already have >>> tl/build/{platform} existing, a jdk/make build might fail (at some point >>> in >>> smartcard or security, random). Please rename (or move) the >>> tl/build/{platform} directory before starting a jdk-only build. >> >> >> I've been continuing the work to execute a full build followed by a >> partial build. However, I think I'm still blocked by an> obvious missing env VAR> ?issue. >> >> Full Build: >> ---------------- >> I set the following env vars >> >> export LANG=C >> export ALT_BOOTDIR=/usr/lib/jvm/java-7-openjdk-amd64 >> >> I execute a full build of the cloned code base from >> http://hg.openjdk.java.net/jdk8/tl (after get_sources.sh is run) and >> that all works fine >> >> Partial Build: >> ---------------- >> >> # Create a backup of the full build (as per Weijun's recommendation) >> cp -R /home/openjdk/projects/jdk8_tl/build/linux-amd64 >> /home/openjdk/projects/jdk8_tl/build/linux-amd64_backup >> >> # Set the ALT_JDK_IMPORT_PATH to point to the j2sk-image backup of the >> full build >> export >> ALT_JDK_IMPORT_PATH=/home/openjdk/projects/jdk8_tl/build/linux-amd64_backup/j2sdk-image >> >> # Run the warnings build >> make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= >> OTHER_JAVACFLAGS="-Xmaxwarns 10000"&> ?build.log >> >> It builds up to a point, but then has the problem where it's looking >> for due to directory structure issues (it's looking too far back up >> the directory tree basically). >> >> -------------------- >> >> /bin/mkdir -p >> ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned >> rm -f >> ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar >> /usr/lib/jvm/java-7-openjdk-amd64/bin/jar cf >> ../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar >> ?-C ../../../../build/linux-amd64/tmp/sun/sun.security.ec/classes >> sun/security/ec \ >> ? ? ? ? ? ? -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions >> -J-XX:-LogVMOutput -J-Xmx512m -J-Xms512m -J-XX:PermSize=32m >> -J-XX:MaxPermSize=160m >> >> ../../../../build/linux-amd64/tmp/sun/sun.security.ec/classes/sun/security/ec >> : no such file or directory >> make[3]: *** >> [../../../../build/linux-amd64/tmp/sun/sun.security.ec/unsigned/sunec.jar] >> Error 1 >> make[3]: Leaving directory >> `/home/openjdk/projects/jdk8_tl/jdk/make/sun/security/ec' >> make[2]: *** [all] Error 1 >> make[2]: Leaving directory >> `/home/openjdk/projects/jdk8_tl/jdk/make/sun/security' >> make[1]: *** [all] Error 1 >> make[1]: Leaving directory `/home/openjdk/projects/jdk8_tl/jdk/make/sun' >> make: *** [all] Error 1 >> >> -------------- >> >> Apart from ALT_JDK_IMPORT_PATH are there any other env vars I need to >> set in order to have a partial build run (using the full build as a >> base)? >> >> Cheers, >> Martijn From michael.fang at oracle.com Tue May 15 19:02:11 2012 From: michael.fang at oracle.com (michael.fang at oracle.com) Date: Tue, 15 May 2012 19:02:11 +0000 Subject: hg: jdk8/build/jdk: 7157855: jvisualvm.1 not included in binaries Message-ID: <20120515190223.4521547324@hg.openjdk.java.net> Changeset: 8d665b69ebf1 Author: mfang Date: 2012-05-15 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8d665b69ebf1 7157855: jvisualvm.1 not included in binaries Reviewed-by: katleman, thurka ! make/common/Release.gmk From pierre at pingtimeout.fr Tue May 15 21:42:45 2012 From: pierre at pingtimeout.fr (Pierre Laporte) Date: Tue, 15 May 2012 23:42:45 +0200 Subject: Solaris-only flag with newer gcc = build failed In-Reply-To: <4FB1C0FA.3090100@oracle.com> References: <4FB1C0FA.3090100@oracle.com> Message-ID: On Tue, May 15, 2012 at 4:35 AM, David Holmes wrote: > Hi Pierre, > > [...] > > This is bug 7150392 and was fixed about 6 weeks ago. > > Hi David Indeed, it's exactly the same problem as bug #7150392 I've checked several versions of OpenJDK source (jdk7/jdk7, jdk7u/jdk7u, jdk7u/jdk7u4, and jdk8/jdk8), and it seems that the proposed patch has only been applied on jdk8 repo. So this could explain than I ran into this bug after it was corrected. Anyway, thanks for you time ! Regards -- Pierre Laporte pierre at pingtimeout.fr http://www.pingtimeout.fr/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From kelly.ohair at oracle.com Wed May 16 00:38:35 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 15 May 2012 17:38:35 -0700 Subject: Request for Review: Make the Queens test ("test in build") an option that can be disabled In-Reply-To: <4FB26AB2.4030601@oracle.com> References: <4FB10306.3090206@oracle.com> <4FB23F29.8050906@oracle.com> <4FB26AB2.4030601@oracle.com> Message-ID: I agree. Builds are builds, and tests are tests. We need some separation here. -kto On May 15, 2012, at 7:39 AM, Jonathan Gibbons wrote: > I think it would be good to see a more general proposal for how > to handle tests in this new world, and then to see this Queens test > be a part of that design. > > -- Jon > > > On 05/15/2012 04:34 AM, Magnus Ihse Bursie wrote: >> >> I should probably have posted this here as well... >> >> There is a newer webrev than the one below at: >> http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.01/ >> >> This adds: >> * Skip building test_gamma if TEST_IN_BUILD is not enabled >> * If cross-compiling, set TEST_IN_BUILD to false instead of making an early exit in test_gamma. >> >> /Magnus >> >> -------- Original Message -------- >> Subject: Request for Review: Make the Queens test ("test in build") an option that can be disabled >> Date: Mon, 14 May 2012 15:05:10 +0200 >> From: Magnus Ihse Bursie >> To: hotspot-dev at openjdk.java.net >> >> As part of the new build system created in the build-infra project, we >> want to make it a configurable option wether or not to run the Queens >> test as part of the build. >> >> Here is a patch that introduces a new make variable, TEST_IN_BUILD, >> which controls wether to run the Queens test (test_gamma.sh) or not. If >> the variable is not explicitely set, it will default to true, mening >> that the default behaviour will be as before, that is, to run the Queens >> test. However, if you (or configure) explicitely set it to false, the >> Queens test will be skipped. >> >> http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.00 >> >> /Magnus >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.gibbons at oracle.com Wed May 16 00:39:41 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 15 May 2012 17:39:41 -0700 Subject: Request for Review: Make the Queens test ("test in build") an option that can be disabled In-Reply-To: References: <4FB10306.3090206@oracle.com> <4FB23F29.8050906@oracle.com> <4FB26AB2.4030601@oracle.com> Message-ID: <4FB2F74D.7050507@oracle.com> ... but it would be able to go, eventually, "make test" :-) -- Jon On 05/15/2012 05:38 PM, Kelly O'Hair wrote: > I agree. > > Builds are builds, and tests are tests. We need some separation here. > > -kto > > On May 15, 2012, at 7:39 AM, Jonathan Gibbons wrote: > >> I think it would be good to see a more general proposal for how >> to handle tests in this new world, and then to see this Queens test >> be a part of that design. >> >> -- Jon >> >> >> On 05/15/2012 04:34 AM, Magnus Ihse Bursie wrote: >>> I should probably have posted this here as well... >>> >>> There is a newer webrev than the one below at: >>> http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.01/ >>> >>> This adds: >>> * Skip building test_gamma if TEST_IN_BUILD is not enabled >>> * If cross-compiling, set TEST_IN_BUILD to false instead of making >>> an early exit in test_gamma. >>> >>> /Magnus >>> >>> -------- Original Message -------- >>> Subject: Request for Review: Make the Queens test ("test in build") >>> an option that can be disabled >>> Date: Mon, 14 May 2012 15:05:10 +0200 >>> From: Magnus Ihse Bursie >>> To: hotspot-dev at openjdk.java.net >>> >>> >>> >>> As part of the new build system created in the build-infra project, we >>> want to make it a configurable option wether or not to run the Queens >>> test as part of the build. >>> >>> Here is a patch that introduces a new make variable, TEST_IN_BUILD, >>> which controls wether to run the Queens test (test_gamma.sh) or not. If >>> the variable is not explicitely set, it will default to true, mening >>> that the default behaviour will be as before, that is, to run the Queens >>> test. However, if you (or configure) explicitely set it to false, the >>> Queens test will be skipped. >>> >>> http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.00 >>> >>> /Magnus >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From kelly.ohair at oracle.com Wed May 16 00:40:19 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 15 May 2012 17:40:19 -0700 Subject: Request for Review: Make the Queens test ("test in build") an option that can be disabled In-Reply-To: <4FB23F29.8050906@oracle.com> References: <4FB10306.3090206@oracle.com> <4FB23F29.8050906@oracle.com> Message-ID: <89485147-4F8C-4123-B615-C25918EA086C@oracle.com> I'm not sure this will work on Windows. The make/defs.make file needs to be acceptable to NMAKE. :^( -kto On May 15, 2012, at 4:34 AM, Magnus Ihse Bursie wrote: > I should probably have posted this here as well... > > There is a newer webrev than the one below at: > http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.01/ > > This adds: > * Skip building test_gamma if TEST_IN_BUILD is not enabled > * If cross-compiling, set TEST_IN_BUILD to false instead of making an early exit in test_gamma. > > /Magnus > > -------- Original Message -------- > Subject: Request for Review: Make the Queens test ("test in build") an option that can be disabled > Date: Mon, 14 May 2012 15:05:10 +0200 > From: Magnus Ihse Bursie > To: hotspot-dev at openjdk.java.net > > As part of the new build system created in the build-infra project, we > want to make it a configurable option wether or not to run the Queens > test as part of the build. > > Here is a patch that introduces a new make variable, TEST_IN_BUILD, > which controls wether to run the Queens test (test_gamma.sh) or not. If > the variable is not explicitely set, it will default to true, mening > that the default behaviour will be as before, that is, to run the Queens > test. However, if you (or configure) explicitely set it to false, the > Queens test will be skipped. > > http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.00 > > /Magnus > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.holmes at oracle.com Wed May 16 03:07:19 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 16 May 2012 13:07:19 +1000 Subject: Request for Review: Make the Queens test ("test in build") an option that can be disabled In-Reply-To: References: <4FB10306.3090206@oracle.com> <4FB23F29.8050906@oracle.com> <4FB26AB2.4030601@oracle.com> Message-ID: <4FB319E7.4070607@oracle.com> I don't think there is any attempt at a "general proposal" here. This is simply providing a means to disable the existing (mis-placed perhaps) Queens test. In essence our top-level hotspot targets combine: make build_target make test_target into "make target". And if you define INSTALL then "make install_target" also gets added. David ----- On 16/05/2012 10:38 AM, Kelly O'Hair wrote: > I agree. > > Builds are builds, and tests are tests. We need some separation here. > > -kto > > On May 15, 2012, at 7:39 AM, Jonathan Gibbons wrote: > >> I think it would be good to see a more general proposal for how >> to handle tests in this new world, and then to see this Queens test >> be a part of that design. >> >> -- Jon >> >> >> On 05/15/2012 04:34 AM, Magnus Ihse Bursie wrote: >>> I should probably have posted this here as well... >>> >>> There is a newer webrev than the one below at: >>> http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.01/ >>> >>> This adds: >>> * Skip building test_gamma if TEST_IN_BUILD is not enabled >>> * If cross-compiling, set TEST_IN_BUILD to false instead of making an >>> early exit in test_gamma. >>> >>> /Magnus >>> >>> -------- Original Message -------- >>> Subject: Request for Review: Make the Queens test ("test in build") >>> an option that can be disabled >>> Date: Mon, 14 May 2012 15:05:10 +0200 >>> From: Magnus Ihse Bursie >>> To: hotspot-dev at openjdk.java.net >>> >>> >>> >>> As part of the new build system created in the build-infra project, we >>> want to make it a configurable option wether or not to run the Queens >>> test as part of the build. >>> >>> Here is a patch that introduces a new make variable, TEST_IN_BUILD, >>> which controls wether to run the Queens test (test_gamma.sh) or not. If >>> the variable is not explicitely set, it will default to true, mening >>> that the default behaviour will be as before, that is, to run the Queens >>> test. However, if you (or configure) explicitely set it to false, the >>> Queens test will be skipped. >>> >>> http://cr.openjdk.java.net/~ihse/make-test-in-build-an-option/webrev.00 >>> >>> /Magnus >>> >> > From erik.joelsson at oracle.com Wed May 16 12:32:03 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 16 May 2012 14:32:03 +0200 Subject: Review Request: Build-infra update Message-ID: <4FB39E43.6080909@oracle.com> The build-infra project has been quite productive and would like to push an update to the new build in jdk8. All webrevs can be found here: http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ What's new in this push? * Makefile conversion is basically done (a few minor exceptions but all code is compiled by new makefiles now). * Solaris ia32 is now as binary compatible with the old build as linux is. * Build speed is significantly improved since only new makefiles are used. (Rough examples for full open build: Linux 7min, Solaris ia32 7min, Windows 22min) * Windows still builds and is runnable. * Several bugfixes. Why push now, it's not all done yet? The main driver for this push is the jigsaw project that needs to consume the full conversion of the makefiles in order to work on the jigsaw build. We also think that people trying out the new build will enjoy the speed improvement. Of course we also welcome more feedback on the new build system. /Erik From Alan.Bateman at oracle.com Wed May 16 12:49:31 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 16 May 2012 13:49:31 +0100 Subject: Review Request: Build-infra update In-Reply-To: <4FB39E43.6080909@oracle.com> References: <4FB39E43.6080909@oracle.com> Message-ID: <4FB3A25B.8000408@oracle.com> On 16/05/2012 13:32, Erik Joelsson wrote: > The build-infra project has been quite productive and would like to > push an update to the new build in jdk8. > > All webrevs can be found here: > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ > > > What's new in this push? > * Makefile conversion is basically done (a few minor exceptions but > all code is compiled by new makefiles now). > * Solaris ia32 is now as binary compatible with the old build as linux > is. > * Build speed is significantly improved since only new makefiles are > used. (Rough examples for full open build: Linux 7min, Solaris ia32 > 7min, Windows 22min) > * Windows still builds and is runnable. > * Several bugfixes. > > Why push now, it's not all done yet? > The main driver for this push is the jigsaw project that needs to > consume the full conversion of the makefiles in order to work on the > jigsaw build. We also think that people trying out the new build will > enjoy the speed improvement. Of course we also welcome more feedback > on the new build system. > > /Erik One thing about the update is that it adds a compile time dependency on javax.tools.annotation.GenerateNativeHeader to many areas. I think this requires consideration from a modularity perspective. -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: From oehrstroem at gmail.com Wed May 16 21:21:32 2012 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Wed, 16 May 2012 23:21:32 +0200 Subject: Review Request: Build-infra update In-Reply-To: <4FB39E43.6080909@oracle.com> References: <4FB39E43.6080909@oracle.com> Message-ID: In configure.ac: Indententation looks odd where solaris optimizations settings for CC are calculated. Could someone enlighten this configure script with a comment about libCrun? In logger.sh: trap "rm -rf '$RCDIR'" EXIT The $RCDIR is not replaced with the contents of the variable RCDIR since it is surrounded by single quotes. I assume the single quotes were added to deal with paths with spaces in them on windows. Perhaps there is some clever way to solve this. Somewhat broken comment in JavaCompilation.gmk: 178 # When this macro is run in the same makefile as the java compilation, dependencies are transfered 179 # in make variables. When the macro is run in a different makefile than the java compilation, the 180 # needs to be found in the filesystem. In the root makefile, could you explain what CONF does and what the source tip code does? In the corba makefile, it seems like we forgot to use $(MKDIR) for mkdir and several other commands. In CompileJavaClasses.gmk: 88 # Jonas 2012-04-25: It's only used to generate...i.e a build tool Then it should still be excluded from the jdk build, even on Macosx, should it not? 128 ifeq ($(JONAS),TODO_DONE) 277 # List of java classes that should be javah compiled, but is not auto-detected 278 BUILD_JDK_EXTRA_NATIVE := java.net.InetAddressImplFactory Is this because we have not had time to add GenerateNativeHeader for this class? In NativeCompilation.gmk: 91 # as this is firt time I see it Is the source so messed up that we need BUILD_LIBMLIB_IMAGE_V_FILES and BUILD_LIBINSTRUMENT_FILES, BUILD_LIBNIO_FILES, LIBAWT_XAWT_FILES, LIBAWT_HEADLESS_FILES, LIBAWT_XAWT_FILES, LIBSPLASHSCREEN_FILES, LIBAWT_FILES, LIBJSOUND_MIDIFILES, LIBJSOUND_PORTFILES, LIBJSOUND_DAUDIOFILES, LIBAPPLESCRIPTENGINE_FILES, LIBAWT_LWAWT_FILES, LIBOSXUI_FILES? Unfortunately, I can guess that the answer is yes. However everyone should now that each time an explicit source file name is added to a makefile, a kitten dies! Can we rename newobjs into objs? The names newobjs and newclasses were only used while we converted the makefiles. In CopyFiles.gmk: # TODO: Platform dir needs to be "win32" on windows /erikj Fixed isn't it? In GenerateClasses.gmk: 33 # Depend on files in classes for now to avoid bad dependency handling caused by 34 # copy always updating timestamps in classes. 35 NEWCLASSES_DIR := $(JDK_OUTPUTDIR)/classes Drop the comment, and drop NEWCLASSES_DIR, just do CLASSES_DIR:=$(JDK_OUTPUTDIR)/classes in the macro call. In GenerateJavaSources.gmk: Use $(CHMOD) instead of chmod etc etc In GensrcMisc.gmk: Why is realpath needed here? 172 SRC:=$(realpath $(dir $(GENSRC_SOL_SRC) In GensrcCharacterData.gmk: replace echo with $(ECHO) In Images.gmk: You can remove the comments from line 35 to 44. Though the incantation: I.e. -do-not-use- :: rules!!!!! Repeat after me: -do-not-use- :: rules!!!!! Should be recited 100 times by anyone who wants to edit the new makefiles. :-) Are makefiles/com/Makefile and makefiles/javax/Makefile empty? Can they be removed? Awesome work! //Fredrik 2012/5/16 Erik Joelsson : > The build-infra project has been quite productive and would like to push an > update to the new build in jdk8. > > All webrevs can be found here: > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ > > > What's new in this push? > * Makefile conversion is basically done (a few minor exceptions but all code > is compiled by new makefiles now). > * Solaris ia32 is now as binary compatible with the old build as linux is. > * Build speed is significantly improved since only new makefiles are used. > (Rough examples for full open build: Linux 7min, Solaris ia32 7min, Windows > 22min) > * Windows still builds and is runnable. > * Several bugfixes. > > Why push now, it's not all done yet? > The main driver for this push is the jigsaw project that needs to consume > the full conversion of the makefiles in order to work on the jigsaw build. > We also think that people trying out the new build will enjoy the speed > improvement. Of course we also welcome more feedback on the new build > system. > > /Erik From david.katleman at oracle.com Thu May 17 05:13:05 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 05:13:05 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20120517051305.902C347370@hg.openjdk.java.net> Changeset: b67bdaca36c2 Author: katleman Date: 2012-05-10 10:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/b67bdaca36c2 Added tag jdk8-b38 for changeset d939bd0ab13c ! .hgtags Changeset: 8927dd68aee3 Author: katleman Date: 2012-05-16 22:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/8927dd68aee3 Merge From david.katleman at oracle.com Thu May 17 05:13:10 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 05:13:10 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b38 for changeset b8cbfb31139f Message-ID: <20120517051311.6732A47371@hg.openjdk.java.net> Changeset: 785af00e2827 Author: katleman Date: 2012-05-10 10:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/785af00e2827 Added tag jdk8-b38 for changeset b8cbfb31139f ! .hgtags From david.katleman at oracle.com Thu May 17 05:14:59 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 05:14:59 +0000 Subject: hg: jdk8/build/hotspot: 17 new changesets Message-ID: <20120517051534.B097147372@hg.openjdk.java.net> Changeset: 3c394919ca69 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3c394919ca69 Added tag jdk8-b38 for changeset 637c3f5f068f ! .hgtags Changeset: 36538fd1225e Author: amurillo Date: 2012-05-04 15:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/36538fd1225e 7166615: new hotspot build - hs24-b10 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8bafad97cd26 Author: jiangli Date: 2012-05-02 13:21 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8bafad97cd26 7158552: The instanceKlsss::_host_klass is only needed for anonymous class for JSR 292 support. Summary: Change the _host_klass to be conditionally created embedded instanceKlass field. Reviewed-by: jrose, coleenp, dholmes ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceKlassKlass.hpp Changeset: 38b4116b6766 Author: jprovino Date: 2012-05-05 10:24 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/38b4116b6766 Merge Changeset: c7ed11779ce8 Author: jiangli Date: 2012-04-10 09:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c7ed11779ce8 7159772: instanceKlass::all_fields_count() returns incorrect total field count Summary: Fix instanceKlass::all_fields_count() bug. Reviewed-by: kvn, never Contributed-by: Jiangli Zhou ! src/share/vm/oops/instanceKlass.hpp Changeset: 3576af4cb939 Author: iveresov Date: 2012-04-11 19:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3576af4cb939 7160539: JDeveloper crashes on 64-bit Windows Summary: x64 C1 needs to zero upper 32bits when doing l2i conversion Reviewed-by: never, kvn ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 847da049d62f Author: never Date: 2012-04-17 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/847da049d62f 7162094: LateInlineCallGenerator::do_late_inline crashed on uninitialized _call_node Reviewed-by: never, twisti Contributed-by: nils.eliasson at oracle.com ! src/share/vm/opto/callGenerator.cpp Changeset: df3d4a91f7f6 Author: never Date: 2012-04-18 16:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/df3d4a91f7f6 7161796: PhaseStringOpts::fetch_static_field tries to fetch field from the Klass instead of the mirror Reviewed-by: twisti ! src/share/vm/opto/stringopts.cpp Changeset: ec15e8f6e4f1 Author: twisti Date: 2012-04-24 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ec15e8f6e4f1 7157695: Add windows implementation of socket interface Reviewed-by: kvn, dholmes, twisti Contributed-by: Nils Eliasson ! src/os/windows/vm/jvm_windows.h ! src/os/windows/vm/os_windows.cpp Changeset: dc682d9431f3 Author: kvn Date: 2012-05-07 12:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dc682d9431f3 7160610: Unknown Native Code compilation issue Summary: When constructing input vector use type of vector's operation which use it since element's sizes should match. Reviewed-by: never, twisti ! src/share/vm/opto/superword.cpp + test/compiler/7160610/Test7160610.java Changeset: 3a97daec1b34 Author: kvn Date: 2012-05-08 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3a97daec1b34 7167266: missing copyright notes in 3rd party code Summary: add missing copyright notes to the regression test file. Reviewed-by: twisti, johnc ! test/compiler/7070134/Stemmer.java Changeset: 2766551175a0 Author: kvn Date: 2012-05-09 10:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2766551175a0 Merge ! src/share/vm/oops/instanceKlass.hpp Changeset: a05a695ea044 Author: stefank Date: 2012-05-10 11:27 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a05a695ea044 7167437: Can't build on linux without precompiled headers Reviewed-by: brutisso, mgerdin ! src/share/vm/memory/space.hpp ! src/share/vm/memory/space.inline.hpp Changeset: f47478089efc Author: brutisso Date: 2012-05-10 14:16 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f47478089efc 7167069: 6 VM flags crash the VM when queried via jinfo Summary: Added missing double format to Flag::print_as_flag() Reviewed-by: dholmes, stefank, coleenp ! src/share/vm/runtime/globals.cpp + test/runtime/7167069/PrintAsFlag.java Changeset: 5799726c54d7 Author: jcoomes Date: 2012-05-11 06:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5799726c54d7 Merge Changeset: 73147e6c4881 Author: amurillo Date: 2012-05-11 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/73147e6c4881 Merge Changeset: 96a403721094 Author: amurillo Date: 2012-05-11 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/96a403721094 Added tag hs24-b10 for changeset 73147e6c4881 ! .hgtags From david.katleman at oracle.com Thu May 17 05:17:00 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 05:17:00 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b38 for changeset 5bbe0cb6f2f2 Message-ID: <20120517051703.CBA4847373@hg.openjdk.java.net> Changeset: f95fdbe525c8 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/f95fdbe525c8 Added tag jdk8-b38 for changeset 5bbe0cb6f2f2 ! .hgtags From david.katleman at oracle.com Thu May 17 05:17:09 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 05:17:09 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b38 for changeset ac1ba3b56775 Message-ID: <20120517051712.D4A1447374@hg.openjdk.java.net> Changeset: 7f6b44fd3034 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/7f6b44fd3034 Added tag jdk8-b38 for changeset ac1ba3b56775 ! .hgtags From david.katleman at oracle.com Thu May 17 05:17:21 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 05:17:21 +0000 Subject: hg: jdk8/build/jdk: 2 new changesets Message-ID: <20120517051749.7587B47375@hg.openjdk.java.net> Changeset: b5726775b0d8 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b5726775b0d8 Added tag jdk8-b38 for changeset c45f3509a707 ! .hgtags Changeset: b6f529117521 Author: katleman Date: 2012-05-16 22:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b6f529117521 Merge From david.katleman at oracle.com Thu May 17 05:19:01 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 17 May 2012 05:19:01 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b38 for changeset 1f224f160aa8 Message-ID: <20120517051905.3218447376@hg.openjdk.java.net> Changeset: a9f547c218d9 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/a9f547c218d9 Added tag jdk8-b38 for changeset 1f224f160aa8 ! .hgtags From daniel.daugherty at oracle.com Thu May 17 14:14:22 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 17 May 2012 08:14:22 -0600 Subject: code review request for FDS/aurora bug fix (7168520) Message-ID: <4FB507BE.3030107@oracle.com> Greetings, This is a code review request for the following P1 bug: 7168520 1/3 No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 Here is the URL for the webrev: http://cr.openjdk.java.net/~dcubed/fds_revamp/7168520-webrev/0/ This fix has already been reviewed internally and is in the process of being pushed to the JDK8 T&L repo. Since the bug impacts our internal aurora tool, we're moving very quickly on this issue. If this code review request generates any additional changes, then we'll use another bug ID to make those changes. Gory details below... In the original FDS implementation, per-VM libjsig.debuginfo symlinks were created that refer to ../libjsig.debuginfo. When the ZIP_DEBUGINFO_FILES feature is enabled (the default), the jre/lib//libjsig.debuginfo files are ZIPed into jre/lib//libjsig.diz. This makes the per-VM libjsig.debuginfo symlinks "dangling" because the ../libjsig.debuginfo files are ZIP'ed. Aurora doesn't tolerate dangling symlinks so this fix puts a work around in place. The work around ZIPs the per-VM libjsig.debuginfo symlinks into a per-VM libjsig.diz file. Aurora has no problem with ZIP files. After the work around is in place, the default libjsig.diz layout is: jre/lib//libjsig.diz - ZIP'ed real libjsig.debuginfo jre/lib//client/libjsig.diz - ZIP'ed symlink (libjsig.debuginfo -> ../libjsig.debuginfo) jre/lib//server/libjsig.diz - ZIP'ed symlink (libjsig.debuginfo -> ../libjsig.debuginfo) Dan From karen.kinnear at oracle.com Thu May 17 14:24:56 2012 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 17 May 2012 10:24:56 -0400 Subject: code review request for FDS/aurora bug fix (7168520) In-Reply-To: <4FB507BE.3030107@oracle.com> References: <4FB507BE.3030107@oracle.com> Message-ID: Dan, Code looks good. Thank you for figuring out this work-around. thanks, Karen On May 17, 2012, at 10:14 AM, Daniel D. Daugherty wrote: > Greetings, > > This is a code review request for the following P1 bug: > > 7168520 1/3 No jdk8 TL Nightly linux builds due to broken link in > b39-2012-05-13_231 > > Here is the URL for the webrev: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7168520-webrev/0/ > > This fix has already been reviewed internally and is in the process of > being pushed to the JDK8 T&L repo. Since the bug impacts our internal > aurora tool, we're moving very quickly on this issue. If this code > review request generates any additional changes, then we'll use another > bug ID to make those changes. > > Gory details below... > > In the original FDS implementation, per-VM libjsig.debuginfo symlinks were > created that refer to ../libjsig.debuginfo. When the ZIP_DEBUGINFO_FILES > feature is enabled (the default), the jre/lib//libjsig.debuginfo > files are ZIPed into jre/lib//libjsig.diz. This makes the per-VM > libjsig.debuginfo symlinks "dangling" because the ../libjsig.debuginfo > files are ZIP'ed. Aurora doesn't tolerate dangling symlinks so this fix > puts a work around in place. > > The work around ZIPs the per-VM libjsig.debuginfo symlinks into a per-VM > libjsig.diz file. Aurora has no problem with ZIP files. After the work > around is in place, the default libjsig.diz layout is: > > jre/lib//libjsig.diz - ZIP'ed real libjsig.debuginfo > jre/lib//client/libjsig.diz - ZIP'ed symlink > (libjsig.debuginfo -> ../libjsig.debuginfo) > jre/lib//server/libjsig.diz - ZIP'ed symlink > (libjsig.debuginfo -> ../libjsig.debuginfo) > > Dan > From daniel.daugherty at oracle.com Thu May 17 14:31:07 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 17 May 2012 08:31:07 -0600 Subject: code review request for FDS/aurora bug fix (7168520) In-Reply-To: References: <4FB507BE.3030107@oracle.com> Message-ID: <4FB50BAB.6050000@oracle.com> Thanks Karen! Since the JDK8 changeset is already in flight, I can't add you as a reviewer there, but I will add you as a reviewer to the 7u6 version which I'm putting together right now... Dan On 5/17/12 8:24 AM, Karen Kinnear wrote: > Dan, > > Code looks good. Thank you for figuring out this work-around. > > thanks, > Karen > > On May 17, 2012, at 10:14 AM, Daniel D. Daugherty wrote: > >> Greetings, >> >> This is a code review request for the following P1 bug: >> >> 7168520 1/3 No jdk8 TL Nightly linux builds due to broken link in >> b39-2012-05-13_231 >> >> Here is the URL for the webrev: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7168520-webrev/0/ >> >> This fix has already been reviewed internally and is in the process of >> being pushed to the JDK8 T&L repo. Since the bug impacts our internal >> aurora tool, we're moving very quickly on this issue. If this code >> review request generates any additional changes, then we'll use another >> bug ID to make those changes. >> >> Gory details below... >> >> In the original FDS implementation, per-VM libjsig.debuginfo symlinks were >> created that refer to ../libjsig.debuginfo. When the ZIP_DEBUGINFO_FILES >> feature is enabled (the default), the jre/lib//libjsig.debuginfo >> files are ZIPed into jre/lib//libjsig.diz. This makes the per-VM >> libjsig.debuginfo symlinks "dangling" because the ../libjsig.debuginfo >> files are ZIP'ed. Aurora doesn't tolerate dangling symlinks so this fix >> puts a work around in place. >> >> The work around ZIPs the per-VM libjsig.debuginfo symlinks into a per-VM >> libjsig.diz file. Aurora has no problem with ZIP files. After the work >> around is in place, the default libjsig.diz layout is: >> >> jre/lib//libjsig.diz - ZIP'ed real libjsig.debuginfo >> jre/lib//client/libjsig.diz - ZIP'ed symlink >> (libjsig.debuginfo -> ../libjsig.debuginfo) >> jre/lib//server/libjsig.diz - ZIP'ed symlink >> (libjsig.debuginfo -> ../libjsig.debuginfo) >> >> Dan >> From magnus.ihse.bursie at oracle.com Mon May 21 10:59:47 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Mon, 21 May 2012 12:59:47 +0200 Subject: New log control system entering build-infra Message-ID: <4FBA2023.4020907@oracle.com> I have just pushed a new way of controlling the make log verbosity to the build-infra repository. Hopefully, it will get integrated into the build and mainline forests further on. With this new system, the makefile verbosity can be controlled using the LOG variable. LOG can be set to any of "warn", "info", "debug" or "trace" (inspired by log4j log levels). The default is "warn". * LOG=warn will give you just basic information about build process, and warnings and errors reported by the tools. * LOG=info will mimick the old makefiles, that is, print each command as it is executed by make. This is helpful for determining tricky errors in the source code, where the error message does not clearly state which file is problematic. * LOG=debug will display all shell executions (not only when make executes a rule, but also in the internal Makefile logic). This is helpful for debugging Makefile problems. If you want to report a problem with the new build system, please run with LOG=debug to create a full debug log for us. (Note that the log gets extemly large with this setting, so it cannot be attached to an email.) * LOG=trace displays inner workings of make and is probably not useful except in extreme cases. As always, the complete build log is saved to the file build.log in your build directory. The old way of explicitely setting make flags using the VERBOSE variable (e.g. setting it to VERBOSE= to disable the default "-s") is still available but is not recommended. /Magnus From kelly.ohair at oracle.com Tue May 22 01:48:29 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 21 May 2012 18:48:29 -0700 Subject: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files In-Reply-To: <4FB0BFED.8000107@oracle.com> References: <4F97FFC3.3090509@oracle.com> <4F9817D6.8080701@oracle.com> <4F989F8F.6000905@oracle.com> <4F98FAD2.7030808@oracle.com> <5740792D-2EBF-49A5-9511-E37710FD522F@oracle.com> <4FB0BFED.8000107@oracle.com> Message-ID: On May 14, 2012, at 1:18 AM, Magnus Ihse Bursie wrote: > On 2012-05-02 00:19, Kelly Ohair wrote: >> Magnus, >> >> Do you still need this integrated? >> I can integrate the exact same changset to awt, 2d, and build forests if you want. > > Yes, I still like to have this integrated. (Sorry for the slow response, it's been a bit low on the priority list.) Otherwise we need to add a @GenerateNativeHeaders annotation to a class that only generates an empty header file, and that looks kind of silly. :-) > > /Magnus Is this the patch I need to integrate? http://cr.openjdk.java.net/~ihse/remove-empty-imports/webrev.00/ And who do I put down as the reviewers? -kto From magnus.ihse.bursie at oracle.com Tue May 22 08:06:41 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 22 May 2012 10:06:41 +0200 Subject: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files In-Reply-To: References: <4F97FFC3.3090509@oracle.com> <4F9817D6.8080701@oracle.com> <4F989F8F.6000905@oracle.com> <4F98FAD2.7030808@oracle.com> <5740792D-2EBF-49A5-9511-E37710FD522F@oracle.com> <4FB0BFED.8000107@oracle.com> Message-ID: <4FBB4911.3000103@oracle.com> On 2012-05-22 03:48, Kelly O'Hair wrote: > On May 14, 2012, at 1:18 AM, Magnus Ihse Bursie wrote: > >> On 2012-05-02 00:19, Kelly Ohair wrote: >>> Magnus, >>> >>> Do you still need this integrated? >>> I can integrate the exact same changset to awt, 2d, and build forests if you want. >> Yes, I still like to have this integrated. (Sorry for the slow response, it's been a bit low on the priority list.) Otherwise we need to add a @GenerateNativeHeaders annotation to a class that only generates an empty header file, and that looks kind of silly. :-) >> >> /Magnus > > Is this the patch I need to integrate? > http://cr.openjdk.java.net/~ihse/remove-empty-imports/webrev.00/ Yes. > And who do I put down as the reviewers? From the mail replies: Anthony Petrov Chris Hegarty Phil Race /Magnus From erik.joelsson at oracle.com Tue May 22 15:17:51 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 22 May 2012 17:17:51 +0200 Subject: Review Request: Build-infra update In-Reply-To: References: <4FB39E43.6080909@oracle.com> Message-ID: <4FBBAE1F.3060906@oracle.com> New webrevs published (those ending in .1): http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ All issues below have been addressed. There are also some other improvements that we felt should get in now. /Erik On 2012-05-16 23:21, Fredrik ?hrstr?m wrote: > In configure.ac: > Indententation looks odd where solaris optimizations settings for CC > are calculated. > Could someone enlighten this configure script with a comment about libCrun? > > In logger.sh: > trap "rm -rf '$RCDIR'" EXIT > The $RCDIR is not replaced with the contents of the variable RCDIR > since it is surrounded by single quotes. > I assume the single quotes were added to deal with paths with spaces > in them on windows. > Perhaps there is some clever way to solve this. > > Somewhat broken comment in JavaCompilation.gmk: > 178 # When this macro is run in the same makefile as the java > compilation, dependencies are transfered > 179 # in make variables. When the macro is run in a different > makefile than the java compilation, the > 180 # needs to be found in the filesystem. > > In the root makefile, could you explain what CONF does and what the > source tip code does? > > In the corba makefile, it seems like we forgot to use $(MKDIR) for > mkdir and several other commands. > > In CompileJavaClasses.gmk: > 88 # Jonas 2012-04-25: It's only used to generate...i.e a build tool > > Then it should still be excluded from the jdk build, even on Macosx, > should it not? > > 128 ifeq ($(JONAS),TODO_DONE) > > 277 # List of java classes that should be javah compiled, but is not > auto-detected > 278 BUILD_JDK_EXTRA_NATIVE := java.net.InetAddressImplFactory > > Is this because we have not had time to add GenerateNativeHeader for this class? > > > In NativeCompilation.gmk: > 91 # as this is firt time I see it > > Is the source so messed up that we need BUILD_LIBMLIB_IMAGE_V_FILES > and BUILD_LIBINSTRUMENT_FILES, BUILD_LIBNIO_FILES, LIBAWT_XAWT_FILES, > LIBAWT_HEADLESS_FILES, LIBAWT_XAWT_FILES, LIBSPLASHSCREEN_FILES, > LIBAWT_FILES, LIBJSOUND_MIDIFILES, LIBJSOUND_PORTFILES, LIBJSOUND_DAUDIOFILES, > LIBAPPLESCRIPTENGINE_FILES, LIBAWT_LWAWT_FILES, LIBOSXUI_FILES? > > Unfortunately, I can guess that the answer is yes. However everyone should now > that each time an explicit source file name is added to a makefile, a > kitten dies! > > Can we rename newobjs into objs? The names newobjs and newclasses were only > used while we converted the makefiles. > > In CopyFiles.gmk: > # TODO: Platform dir needs to be "win32" on windows /erikj > Fixed isn't it? > > In GenerateClasses.gmk: > 33 # Depend on files in classes for now to avoid bad dependency > handling caused by > 34 # copy always updating timestamps in classes. > 35 NEWCLASSES_DIR := $(JDK_OUTPUTDIR)/classes > > Drop the comment, and drop NEWCLASSES_DIR, just do > CLASSES_DIR:=$(JDK_OUTPUTDIR)/classes > in the macro call. > > In GenerateJavaSources.gmk: > Use $(CHMOD) instead of chmod etc etc > > In GensrcMisc.gmk: > Why is realpath needed here? > 172 SRC:=$(realpath $(dir $(GENSRC_SOL_SRC) > > In GensrcCharacterData.gmk: > replace echo with $(ECHO) > > In Images.gmk: > You can remove the comments from line 35 to 44. > Though the incantation: I.e. -do-not-use- :: rules!!!!! > Repeat after me: -do-not-use- :: rules!!!!! > Should be recited 100 times by anyone who wants to > edit the new makefiles. :-) > > Are makefiles/com/Makefile and makefiles/javax/Makefile > empty? Can they be removed? > > Awesome work! > > //Fredrik > > 2012/5/16 Erik Joelsson: >> The build-infra project has been quite productive and would like to push an >> update to the new build in jdk8. >> >> All webrevs can be found here: >> http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ >> >> >> What's new in this push? >> * Makefile conversion is basically done (a few minor exceptions but all code >> is compiled by new makefiles now). >> * Solaris ia32 is now as binary compatible with the old build as linux is. >> * Build speed is significantly improved since only new makefiles are used. >> (Rough examples for full open build: Linux 7min, Solaris ia32 7min, Windows >> 22min) >> * Windows still builds and is runnable. >> * Several bugfixes. >> >> Why push now, it's not all done yet? >> The main driver for this push is the jigsaw project that needs to consume >> the full conversion of the makefiles in order to work on the jigsaw build. >> We also think that people trying out the new build will enjoy the speed >> improvement. Of course we also welcome more feedback on the new build >> system. >> >> /Erik From kelly.ohair at oracle.com Tue May 22 21:08:58 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 22 May 2012 14:08:58 -0700 Subject: Review Request: Build-infra update In-Reply-To: <4FBBAE1F.3060906@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> Message-ID: <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> Not sure where we are on these changes. I have made sure that they don't regress the old builds and am ready to integrate, but I'm concerned on Alan's modularity comment, and also who should I be adding to the "Reviewed-by" list. Also, I'm thinking I should separate the changes in the jdk repo to isolate the changes to the old build system, the sources, and the build-infra changes. Let me know if that make sense. -kto On May 22, 2012, at 8:17 AM, Erik Joelsson wrote: > New webrevs published (those ending in .1): > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ > > All issues below have been addressed. There are also some other improvements that we felt should get in now. > > /Erik > > On 2012-05-16 23:21, Fredrik ?hrstr?m wrote: >> In configure.ac: >> Indententation looks odd where solaris optimizations settings for CC >> are calculated. >> Could someone enlighten this configure script with a comment about libCrun? >> >> In logger.sh: >> trap "rm -rf '$RCDIR'" EXIT >> The $RCDIR is not replaced with the contents of the variable RCDIR >> since it is surrounded by single quotes. >> I assume the single quotes were added to deal with paths with spaces >> in them on windows. >> Perhaps there is some clever way to solve this. >> >> Somewhat broken comment in JavaCompilation.gmk: >> 178 # When this macro is run in the same makefile as the java >> compilation, dependencies are transfered >> 179 # in make variables. When the macro is run in a different >> makefile than the java compilation, the >> 180 # needs to be found in the filesystem. >> >> In the root makefile, could you explain what CONF does and what the >> source tip code does? >> >> In the corba makefile, it seems like we forgot to use $(MKDIR) for >> mkdir and several other commands. >> >> In CompileJavaClasses.gmk: >> 88 # Jonas 2012-04-25: It's only used to generate...i.e a build tool >> >> Then it should still be excluded from the jdk build, even on Macosx, >> should it not? >> >> 128 ifeq ($(JONAS),TODO_DONE) >> >> 277 # List of java classes that should be javah compiled, but is not >> auto-detected >> 278 BUILD_JDK_EXTRA_NATIVE := java.net.InetAddressImplFactory >> >> Is this because we have not had time to add GenerateNativeHeader for this class? >> >> >> In NativeCompilation.gmk: >> 91 # as this is firt time I see it >> >> Is the source so messed up that we need BUILD_LIBMLIB_IMAGE_V_FILES >> and BUILD_LIBINSTRUMENT_FILES, BUILD_LIBNIO_FILES, LIBAWT_XAWT_FILES, >> LIBAWT_HEADLESS_FILES, LIBAWT_XAWT_FILES, LIBSPLASHSCREEN_FILES, >> LIBAWT_FILES, LIBJSOUND_MIDIFILES, LIBJSOUND_PORTFILES, LIBJSOUND_DAUDIOFILES, >> LIBAPPLESCRIPTENGINE_FILES, LIBAWT_LWAWT_FILES, LIBOSXUI_FILES? >> >> Unfortunately, I can guess that the answer is yes. However everyone should now >> that each time an explicit source file name is added to a makefile, a >> kitten dies! >> >> Can we rename newobjs into objs? The names newobjs and newclasses were only >> used while we converted the makefiles. >> >> In CopyFiles.gmk: >> # TODO: Platform dir needs to be "win32" on windows /erikj >> Fixed isn't it? >> >> In GenerateClasses.gmk: >> 33 # Depend on files in classes for now to avoid bad dependency >> handling caused by >> 34 # copy always updating timestamps in classes. >> 35 NEWCLASSES_DIR := $(JDK_OUTPUTDIR)/classes >> >> Drop the comment, and drop NEWCLASSES_DIR, just do >> CLASSES_DIR:=$(JDK_OUTPUTDIR)/classes >> in the macro call. >> >> In GenerateJavaSources.gmk: >> Use $(CHMOD) instead of chmod etc etc >> >> In GensrcMisc.gmk: >> Why is realpath needed here? >> 172 SRC:=$(realpath $(dir $(GENSRC_SOL_SRC) >> >> In GensrcCharacterData.gmk: >> replace echo with $(ECHO) >> >> In Images.gmk: >> You can remove the comments from line 35 to 44. >> Though the incantation: I.e. -do-not-use- :: rules!!!!! >> Repeat after me: -do-not-use- :: rules!!!!! >> Should be recited 100 times by anyone who wants to >> edit the new makefiles. :-) >> >> Are makefiles/com/Makefile and makefiles/javax/Makefile >> empty? Can they be removed? >> >> Awesome work! >> >> //Fredrik >> >> 2012/5/16 Erik Joelsson: >>> The build-infra project has been quite productive and would like to push an >>> update to the new build in jdk8. >>> >>> All webrevs can be found here: >>> http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ >>> >>> >>> What's new in this push? >>> * Makefile conversion is basically done (a few minor exceptions but all code >>> is compiled by new makefiles now). >>> * Solaris ia32 is now as binary compatible with the old build as linux is. >>> * Build speed is significantly improved since only new makefiles are used. >>> (Rough examples for full open build: Linux 7min, Solaris ia32 7min, Windows >>> 22min) >>> * Windows still builds and is runnable. >>> * Several bugfixes. >>> >>> Why push now, it's not all done yet? >>> The main driver for this push is the jigsaw project that needs to consume >>> the full conversion of the makefiles in order to work on the jigsaw build. >>> We also think that people trying out the new build will enjoy the speed >>> improvement. Of course we also welcome more feedback on the new build >>> system. >>> >>> /Erik From kelly.ohair at oracle.com Wed May 23 01:14:54 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 22 May 2012 18:14:54 -0700 Subject: Need reviewer - @GenerateNativeHeader Message-ID: 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ The new build infrastructure wants to fully automate the generation of the JNI header files (running javah). On classes that have "native" methods this is obvious, but class that only export constants, and whose constants are needed in the JNI native code, we need to mark these classes as needing their native header file generated. This change is adding: import javax.tools.annotation.GenerateNativeHeader; /* No native methods here, but the constants are needed in the supporting JNI code */ @GenerateNativeHeader To any class without a native method, but needing to expose it's constants to the native code. -kto From oehrstroem at gmail.com Wed May 23 07:03:13 2012 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Wed, 23 May 2012 09:03:13 +0200 Subject: Need reviewer - @GenerateNativeHeader In-Reply-To: References: Message-ID: Looks good. Since the annotation is a compile time only annotation, it should not affect any future modularization efforts. Right Alan? //Fredrik 2012/5/23 Kelly O'Hair : > > 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI > http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ > > The new build infrastructure wants to fully automate the generation of the JNI header files (running javah). > On classes that have "native" methods this is obvious, but class that only export constants, and whose constants > are needed in the JNI native code, we need to mark these classes as needing their native header file generated. > > This change is adding: > > import javax.tools.annotation.GenerateNativeHeader; > > /* No native methods here, but the constants are needed in the supporting JNI code */ > @GenerateNativeHeader > > To any class without a native method, but needing to expose it's constants to the native code. > > -kto > From Alan.Bateman at oracle.com Wed May 23 07:15:22 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 23 May 2012 08:15:22 +0100 Subject: Need reviewer - @GenerateNativeHeader In-Reply-To: References: Message-ID: <4FBC8E8A.7060104@oracle.com> Kelly, Can you hold off pushing this for a few days? While this is compile-time only dependency I think the impact needs further study. -Alan. On 23/05/2012 02:14, Kelly O'Hair wrote: > 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI > http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ > > The new build infrastructure wants to fully automate the generation of the JNI header files (running javah). > On classes that have "native" methods this is obvious, but class that only export constants, and whose constants > are needed in the JNI native code, we need to mark these classes as needing their native header file generated. > > This change is adding: > > import javax.tools.annotation.GenerateNativeHeader; > > /* No native methods here, but the constants are needed in the supporting JNI code */ > @GenerateNativeHeader > > To any class without a native method, but needing to expose it's constants to the native code. > > -kto > From erik.joelsson at oracle.com Wed May 23 07:30:59 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 23 May 2012 09:30:59 +0200 Subject: Review Request: Build-infra update In-Reply-To: <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> Message-ID: <4FBC9233.9000306@oracle.com> On 2012-05-22 23:08, Kelly O'Hair wrote: > Not sure where we are on these changes. I have made sure that they don't regress the old builds > and am ready to integrate, but I'm concerned on Alan's modularity comment, and also who should > I be adding to the "Reviewed-by" list. I'm also not sure if Alan's comment was a blocker. The idea with GenerateNativeHeader was approved by Jon Gibbon's initially at least. Alan? Reviewers so far are ohair, ohrstrom and ihse at least, probably alanb? Contributors are erikj, jonas, ihse, ykantser, tgranat, fredrik, ohair. Not sure about the order or if it's relevant. Do we need reviewers that aren't contributors? > Also, I'm thinking I should separate the changes in the jdk repo to isolate the changes to the old > build system, the sources, and the build-infra changes. Let me know if that make sense. > Separating makes sense. I could make an attempt at it today. /Erik > -kto > > On May 22, 2012, at 8:17 AM, Erik Joelsson wrote: > >> New webrevs published (those ending in .1): >> http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ >> >> All issues below have been addressed. There are also some other improvements that we felt should get in now. >> >> /Erik >> >> On 2012-05-16 23:21, Fredrik ?hrstr?m wrote: >>> In configure.ac: >>> Indententation looks odd where solaris optimizations settings for CC >>> are calculated. >>> Could someone enlighten this configure script with a comment about libCrun? >>> >>> In logger.sh: >>> trap "rm -rf '$RCDIR'" EXIT >>> The $RCDIR is not replaced with the contents of the variable RCDIR >>> since it is surrounded by single quotes. >>> I assume the single quotes were added to deal with paths with spaces >>> in them on windows. >>> Perhaps there is some clever way to solve this. >>> >>> Somewhat broken comment in JavaCompilation.gmk: >>> 178 # When this macro is run in the same makefile as the java >>> compilation, dependencies are transfered >>> 179 # in make variables. When the macro is run in a different >>> makefile than the java compilation, the >>> 180 # needs to be found in the filesystem. >>> >>> In the root makefile, could you explain what CONF does and what the >>> source tip code does? >>> >>> In the corba makefile, it seems like we forgot to use $(MKDIR) for >>> mkdir and several other commands. >>> >>> In CompileJavaClasses.gmk: >>> 88 # Jonas 2012-04-25: It's only used to generate...i.e a build tool >>> >>> Then it should still be excluded from the jdk build, even on Macosx, >>> should it not? >>> >>> 128 ifeq ($(JONAS),TODO_DONE) >>> >>> 277 # List of java classes that should be javah compiled, but is not >>> auto-detected >>> 278 BUILD_JDK_EXTRA_NATIVE := java.net.InetAddressImplFactory >>> >>> Is this because we have not had time to add GenerateNativeHeader for this class? >>> >>> >>> In NativeCompilation.gmk: >>> 91 # as this is firt time I see it >>> >>> Is the source so messed up that we need BUILD_LIBMLIB_IMAGE_V_FILES >>> and BUILD_LIBINSTRUMENT_FILES, BUILD_LIBNIO_FILES, LIBAWT_XAWT_FILES, >>> LIBAWT_HEADLESS_FILES, LIBAWT_XAWT_FILES, LIBSPLASHSCREEN_FILES, >>> LIBAWT_FILES, LIBJSOUND_MIDIFILES, LIBJSOUND_PORTFILES, LIBJSOUND_DAUDIOFILES, >>> LIBAPPLESCRIPTENGINE_FILES, LIBAWT_LWAWT_FILES, LIBOSXUI_FILES? >>> >>> Unfortunately, I can guess that the answer is yes. However everyone should now >>> that each time an explicit source file name is added to a makefile, a >>> kitten dies! >>> >>> Can we rename newobjs into objs? The names newobjs and newclasses were only >>> used while we converted the makefiles. >>> >>> In CopyFiles.gmk: >>> # TODO: Platform dir needs to be "win32" on windows /erikj >>> Fixed isn't it? >>> >>> In GenerateClasses.gmk: >>> 33 # Depend on files in classes for now to avoid bad dependency >>> handling caused by >>> 34 # copy always updating timestamps in classes. >>> 35 NEWCLASSES_DIR := $(JDK_OUTPUTDIR)/classes >>> >>> Drop the comment, and drop NEWCLASSES_DIR, just do >>> CLASSES_DIR:=$(JDK_OUTPUTDIR)/classes >>> in the macro call. >>> >>> In GenerateJavaSources.gmk: >>> Use $(CHMOD) instead of chmod etc etc >>> >>> In GensrcMisc.gmk: >>> Why is realpath needed here? >>> 172 SRC:=$(realpath $(dir $(GENSRC_SOL_SRC) >>> >>> In GensrcCharacterData.gmk: >>> replace echo with $(ECHO) >>> >>> In Images.gmk: >>> You can remove the comments from line 35 to 44. >>> Though the incantation: I.e. -do-not-use- :: rules!!!!! >>> Repeat after me: -do-not-use- :: rules!!!!! >>> Should be recited 100 times by anyone who wants to >>> edit the new makefiles. :-) >>> >>> Are makefiles/com/Makefile and makefiles/javax/Makefile >>> empty? Can they be removed? >>> >>> Awesome work! >>> >>> //Fredrik >>> >>> 2012/5/16 Erik Joelsson: >>>> The build-infra project has been quite productive and would like to push an >>>> update to the new build in jdk8. >>>> >>>> All webrevs can be found here: >>>> http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ >>>> >>>> >>>> What's new in this push? >>>> * Makefile conversion is basically done (a few minor exceptions but all code >>>> is compiled by new makefiles now). >>>> * Solaris ia32 is now as binary compatible with the old build as linux is. >>>> * Build speed is significantly improved since only new makefiles are used. >>>> (Rough examples for full open build: Linux 7min, Solaris ia32 7min, Windows >>>> 22min) >>>> * Windows still builds and is runnable. >>>> * Several bugfixes. >>>> >>>> Why push now, it's not all done yet? >>>> The main driver for this push is the jigsaw project that needs to consume >>>> the full conversion of the makefiles in order to work on the jigsaw build. >>>> We also think that people trying out the new build will enjoy the speed >>>> improvement. Of course we also welcome more feedback on the new build >>>> system. >>>> >>>> /Erik From oehrstroem at gmail.com Wed May 23 07:51:02 2012 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Wed, 23 May 2012 09:51:02 +0200 Subject: Need reviewer - @GenerateNativeHeader In-Reply-To: <4FBC8E8A.7060104@oracle.com> References: <4FBC8E8A.7060104@oracle.com> Message-ID: There is no point holding off this push since GenerateNativeHeader annotation and uses of it were already pushed long time ago. These are just the finishing touches to cater for the conversion of the remaining makefiles. If you want another location for the annotation then we can easily search and replace it later. //Fredrik 2012/5/23 Alan Bateman : > Kelly, > > Can you hold off pushing this for a few days? While this is compile-time > only dependency I think the impact needs further study. > > -Alan. > > > > On 23/05/2012 02:14, Kelly O'Hair wrote: >> >> 7170969: Add @GenerateNativeHeader to classes whose fields need to be >> exported for JNI >> http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ >> >> The new build infrastructure wants to fully automate the generation of the >> JNI header files (running javah). >> On classes that have "native" methods this is obvious, but class that only >> export constants, and whose constants >> are needed in the JNI native code, we need to mark these classes as >> needing their native header file generated. >> >> This change is adding: >> >> import javax.tools.annotation.GenerateNativeHeader; >> >> /* No native methods here, but the constants are needed in the supporting >> JNI code */ >> @GenerateNativeHeader >> >> To any class without a native method, but needing to expose it's constants >> to the native code. >> >> -kto >> > From Alan.Bateman at oracle.com Wed May 23 08:00:32 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 23 May 2012 09:00:32 +0100 Subject: Review Request: Build-infra update In-Reply-To: <4FBC9233.9000306@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> Message-ID: <4FBC9920.1010806@oracle.com> On 23/05/2012 08:30, Erik Joelsson wrote: > > I'm also not sure if Alan's comment was a blocker. The idea with > GenerateNativeHeader was approved by Jon Gibbon's initially at least. > Alan? I don't like holding things up but I do think this needs wider consideration. -Alan From magnus.ihse.bursie at oracle.com Wed May 23 10:57:12 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Wed, 23 May 2012 12:57:12 +0200 Subject: Need reviewer - @GenerateNativeHeader In-Reply-To: References: <4FBC8E8A.7060104@oracle.com> Message-ID: <4FBCC288.70407@oracle.com> On 2012-05-23 09:51, Fredrik ?hrstr?m wrote: > There is no point holding off this push since GenerateNativeHeader annotation > and uses of it were already pushed long time ago. These are just the finishing > touches to cater for the conversion of the remaining makefiles. I think Fredrik has a point here. If the idea of using the GenerateNativeHeader (without any particular regard to modularization) is problematic, then we already have a problem since we already have put in GenerateNativeHeader annotations across the code base. If this approach is not working, then we need to revert those annotations. This calls for a separate webrev anyway. If this approach *is* working, then this change adds no new problems. So we could avoid stalling this push (which is needed to be able to continue working on build-infra in the Jigsaw forest) by allowing the additional GenerateNativeHeaders for now, and then continuing the discussion if the whole idea of GenerateNativeHeaders really work in the modularized world, and if not, replace them all with a working solution. Does that sound OK to you? /Magnus From ahughes at redhat.com Wed May 23 12:59:48 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Wed, 23 May 2012 08:59:48 -0400 (EDT) Subject: [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: <0052bf00-613a-4cc1-8236-8f82d44cce24@zmail17.collab.prod.int.phx2.redhat.com> Message-ID: At present, the building of ExtensionSubtables.cpp produces a warning: ../../../src/share/native/sun/font/layout/ExtensionSubtables.cpp:57:31: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] due to this code: // read a 32-bit value that might only be 16-bit-aligned in memory #define READ_LONG(code) (le_uint32)((SWAPW(*(le_uint16*)&code) << 16) + SWAPW(*(((le_uint16*)&code) + 1))) where code is a le_uint32. This can be avoided by setting -fno-strict-aliasing, as done in this webrev: http://cr.openjdk.java.net/~andrew/no-strict-aliasing/ making the code safer in the process. Ok for jdk8? If so, can I have a bug ID for this please? Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From ahughes at redhat.com Wed May 23 14:36:43 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Wed, 23 May 2012 10:36:43 -0400 (EDT) Subject: Solaris-only flag with newer gcc = build failed In-Reply-To: Message-ID: ----- Original Message ----- > > > > > On Tue, May 15, 2012 at 4:35 AM, David Holmes < > david.holmes at oracle.com > wrote: > > > Hi Pierre, > > [...] > > This is bug 7150392 and was fixed about 6 weeks ago. > > > > Hi David > > > Indeed, it's exactly the same problem as bug #7150392 > > > I've checked several versions of OpenJDK source (jdk7/jdk7, > jdk7u/jdk7u, jdk7u/jdk7u4, and jdk8/jdk8), and it seems that the > proposed patch has only been applied on jdk8 repo. So this could > explain than I ran into this bug after it was corrected. > In jdk7u/jdk7u now, will be in OpenJDK7u6: http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/003119.html > > Anyway, thanks for you time ! > > > Regards > > -- > > Pierre Laporte > pierre at pingtimeout.fr > http://www.pingtimeout.fr/ > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From jonathan.gibbons at oracle.com Wed May 23 15:01:20 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 23 May 2012 08:01:20 -0700 Subject: Review Request: Build-infra update In-Reply-To: <4FBC9920.1010806@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> Message-ID: <4FBCFBC0.9070301@oracle.com> On 05/23/2012 01:00 AM, Alan Bateman wrote: > On 23/05/2012 08:30, Erik Joelsson wrote: >> >> I'm also not sure if Alan's comment was a blocker. The idea with >> GenerateNativeHeader was approved by Jon Gibbon's initially at least. >> Alan? > I don't like holding things up but I do think this needs wider > consideration. > > -Alan There are various solutions here. 1. revert to using javah for selected files 2. give javac a list of classnames for which to generate a native header 3. move the annotation to somewhere like java.lang.annotation 4. fix Jigsaw None of the first 3 are attractive. The last one may be difficult, but at some point, it will be necessary. The problems with @GenerateNativeHeader are not specific to this particular annotation, but rather to any annotation with RetentionPolicy.SOURCE. However, the problems are somewhat exacerbated by the use of the annotation in the base module, where we are on delicate bootstrapping ground. -- Jon From philip.race at oracle.com Wed May 23 16:01:17 2012 From: philip.race at oracle.com (Phil Race) Date: Wed, 23 May 2012 09:01:17 -0700 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: References: Message-ID: <4FBD09CD.3020001@oracle.com> I suppose the problem that some new version of GCC enables this option by default and we could run into a problem at run time if we don't disable it ? But this patch would appear to disable it for the whole ICU library .. and any other C++ code in the .so which I would have to suppose impacts the compiler's ability to optimise the code, in order to eliminate a single warning. Can you devise a more targeted fix ? -phil. On 5/23/2012 5:59 AM, Andrew Hughes wrote: > At present, the building of ExtensionSubtables.cpp produces a warning: > > ../../../src/share/native/sun/font/layout/ExtensionSubtables.cpp:57:31: > warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] > > due to this code: > > // read a 32-bit value that might only be 16-bit-aligned in memory > #define READ_LONG(code) (le_uint32)((SWAPW(*(le_uint16*)&code)<< 16) + SWAPW(*(((le_uint16*)&code) + 1))) > > where code is a le_uint32. > > This can be avoided by setting -fno-strict-aliasing, as done in this webrev: > > http://cr.openjdk.java.net/~andrew/no-strict-aliasing/ > > making the code safer in the process. > > Ok for jdk8? If so, can I have a bug ID for this please? > > Thanks, From philip.race at oracle.com Wed May 23 16:34:40 2012 From: philip.race at oracle.com (Phil Race) Date: Wed, 23 May 2012 09:34:40 -0700 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: <99F32F72-3D99-49A2-A062-38468AD75FAA@exnet.com> References: <4FBD09CD.3020001@oracle.com> <99F32F72-3D99-49A2-A062-38468AD75FAA@exnet.com> Message-ID: <4FBD11A0.4020107@oracle.com> It may not be easy but its worth investigating. BTW .. I have not recently tried the new build mechanism, but does anyone on the build list know what kinds of build changes will very probably just work with that too, and which will need to be tested separately ? -phil. On 5/23/2012 9:12 AM, Damon Hart-Davis wrote: > Hi, > > FWIW, and I have not looked at any of the build system for this, when building large optimised cross-platform critical C++ projects I had the option to turn down or off optimisation for individual files for individual compilers/platforms. > > At worst you might accomplish that (with other maintenance risks) with an explicit build rule in the makefile for that .cpp file for that platform/compiler, but only if the macro is local to that .cpp file. > > Anyhow, I'm speaking from ignorance of all the detail here, so please ignore me! > > Rgds > > Damon > > > On 23 May 2012, at 17:01, Phil Race wrote: > >> I suppose the problem that some new version of GCC enables this option by default and >> we could run into a problem at run time if we don't disable it ? >> >> But this patch would appear to disable it for the whole ICU library .. and any other C++ code in the .so >> which I would have to suppose impacts the compiler's ability to optimise the code, in order to >> eliminate a single warning. >> >> Can you devise a more targeted fix ? >> >> -phil. >> >> On 5/23/2012 5:59 AM, Andrew Hughes wrote: >>> At present, the building of ExtensionSubtables.cpp produces a warning: >>> >>> ../../../src/share/native/sun/font/layout/ExtensionSubtables.cpp:57:31: >>> warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] >>> >>> due to this code: >>> >>> // read a 32-bit value that might only be 16-bit-aligned in memory >>> #define READ_LONG(code) (le_uint32)((SWAPW(*(le_uint16*)&code)<< 16) + SWAPW(*(((le_uint16*)&code) + 1))) >>> >>> where code is a le_uint32. >>> >>> This can be avoided by setting -fno-strict-aliasing, as done in this webrev: >>> >>> http://cr.openjdk.java.net/~andrew/no-strict-aliasing/ >>> >>> making the code safer in the process. >>> >>> Ok for jdk8? If so, can I have a bug ID for this please? >>> >>> Thanks, From ahughes at redhat.com Wed May 23 16:32:10 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Wed, 23 May 2012 12:32:10 -0400 (EDT) Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: <4FBD09CD.3020001@oracle.com> Message-ID: ----- Original Message ----- > I suppose the problem that some new version of GCC enables this > option > by default and > we could run into a problem at run time if we don't disable it ? > Yes, 4.4 to be precise. It's not particularly new; it came out on April 21st, 2009. > But this patch would appear to disable it for the whole ICU library > .. > and any other C++ code in the .so > which I would have to suppose impacts the compiler's ability to > optimise > the code, in order to > eliminate a single warning. > > Can you devise a more targeted fix ? > Yes, I thought the same. But I don't see how you can direct flags to one specific file in the Makefiles. Any ideas? Alternatively, is this READ_LONG macro even necessary? I'm not surprised gcc balks at it to be honest. > -phil. > > On 5/23/2012 5:59 AM, Andrew Hughes wrote: > > At present, the building of ExtensionSubtables.cpp produces a > > warning: > > > > ../../../src/share/native/sun/font/layout/ExtensionSubtables.cpp:57:31: > > warning: dereferencing type-punned pointer will break > > strict-aliasing rules [-Wstrict-aliasing] > > > > due to this code: > > > > // read a 32-bit value that might only be 16-bit-aligned in memory > > #define READ_LONG(code) (le_uint32)((SWAPW(*(le_uint16*)&code)<< > > 16) + SWAPW(*(((le_uint16*)&code) + 1))) > > > > where code is a le_uint32. > > > > This can be avoided by setting -fno-strict-aliasing, as done in > > this webrev: > > > > http://cr.openjdk.java.net/~andrew/no-strict-aliasing/ > > > > making the code safer in the process. > > > > Ok for jdk8? If so, can I have a bug ID for this please? > > > > Thanks, > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From ahughes at redhat.com Wed May 23 16:36:18 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Wed, 23 May 2012 12:36:18 -0400 (EDT) Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: Message-ID: <7a69b082-e339-4cfc-b1ca-a415bb27d597@zmail17.collab.prod.int.phx2.redhat.com> ----- Original Message ----- > > > ----- Original Message ----- > > I suppose the problem that some new version of GCC enables this > > option > > by default and > > we could run into a problem at run time if we don't disable it ? > > > > Yes, 4.4 to be precise. It's not particularly new; it came out on > April 21st, 2009. > FYI, http://gcc.gnu.org/gcc-4.4/porting_to.html > > But this patch would appear to disable it for the whole ICU library > > .. > > and any other C++ code in the .so > > which I would have to suppose impacts the compiler's ability to > > optimise > > the code, in order to > > eliminate a single warning. > > > > Can you devise a more targeted fix ? > > > > Yes, I thought the same. But I don't see how you can direct flags to > one specific file in the Makefiles. Any ideas? > > Alternatively, is this READ_LONG macro even necessary? I'm not > surprised > gcc balks at it to be honest. > > > -phil. > > > > On 5/23/2012 5:59 AM, Andrew Hughes wrote: > > > At present, the building of ExtensionSubtables.cpp produces a > > > warning: > > > > > > ../../../src/share/native/sun/font/layout/ExtensionSubtables.cpp:57:31: > > > warning: dereferencing type-punned pointer will break > > > strict-aliasing rules [-Wstrict-aliasing] > > > > > > due to this code: > > > > > > // read a 32-bit value that might only be 16-bit-aligned in > > > memory > > > #define READ_LONG(code) (le_uint32)((SWAPW(*(le_uint16*)&code)<< > > > 16) + SWAPW(*(((le_uint16*)&code) + 1))) > > > > > > where code is a le_uint32. > > > > > > This can be avoided by setting -fno-strict-aliasing, as done in > > > this webrev: > > > > > > http://cr.openjdk.java.net/~andrew/no-strict-aliasing/ > > > > > > making the code safer in the process. > > > > > > Ok for jdk8? If so, can I have a bug ID for this please? > > > > > > Thanks, > > > > > > -- > Andrew :) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: 248BDC07 (https://keys.indymedia.org/) > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From philip.race at oracle.com Wed May 23 16:50:33 2012 From: philip.race at oracle.com (Phil Race) Date: Wed, 23 May 2012 09:50:33 -0700 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: References: Message-ID: <4FBD1559.60207@oracle.com> On 5/23/2012 9:32 AM, Andrew Hughes wrote: > > ----- Original Message ----- >> I suppose the problem that some new version of GCC enables this >> option >> by default and >> we could run into a problem at run time if we don't disable it ? >> > Yes, 4.4 to be precise. It's not particularly new; it came out on > April 21st, 2009. > >> But this patch would appear to disable it for the whole ICU library >> .. >> and any other C++ code in the .so >> which I would have to suppose impacts the compiler's ability to >> optimise >> the code, in order to >> eliminate a single warning. >> >> Can you devise a more targeted fix ? >> > Yes, I thought the same. But I don't see how you can direct flags to > one specific file in the Makefiles. Any ideas? I would normally suggest a pragma but when I googled around it looks like the appropriate one is actually non-functional on purpose .. https://bugzilla.redhat.com/show_bug.cgi?id=486176 So it might require a bit more makefile smarts. I think there's a chance some other example template of how to do this exists but I do not know. > Alternatively, is this READ_LONG macro even necessary? I'm not surprised > gcc balks at it to be honest. I would suppose it is needed but haven't closely examined the code. -phil. >> -phil. >> >> On 5/23/2012 5:59 AM, Andrew Hughes wrote: >>> At present, the building of ExtensionSubtables.cpp produces a >>> warning: >>> >>> ../../../src/share/native/sun/font/layout/ExtensionSubtables.cpp:57:31: >>> warning: dereferencing type-punned pointer will break >>> strict-aliasing rules [-Wstrict-aliasing] >>> >>> due to this code: >>> >>> // read a 32-bit value that might only be 16-bit-aligned in memory >>> #define READ_LONG(code) (le_uint32)((SWAPW(*(le_uint16*)&code)<< >>> 16) + SWAPW(*(((le_uint16*)&code) + 1))) >>> >>> where code is a le_uint32. >>> >>> This can be avoided by setting -fno-strict-aliasing, as done in >>> this webrev: >>> >>> http://cr.openjdk.java.net/~andrew/no-strict-aliasing/ >>> >>> making the code safer in the process. >>> >>> Ok for jdk8? If so, can I have a bug ID for this please? >>> >>> Thanks, >> From kelly.ohair at oracle.com Wed May 23 16:50:30 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 23 May 2012 09:50:30 -0700 Subject: Review Request: Build-infra update In-Reply-To: <4FBCFBC0.9070301@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> Message-ID: <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> Has anyone tried creating an unused native method declaration in the class to trigger the native header generation? public native void GenerateNativeHeader(); ??? Is that too ugly? -kto On May 23, 2012, at 8:01 AM, Jonathan Gibbons wrote: > On 05/23/2012 01:00 AM, Alan Bateman wrote: >> On 23/05/2012 08:30, Erik Joelsson wrote: >>> >>> I'm also not sure if Alan's comment was a blocker. The idea with GenerateNativeHeader was approved by Jon Gibbon's initially at least. Alan? >> I don't like holding things up but I do think this needs wider consideration. >> >> -Alan > > There are various solutions here. > > 1. revert to using javah for selected files > 2. give javac a list of classnames for which to generate a native header > 3. move the annotation to somewhere like java.lang.annotation > 4. fix Jigsaw > > None of the first 3 are attractive. The last one may be difficult, but at some > point, it will be necessary. The problems with @GenerateNativeHeader are > not specific to this particular annotation, but rather to any annotation > with RetentionPolicy.SOURCE. However, the problems are somewhat > exacerbated by the use of the annotation in the base module, where we > are on delicate bootstrapping ground. > > -- Jon > > From kelly.ohair at oracle.com Wed May 23 16:53:23 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 23 May 2012 09:53:23 -0700 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: References: Message-ID: <6104F634-A830-4E95-910F-E536AB159DA3@oracle.com> On May 23, 2012, at 9:32 AM, Andrew Hughes wrote: > Yes, I thought the same. But I don't see how you can direct flags to > one specific file in the Makefiles. Any ideas? You can add something like this to CFLAGS: CFLAGS += $(CFLAGS_$(@F)) Then: CFLAGS_foobar.o = -someoptions -kto -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alan.Bateman at oracle.com Wed May 23 17:05:29 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 23 May 2012 18:05:29 +0100 Subject: Review Request: Build-infra update In-Reply-To: <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> Message-ID: <4FBD18D9.1080401@oracle.com> On 23/05/2012 17:50, Kelly O'Hair wrote: > Has anyone tried creating an unused native method declaration in the class to trigger the native header > generation? public native void GenerateNativeHeader(); ??? Is that too ugly? > > -kto As Jon put it, for the classes in the base module, "we are delicate bootstrapping ground" so if you add something like "private static native void dummy()" rather than the annotation to the classes in the base module then it could be a solution for the short term. This means the following sources in the webrev: src/share/classes/java/lang/Integer.java src/share/classes/java/lang/Long.java src/share/classes/java/net/SocketOptions.java src/windows/classes/sun/nio/ch/PollArrayWrapper.java Also it would be good to remove it from src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation in the first round). -Alan. From ahughes at redhat.com Wed May 23 17:20:43 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Wed, 23 May 2012 13:20:43 -0400 (EDT) Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: <6104F634-A830-4E95-910F-E536AB159DA3@oracle.com> Message-ID: ----- Original Message ----- > > > > On May 23, 2012, at 9:32 AM, Andrew Hughes wrote: > > > Yes, I thought the same. But I don't see how you can direct flags to > one specific file in the Makefiles. Any ideas? > > You can add something like this to CFLAGS: > CFLAGS += $(CFLAGS_$(@F)) > > > Then: > CFLAGS_foobar.o = -someoptions > Thanks Kelly. I'll give that a try. > > -kto > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From jonathan.gibbons at oracle.com Wed May 23 18:03:34 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 23 May 2012 11:03:34 -0700 Subject: Review Request: Build-infra update In-Reply-To: <4FBD18D9.1080401@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> Message-ID: <4FBD2676.5090102@oracle.com> I wanted to be able to declare fields as native, but that was deemed unacceptable. -- Jon On 05/23/2012 10:05 AM, Alan Bateman wrote: > On 23/05/2012 17:50, Kelly O'Hair wrote: >> Has anyone tried creating an unused native method declaration in the >> class to trigger the native header >> generation? public native void GenerateNativeHeader(); ??? Is >> that too ugly? >> >> -kto > As Jon put it, for the classes in the base module, "we are delicate > bootstrapping ground" so if you add something like "private static > native void dummy()" rather than the annotation to the classes in the > base module then it could be a solution for the short term. This means > the following sources in the webrev: > > src/share/classes/java/lang/Integer.java > src/share/classes/java/lang/Long.java > src/share/classes/java/net/SocketOptions.java > src/windows/classes/sun/nio/ch/PollArrayWrapper.java > > Also it would be good to remove it from > src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation > in the first round). > > -Alan. > From daniel.daugherty at oracle.com Wed May 23 19:50:18 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 23 May 2012 13:50:18 -0600 Subject: code review for JDK FDS gobjcopy work arounds (7170449) Message-ID: <4FBD3F7A.4030501@oracle.com> Greetings, This is a JDK code review request for a pair of Full Debug Symbols gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10 corrupts the SUNW_* sections on objects. This has caused dtrace test failures and Monitoring & Management test failures. The gobjcopy utility crashes due to empty sections with the SHF_ALLOC flagset on Solaris X64 objects. This causes build failures. There are two new temporary work around tools: add_gnu_debuglink - adds the ".gnu_debuglink" section to an ELF object without corrupting the other sections in the object. fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty sections in ELF objects. These temporary work arounds are only needed until the proper Solaris 10 Update 6 patches are made available. The two patches are independent of one another which is why there are two separate temporary work arounds. However, we're putting the temporary work arounds in place because the 7u6 project window is closing fast. Here is the webrev URL for the JDK8-T&L version: http://cr.openjdk.java.net/~dcubed/fds_revamp/7170449-webrev/0/ This fix will also be backported to 7u6-T&L and I expect the changes to virtually identical. Thanks, in advance, for any reviews! Dan From daniel.daugherty at oracle.com Wed May 23 19:59:28 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 23 May 2012 13:59:28 -0600 Subject: code review for second hotspot FDS gobjcopy work around (7165598) Message-ID: <4FBD41A0.4080408@oracle.com> Greetings, This is a hotspot code review request for the second of a pair of Full Debug Symbols gobjcopy work arounds on Solaris. The first hotspot FDS gobjcopy work around was reviewed using bug 7165060 and that fixed the dtrace test failures. The gobjcopy utility also crashes due to empty sections with the SHF_ALLOC flagset on Solaris X64 objects. This causes build failures. The first new temporary work around tool is add_gnu_debuglink and it was added by 7165060.The second new temporary work around tool is: fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty sections in ELF objects. These temporary work arounds are only needed until the proper Solaris 10 Update 6 patches are made available. The two patches are independent of one another which is why there are two separate temporary work arounds. However, we're putting the temporary work arounds in place because the 7u6/HSX-23.2 project window is closing fast. Here is the webrev URL for the HSX-24 version: http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/ This fix will also be backported to 7u6/HSX-23.2 and I expect the changes to virtually identical. Thanks, in advance, for any reviews! Dan From david.katleman at oracle.com Wed May 23 22:36:20 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 23 May 2012 22:36:20 +0000 Subject: hg: jdk8/build: Added tag jdk8-b39 for changeset 8927dd68aee3 Message-ID: <20120523223620.84E00474AA@hg.openjdk.java.net> Changeset: a2b2d435f1d2 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/a2b2d435f1d2 Added tag jdk8-b39 for changeset 8927dd68aee3 ! .hgtags From david.katleman at oracle.com Wed May 23 22:36:25 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 23 May 2012 22:36:25 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b39 for changeset 785af00e2827 Message-ID: <20120523223627.64BCC474AB@hg.openjdk.java.net> Changeset: 56d030e5035f Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/56d030e5035f Added tag jdk8-b39 for changeset 785af00e2827 ! .hgtags From david.katleman at oracle.com Wed May 23 22:38:42 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 23 May 2012 22:38:42 +0000 Subject: hg: jdk8/build/hotspot: 15 new changesets Message-ID: <20120523223914.80C33474AC@hg.openjdk.java.net> Changeset: 26423ef693ac Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/26423ef693ac Added tag jdk8-b39 for changeset 96a403721094 ! .hgtags Changeset: 56d1af561395 Author: amurillo Date: 2012-05-11 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/56d1af561395 7168247: new hotspot build - hs24-b11 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 35e504cb49a6 Author: collins Date: 2012-05-11 11:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/35e504cb49a6 7167625: Adjustments for SE-Embedded build process Summary: Simple change to the SE-Embedded build rules that should not affect any other OpenJDK users. Reviewed-by: kvn, dholmes ! make/linux/makefiles/vm.make ! src/share/vm/runtime/arguments.cpp Changeset: fada85d11d92 Author: jprovino Date: 2012-05-16 13:33 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fada85d11d92 Merge Changeset: 8f972594effc Author: kvn Date: 2012-05-14 09:36 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8f972594effc 6924259: Remove String.count/String.offset Summary: Allow a version of String class that doesn't have count and offset fields. Reviewed-by: never, coleenp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/memory/dump.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/opto/stringopts.hpp Changeset: de0cc3dd9f10 Author: kvn Date: 2012-05-17 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/de0cc3dd9f10 Merge Changeset: 3a22b77e755a Author: brutisso Date: 2012-05-14 17:32 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3a22b77e755a 7161545: G1: Minor cleanups to the G1 logging Summary: Rename "to-space-overflow" to "to-space-exhausted", Introduce one decimal point in the size format, Add Sum to the aggregate and re-order the entries, Add number of GC workers to the log output Reviewed-by: johnc, jwilhelm ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 78a1b285cda8 Author: mikael Date: 2012-05-15 00:56 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/78a1b285cda8 7158457: division by zero in adaptiveweightedaverage Summary: Add ceiling to AdaptiveWeightedAverage Reviewed-by: ysr, iveresov ! src/share/vm/gc_implementation/shared/gcUtil.cpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp Changeset: 33e366609904 Author: johnc Date: 2012-05-14 21:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/33e366609904 Merge Changeset: 1096fc5a52eb Author: johnc Date: 2012-05-15 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1096fc5a52eb 7168294: G1: Some Full GCs incorrectly report GC cause as "No GC" Summary: GC cause was not being set by the VM_G1CollectForAllocation VM operation. Reviewed-by: jmasa, ysr, brutisso ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp Changeset: cdfa5139bd58 Author: brutisso Date: 2012-05-15 22:26 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cdfa5139bd58 7169056: Add gigabyte unit to proper_unit_for_byte_size() and byte_size_in_proper_unit() Reviewed-by: jwilhelm, johnc, dholmes ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 9d679effd28c Author: brutisso Date: 2012-05-15 10:25 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9d679effd28c 7166894: Add gc cause to GC logging for all collectors Reviewed-by: mgerdin, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_interface/gcCause.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.hpp Changeset: cdeda3fd141e Author: jcoomes Date: 2012-05-18 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cdeda3fd141e Merge ! src/share/vm/runtime/arguments.cpp Changeset: 14b0e07ab9a6 Author: amurillo Date: 2012-05-18 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/14b0e07ab9a6 Merge Changeset: ff9decc8235d Author: amurillo Date: 2012-05-18 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ff9decc8235d Added tag hs24-b11 for changeset 14b0e07ab9a6 ! .hgtags From david.katleman at oracle.com Wed May 23 22:40:58 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 23 May 2012 22:40:58 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b39 for changeset f95fdbe525c8 Message-ID: <20120523224102.DD6AF474AD@hg.openjdk.java.net> Changeset: 9ecfdbd6aed4 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/9ecfdbd6aed4 Added tag jdk8-b39 for changeset f95fdbe525c8 ! .hgtags From david.katleman at oracle.com Wed May 23 22:41:09 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 23 May 2012 22:41:09 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b39 for changeset 7f6b44fd3034 Message-ID: <20120523224112.E2FE7474AE@hg.openjdk.java.net> Changeset: 09a0ddda03cb Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/09a0ddda03cb Added tag jdk8-b39 for changeset 7f6b44fd3034 ! .hgtags From david.katleman at oracle.com Wed May 23 22:42:14 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 23 May 2012 22:42:14 +0000 Subject: hg: jdk8/build/jdk: 71 new changesets Message-ID: <20120523225421.3D1C6474AF@hg.openjdk.java.net> Changeset: 47cd90bf0f66 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/47cd90bf0f66 Added tag jdk8-b39 for changeset b6f529117521 ! .hgtags Changeset: 7c4eed4b6c19 Author: bae Date: 2012-05-21 14:04 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7c4eed4b6c19 7124400: [macosx] CGraphicsDevice.getConfigurations() returns reference to member (does not copy configs) Reviewed-by: anthony, kizune ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! test/java/awt/GraphicsDevice/CloneConfigsTest.java Changeset: 416b3a498e71 Author: bae Date: 2012-05-21 14:53 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/416b3a498e71 7154088: [macosx] Regression: Component.createImage do not inherits component attributes Reviewed-by: art, kizune ! src/macosx/classes/sun/lwawt/LWComponentPeer.java Changeset: 1b90a0113359 Author: lana Date: 2012-05-21 11:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1b90a0113359 Merge Changeset: c31eeeda3ed1 Author: serb Date: 2012-05-03 18:29 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c31eeeda3ed1 7160623: [macosx] Editable TextArea/TextField are blocking GUI applications from exit Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java Changeset: a420895ee2c3 Author: leonidr Date: 2012-05-03 19:22 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a420895ee2c3 7124376: [macosx] Modal dialog lost focus Reviewed-by: anthony ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 95c8b63a3c47 Author: kizune Date: 2012-05-03 21:54 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/95c8b63a3c47 7148289: [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame Reviewed-by: leonidr ! src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/LWCToolkit.m Changeset: a714e2e2b257 Author: alexsch Date: 2012-05-04 13:15 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a714e2e2b257 7024963: Notepad demo: remove non-translatable resources from Notepad.properties file Reviewed-by: rupashka ! src/share/demo/jfc/Notepad/Notepad.java ! src/share/demo/jfc/Notepad/resources/Notepad.properties + src/share/demo/jfc/Notepad/resources/system.properties Changeset: 4cc873e28c78 Author: bagiras Date: 2012-05-04 18:42 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4cc873e28c78 7146237: closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html failed since 1.8.0b19 Reviewed-by: art, anthony ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/javax/swing/JComponent.java Changeset: 0feee4541f67 Author: serb Date: 2012-05-04 21:25 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0feee4541f67 7147055: [macosx] Cursors are changing over a blocked window; also blinking Reviewed-by: art, kizune ! src/macosx/classes/sun/lwawt/LWCursorManager.java Changeset: 912e666b4e1d Author: serb Date: 2012-05-10 20:05 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/912e666b4e1d 7080109: Dialog.show() lacks doPrivileged() to access system event queue Reviewed-by: art, anthony ! src/share/classes/java/awt/Dialog.java + test/java/awt/Dialog/ModalDialogPermission/ModalDialogPermission.java + test/java/awt/Dialog/ModalDialogPermission/java.policy Changeset: 18842bb6676a Author: lana Date: 2012-05-10 11:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/18842bb6676a Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 4f39a13e74c6 Author: anthony Date: 2012-05-11 16:11 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4f39a13e74c6 7166437: [macosx] Support for Window.Type.UTILITY on the Mac Summary: Apply the native UTILITY style for UTILITY Java windows Reviewed-by: art ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: 689c0cd214e8 Author: anthony Date: 2012-05-11 20:37 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/689c0cd214e8 7149062: [macosx] dock menu don't show available frames Summary: Inherit from either NSWindow for normal windows or NSPanel for utility windows Reviewed-by: skovatch, swingler ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 3b8635e357e9 Author: alexsch Date: 2012-05-12 12:01 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3b8635e357e9 7024965: Stylepad demo: remove non-translatable resources from Stylepad.properties file Reviewed-by: alexp ! src/share/demo/jfc/Notepad/Notepad.java + src/share/demo/jfc/Notepad/resources/NotepadSystem.properties - src/share/demo/jfc/Notepad/resources/system.properties Changeset: cc8d1cc533bf Author: alexp Date: 2012-05-12 17:46 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cc8d1cc533bf 7149005: [macosx] Java Control Panel's UI controls are distorted when draging scroll bar. Reviewed-by: serb ! src/macosx/classes/com/apple/laf/AquaButtonLabeledUI.java Changeset: 69301efaac91 Author: ant Date: 2012-05-12 18:50 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/69301efaac91 7110683: Issues with some KeyboardFocusManager method Reviewed-by: ahgross ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/Window.java Changeset: 28ec5b811aa2 Author: dcherepanov Date: 2012-05-15 15:04 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/28ec5b811aa2 7168550: [macosx] duplicate OGL context state changes related to vertex cache Reviewed-by: bae, swingler ! src/macosx/native/sun/java2d/opengl/CGLSurfaceData.m ! src/share/native/sun/java2d/opengl/OGLContext.h ! src/share/native/sun/java2d/opengl/OGLTextRenderer.c ! src/share/native/sun/java2d/opengl/OGLVertexCache.c ! src/share/native/sun/java2d/opengl/OGLVertexCache.h Changeset: cad0bb1a9bdb Author: dcherepanov Date: 2012-05-16 13:15 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cad0bb1a9bdb 7124337: [macosx] FileDialog fails to select multiple files Reviewed-by: anthony, swingler ! src/macosx/classes/sun/lwawt/macosx/CFileDialog.java ! src/macosx/native/sun/awt/CFileDialog.h ! src/macosx/native/sun/awt/CFileDialog.m ! src/share/classes/java/awt/FileDialog.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java Changeset: 7c0b390ab5f9 Author: anthony Date: 2012-05-16 14:28 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7c0b390ab5f9 7168851: [macosx] Netbeans crashes in CImage.nativeCreateNSImageFromArray Summary: Eliminate unnecessary -release call Reviewed-by: dcherepanov ! src/macosx/native/sun/awt/CImage.m Changeset: 3c819d638e36 Author: alexsch Date: 2012-05-16 16:27 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3c819d638e36 7169226: NLS: Please change the mnemonic assignment system for windows and motif properties Reviewed-by: rupashka ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ja.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ko.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_TW.properties Changeset: 19edcc438203 Author: alexsch Date: 2012-05-16 18:11 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/19edcc438203 7158928: [macosx] NLS: Please change the mnemonic assignment system Reviewed-by: rupashka, serb ! make/com/apple/osxui/Makefile ! make/common/internal/Resources.gmk ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/com/apple/laf/resources/aqua.properties Changeset: 731ee59c6ba2 Author: alexsch Date: 2012-05-17 14:27 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/731ee59c6ba2 7148281: [macosx] JTabbedPane tabs with HTML text do not render correctly Reviewed-by: kizune ! src/macosx/classes/com/apple/laf/AquaTabbedPaneUI.java Changeset: f9217bd87199 Author: rupashka Date: 2012-05-17 15:41 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f9217bd87199 7166322: closed/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java failed since 1.8.0b36 Reviewed-by: alexsch + test/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java Changeset: c00d6508afce Author: ant Date: 2012-05-17 21:27 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c00d6508afce 7142565: [macosx] Many special keys processed twice in text fields Summary: forward port from 7u4 Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTView.m Changeset: 17c5e1a12965 Author: ant Date: 2012-05-17 21:31 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/17c5e1a12965 7154072: [macosx] swallowing key events Summary: forward posrt from 7u4 Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTView.m Changeset: ef77fa799b34 Author: ant Date: 2012-05-17 21:48 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ef77fa799b34 7125044: [macosx] Test failure because Component.transferFocus() works differently in applet and application. Summary: forward port from 7u4 Reviewed-by: art ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/Window.java ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/UIManager.java ! src/share/classes/sun/awt/SunToolkit.java + test/java/awt/Focus/FocusTraversalPolicy/InitialFTP.java + test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_AWT.java + test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_Swing.java + test/java/awt/event/KeyEvent/SwallowKeyEvents/SwallowKeyEvents.java Changeset: 5976b5848554 Author: ant Date: 2012-05-17 22:10 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5976b5848554 7145768: [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest Summary: forward port from 7u4 Reviewed-by: art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java Changeset: 1d75ff45586e Author: ant Date: 2012-05-17 22:21 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1d75ff45586e 7145827: [macosx] JCK failure in b11: FocusableWindow3 Summary: forward posrt from 7u4 Reviewed-by: art ! src/macosx/classes/sun/lwawt/LWWindowPeer.java Changeset: 2eca75e0a063 Author: dcherepanov Date: 2012-05-18 19:39 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2eca75e0a063 7156191: [macosx] Can't type into applet demos in Pivot Reviewed-by: art ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: 1ee12bca4823 Author: rupashka Date: 2012-05-21 18:55 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1ee12bca4823 7168144: No appropriate CCC request for changes introduced by 7154030 Reviewed-by: alexsch ! src/share/classes/javax/swing/JComponent.java Changeset: 967b38bfd5c1 Author: ant Date: 2012-05-22 01:12 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/967b38bfd5c1 7170427: setGlobalCurrentFocusCycleRoot unexpectedly throws SecurityException Reviewed-by: art ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/KeyboardFocusManager.java Changeset: 5b2095d7a60b Author: lana Date: 2012-05-21 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5b2095d7a60b Merge ! src/macosx/classes/sun/lwawt/LWComponentPeer.java Changeset: bb2cefc89bc0 Author: forax Date: 2012-05-02 20:01 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bb2cefc89bc0 7165102: Only run assertion on Integer autoboxing cache size once Reviewed-by: darcy, alanb ! src/share/classes/java/lang/Integer.java Changeset: 531ebfd8eb65 Author: jgish Date: 2012-05-02 21:46 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/531ebfd8eb65 7160714: Strange or obsolete @see tags in some exception java.util javadoc Reviewed-by: mduigou, dholmes, alanb ! src/share/classes/java/util/NoSuchElementException.java Changeset: 4580652d9828 Author: lancea Date: 2012-05-04 16:00 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4580652d9828 7166598: FilteredRowSetImpl can result in Invalid Cursor Position Reviewed-by: lancea Contributed-by: Knut Anders Hatlen ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java Changeset: 41d3f7509e00 Author: xuelei Date: 2012-05-04 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/41d3f7509e00 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites Reviewed-by: weijun ! src/share/classes/sun/security/ssl/SSLContextImpl.java Changeset: 62557a1336c0 Author: zhouyx Date: 2012-05-07 16:43 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/62557a1336c0 7166048: Remove the embeded epoll data structure. Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/EPollArrayWrapper.c Changeset: b26c04717735 Author: robm Date: 2012-05-07 13:34 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b26c04717735 7166687: InetAddress.getLocalHost().getHostName() returns FQDN Reviewed-by: chegar ! src/solaris/native/java/net/Inet6AddressImpl.c Changeset: 48513d156965 Author: dholmes Date: 2012-05-08 02:59 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/48513d156965 7103570: AtomicIntegerFieldUpdater does not work when SecurityManager is installed Summary: Perform class.getField inside a doPrivileged block Reviewed-by: chegar, psandoz ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java + test/java/util/concurrent/atomic/AtomicUpdaters.java Changeset: af209a223b6b Author: sherman Date: 2012-05-08 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/af209a223b6b 7014640: To add a metachar \R for line ending and character classes for vertical/horizontal ws \v \V \h \H Summary: added propsoed constructs Reviewed-by: alanb ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: 1ece20885be4 Author: sherman Date: 2012-05-08 11:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1ece20885be4 7157656: (zipfs) SeekableByteChannel to entry in zip file always reports its position as 0 Summary: updated SeekableByteChannel.read() to count the bytes read correctly Reviewed-by: sherman Contributed-by: paul.sandoz at oracle.com ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh Changeset: fbf98cbd2e6b Author: xuelei Date: 2012-05-08 17:56 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fbf98cbd2e6b 7167092: Need to put the return clause in the synchronized block Summary: a regression fix for bug 7153184 Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/SSLContextImpl.java Changeset: 0f63f3390ac9 Author: xuelei Date: 2012-05-08 18:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0f63f3390ac9 7166570: JSSE certificate validation has started to fail for certificate chains Reviewed-by: wetmore ! src/share/classes/sun/security/validator/SimpleValidator.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/BasicConstraints.java Changeset: abb63b7357a1 Author: luchsh Date: 2012-05-09 11:19 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/abb63b7357a1 7165722: Invalid path in MemoryMonitor demo's README.txt Reviewed-by: alanb, sla ! src/share/demo/management/MemoryMonitor/README.txt Changeset: 5e8caf6984f5 Author: ksrini Date: 2012-05-09 07:28 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5e8caf6984f5 7166955: (pack200) JNI_GetCreatedJavaVMs needs additional checking Reviewed-by: alanb, dholmes, ksrini Contributed-by: youdwei at linux.vnet.ibm.com ! src/share/native/com/sun/java/util/jar/pack/jni.cpp Changeset: 59121a4c71c6 Author: khazra Date: 2012-05-09 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/59121a4c71c6 7165118: (prefs) AbstractPreferences.remove(null) does not throw NPE Summary: Insert null argument check in AbstractPreferences.remove() Reviewed-by: dholmes, chegar, alanb ! src/share/classes/java/util/prefs/AbstractPreferences.java ! test/java/util/prefs/RemoveNullKeyCheck.java Changeset: 6438f1277df6 Author: wetmore Date: 2012-05-09 16:33 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6438f1277df6 7167362: SecureRandom.init should be converted, amendment to 7084245 Reviewed-by: sherman ! src/share/classes/sun/security/provider/SecureRandom.java Changeset: 5152c832745a Author: khazra Date: 2012-05-09 16:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5152c832745a 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking Summary: Set localAddress only when connection is established Reviewed-by: alanb ! src/share/classes/sun/nio/ch/SocketChannelImpl.java Changeset: fdf5e15293e6 Author: coffeys Date: 2012-05-10 10:45 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fdf5e15293e6 7163470: Build fails if javax.crypto src files not present Reviewed-by: valeriep ! make/com/oracle/security/ucrypto/Makefile ! make/common/shared/Defs-java.gmk ! make/sun/security/ec/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! makefiles/com/oracle/security/ucrypto/Makefile ! makefiles/common/shared/Defs-java.gmk ! makefiles/sun/security/ec/Makefile ! makefiles/sun/security/mscapi/Makefile ! makefiles/sun/security/pkcs11/Makefile Changeset: 3e3017eba8ac Author: valeriep Date: 2012-05-08 17:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3e3017eba8ac 4963723: Implement SHA-224 Summary: Add support for SHA-224, SHA224withRSA, SHA224withECDSA, HmacSHA224 and OAEPwithSHA-224AndMGF1Padding. Reviewed-by: vinnie ! src/share/classes/com/sun/crypto/provider/HmacCore.java ! src/share/classes/com/sun/crypto/provider/HmacMD5.java ! src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java ! src/share/classes/com/sun/crypto/provider/HmacSHA1.java ! src/share/classes/com/sun/crypto/provider/KeyGeneratorCore.java ! src/share/classes/com/sun/crypto/provider/OAEPParameters.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java ! src/share/classes/java/security/spec/MGF1ParameterSpec.java ! src/share/classes/java/security/spec/PSSParameterSpec.java ! src/share/classes/sun/security/ec/ECDSASignature.java ! src/share/classes/sun/security/ec/SunECEntries.java ! src/share/classes/sun/security/pkcs11/P11Digest.java ! src/share/classes/sun/security/pkcs11/P11Mac.java ! src/share/classes/sun/security/pkcs11/P11Signature.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java ! src/share/classes/sun/security/pkcs11/wrapper/Functions.java ! src/share/classes/sun/security/provider/DigestBase.java ! src/share/classes/sun/security/provider/MD2.java ! src/share/classes/sun/security/provider/MD4.java ! src/share/classes/sun/security/provider/MD5.java ! src/share/classes/sun/security/provider/SHA.java ! src/share/classes/sun/security/provider/SHA2.java ! src/share/classes/sun/security/provider/SHA5.java ! src/share/classes/sun/security/provider/SunEntries.java ! src/share/classes/sun/security/rsa/RSASignature.java ! src/share/classes/sun/security/rsa/SunRsaSignEntries.java ! src/share/classes/sun/security/x509/AlgorithmId.java ! src/windows/classes/sun/security/mscapi/RSASignature.java ! src/windows/classes/sun/security/mscapi/SunMSCAPI.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEP.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEPParameterSpec.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEPWithParams.java ! test/com/sun/crypto/provider/KeyGenerator/Test4628062.java ! test/com/sun/crypto/provider/Mac/MacClone.java ! test/com/sun/crypto/provider/Mac/MacKAT.java ! test/sun/security/mscapi/SignUsingNONEwithRSA.java ! test/sun/security/mscapi/SignUsingSHA2withRSA.java ! test/sun/security/pkcs11/MessageDigest/DigestKAT.java ! test/sun/security/pkcs11/MessageDigest/TestCloning.java ! test/sun/security/pkcs11/Signature/TestRSAKeyLength.java ! test/sun/security/pkcs11/ec/TestCurves.java ! test/sun/security/pkcs11/rsa/TestKeyPairGenerator.java ! test/sun/security/pkcs11/rsa/TestSignatures.java ! test/sun/security/provider/MessageDigest/DigestKAT.java ! test/sun/security/provider/MessageDigest/Offsets.java ! test/sun/security/provider/MessageDigest/TestSHAClone.java ! test/sun/security/rsa/TestKeyPairGenerator.java ! test/sun/security/rsa/TestSignatures.java Changeset: dfce31760a2f Author: valeriep Date: 2012-05-08 18:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dfce31760a2f Merge Changeset: 9f8210f23773 Author: valeriep Date: 2012-05-10 11:19 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9f8210f23773 Merge Changeset: c5a07e3dca63 Author: youdwei Date: 2012-05-11 16:20 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c5a07e3dca63 7163874: InetAddress.isReachable should support pinging 0.0.0.0 Reviewed-by: alanb, chegar ! src/share/native/java/net/net_util.h ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/net_util_md.c + test/java/net/Inet4Address/PingThis.java Changeset: 3e83229a3779 Author: coffeys Date: 2012-05-11 10:09 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3e83229a3779 7167359: (tz) SEGV on solaris if TZ variable not set Reviewed-by: okutsu ! src/solaris/native/java/util/TimeZone_md.c Changeset: 944676ef3c58 Author: mduigou Date: 2012-05-11 11:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/944676ef3c58 7071826: Avoid benign race condition in initialization of UUID Summary: Avoids mostly benign but sometimes expensive race condition on initialization of UUID.numberGenerator which is used by UUID.randomUUID() Reviewed-by: alanb, chegar ! src/share/classes/java/util/UUID.java ! test/java/util/UUID/UUIDTest.java Changeset: 85d7677a75bf Author: lana Date: 2012-05-11 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/85d7677a75bf Merge Changeset: f131d4361faf Author: olagneau Date: 2012-05-11 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f131d4361faf 7144861: speed up RMI activation tests Reviewed-by: alanb, smarks, dholmes, dmocek ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/testlibrary/ActivationLibrary.java ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/RMID.java ! test/java/rmi/testlibrary/StreamPipe.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java Changeset: df3152beef2f Author: xuelei Date: 2012-05-14 07:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/df3152beef2f 7167988: PKIX CertPathBuilder in reverse mode doesn't work if more than one trust anchor is specified Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java + test/sun/security/provider/certpath/ReverseBuilder/ReverseBuild.java Changeset: df33f5f750ec Author: dsamersoff Date: 2012-05-15 16:46 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/df33f5f750ec 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario Reviewed-by: dholmes, sla Contributed-by: Deven You ! src/share/classes/sun/management/Agent.java + test/sun/management/AgentCMETest.java Changeset: 9a18e318f95a Author: khazra Date: 2012-05-15 11:51 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9a18e318f95a 7164636: (prefs) Cleanup src/macosx/classes/java/util/prefs Summary: Remove rawtype usages and other code cleanup Reviewed-by: chegar, briangoetz ! src/macosx/classes/java/util/prefs/MacOSXPreferences.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFactory.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java Changeset: 332bebb463d1 Author: alanb Date: 2012-05-16 12:43 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/332bebb463d1 7168505: (bf) MappedByteBuffer.load does not load buffer's content into memory Reviewed-by: mduigou, forax ! src/share/classes/java/nio/MappedByteBuffer.java Changeset: ce165aa48dcb Author: dcubed Date: 2012-05-17 06:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ce165aa48dcb 7168520: No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 Summary: ZIP libjsig.debuginfo links into libjsig.diz files since aurora doesn't like dangling symlinks Reviewed-by: katleman ! make/java/redist/Makefile Changeset: 178c480998b1 Author: robm Date: 2012-05-17 22:42 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/178c480998b1 7168110: Misleading jstack error message Reviewed-by: alanb, dsamersoff ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c Changeset: 9fe6ebbe5895 Author: xuelei Date: 2012-05-17 21:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9fe6ebbe5895 7145960: sun/security/mscapi/ShortRSAKey1024.sh failing on windows Reviewed-by: vinnie, wetmore ! test/sun/security/mscapi/ShortRSAKey1024.sh ! test/sun/security/mscapi/ShortRSAKey512.sh ! test/sun/security/mscapi/ShortRSAKey768.sh Changeset: af1030be726a Author: valeriep Date: 2012-05-18 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/af1030be726a 7169496: Problem with the SHA-224 support for SunMSCAPI provider Summary: Remove SHA224withRSA signature from SunMSCAPI provider due to lack of windows support. Reviewed-by: vinnie ! src/windows/classes/sun/security/mscapi/RSASignature.java ! src/windows/classes/sun/security/mscapi/SunMSCAPI.java ! test/sun/security/mscapi/SignUsingNONEwithRSA.java ! test/sun/security/mscapi/SignUsingSHA2withRSA.java Changeset: 72af24348b2b Author: weijun Date: 2012-05-21 15:40 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/72af24348b2b 7170308: timing error in the krb5 test SSL.java Reviewed-by: xuelei ! test/sun/security/krb5/auto/SSL.java Changeset: 9cb304dd71d4 Author: alanb Date: 2012-05-21 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9cb304dd71d4 7170203: TEST_BUG: test/java/nio/MappedByteBuffer/Truncate.java failing intermittently Reviewed-by: chegar ! test/java/nio/MappedByteBuffer/Truncate.java Changeset: f109feb13698 Author: ksrini Date: 2012-05-21 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f109feb13698 7170087: tools/launcher/Arrghs.java test has wrong bugID for 7151434 Reviewed-by: ohair ! test/tools/launcher/Arrrghs.java Changeset: 0a1ef7e07e01 Author: sla Date: 2012-05-21 19:28 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0a1ef7e07e01 7167157: jcmd command file parsing does not respect the "stop" command Reviewed-by: alanb, dsamersoff, nloodin ! src/share/classes/sun/tools/jcmd/JCmd.java Changeset: b88fc3359dc7 Author: lana Date: 2012-05-21 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b88fc3359dc7 Merge From david.katleman at oracle.com Wed May 23 22:56:53 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 23 May 2012 22:56:53 +0000 Subject: hg: jdk8/build/langtools: 6 new changesets Message-ID: <20120523225708.1B08B474B0@hg.openjdk.java.net> Changeset: 8b869afd2eb4 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8b869afd2eb4 Added tag jdk8-b39 for changeset a9f547c218d9 ! .hgtags Changeset: d10db3576c08 Author: ksrini Date: 2012-05-04 07:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d10db3576c08 7166010: (javac) JavacMessager incorrectly restores log source file Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java + test/tools/javac/processing/messager/MessagerDiags.java Changeset: 833bab705918 Author: ksrini Date: 2012-05-10 12:32 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/833bab705918 7159445: (javac) emits inaccurate diagnostics for enhanced for-loops Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/ForeachBadInitialization.java ! test/tools/javac/parser/JavacParserTest.java Changeset: 96a8278e323c Author: sundar Date: 2012-05-11 20:06 +0530 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/96a8278e323c 7166990: java/compiler Inherited interfaces using generics sometimes looses the generic type Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/TryWithResources/T7164542.java Changeset: 885806e74240 Author: lana Date: 2012-05-11 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/885806e74240 Merge Changeset: 86e0dad6aadf Author: lana Date: 2012-05-21 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/86e0dad6aadf Merge From serguei.spitsyn at oracle.com Thu May 24 07:50:00 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 24 May 2012 00:50:00 -0700 Subject: code review for JDK FDS gobjcopy work arounds (7170449) In-Reply-To: <4FBD3F7A.4030501@oracle.com> References: <4FBD3F7A.4030501@oracle.com> Message-ID: <4FBDE828.60303@oracle.com> Dan, I've reviewed the fixes as did not notice any problems. Looks good. Thanks, Serguei On 5/23/12 12:50 PM, Daniel D. Daugherty wrote: > Greetings, > > This is a JDK code review request for a pair of Full Debug Symbols > gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10 > corrupts the SUNW_* sections on objects. This has caused dtrace test > failures and Monitoring & Management test failures. The gobjcopy > utility crashes due to empty sections with the SHF_ALLOC flagset on > Solaris X64 objects. This causes build failures. > > There are two new temporary work around tools: > > add_gnu_debuglink - adds the ".gnu_debuglink" section to an ELF > object without corrupting the other sections in the object. > > fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty > sections in ELF objects. > > These temporary work arounds are only needed until the proper > Solaris 10 Update 6 patches are made available. The two patches > are independent of one another which is why there are two > separate temporary work arounds. However, we're putting the > temporary work arounds in place because the 7u6 project window > is closing fast. > > Here is the webrev URL for the JDK8-T&L version: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7170449-webrev/0/ > > This fix will also be backported to 7u6-T&L and I expect the > changes to virtually identical. > > Thanks, in advance, for any reviews! > > Dan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From serguei.spitsyn at oracle.com Thu May 24 07:52:25 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 24 May 2012 00:52:25 -0700 Subject: code review for second hotspot FDS gobjcopy work around (7165598) In-Reply-To: <4FBD41A0.4080408@oracle.com> References: <4FBD41A0.4080408@oracle.com> Message-ID: <4FBDE8B9.2090406@oracle.com> I do not see any issues with that webrev. Looks good. Thanks, Serguei On 5/23/12 12:59 PM, Daniel D. Daugherty wrote: > Greetings, > > This is a hotspot code review request for the second of a pair of > Full Debug Symbols gobjcopy work arounds on Solaris. The first > hotspot FDS gobjcopy work around was reviewed using bug 7165060 > and that fixed the dtrace test failures. > > The gobjcopy utility also crashes due to empty sections with the > SHF_ALLOC flagset on Solaris X64 objects. This causes build > failures. > > The first new temporary work around tool is add_gnu_debuglink > and it was added by 7165060.The second new temporary work around > tool is: > > fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty > sections in ELF objects. > > These temporary work arounds are only needed until the proper > Solaris 10 Update 6 patches are made available. The two patches > are independent of one another which is why there are two > separate temporary work arounds. However, we're putting the > temporary work arounds in place because the 7u6/HSX-23.2 project > window is closing fast. > > Here is the webrev URL for the HSX-24 version: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/ > > This fix will also be backported to 7u6/HSX-23.2 and I expect the > changes to virtually identical. > > Thanks, in advance, for any reviews! > > Dan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From daniel.daugherty at oracle.com Thu May 24 11:40:12 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 24 May 2012 05:40:12 -0600 Subject: code review for JDK FDS gobjcopy work arounds (7170449) In-Reply-To: <4FBDE828.60303@oracle.com> References: <4FBD3F7A.4030501@oracle.com> <4FBDE828.60303@oracle.com> Message-ID: <4FBE1E1C.7080508@oracle.com> Thanks Serguei! Dan On 5/24/12 1:50 AM, serguei.spitsyn at oracle.com wrote: > Dan, > > I've reviewed the fixes as did not notice any problems. > Looks good. > > Thanks, > Serguei > > On 5/23/12 12:50 PM, Daniel D. Daugherty wrote: >> Greetings, >> >> This is a JDK code review request for a pair of Full Debug Symbols >> gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10 >> corrupts the SUNW_* sections on objects. This has caused dtrace test >> failures and Monitoring & Management test failures. The gobjcopy >> utility crashes due to empty sections with the SHF_ALLOC flagset on >> Solaris X64 objects. This causes build failures. >> >> There are two new temporary work around tools: >> >> add_gnu_debuglink - adds the ".gnu_debuglink" section to an ELF >> object without corrupting the other sections in the object. >> >> fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty >> sections in ELF objects. >> >> These temporary work arounds are only needed until the proper >> Solaris 10 Update 6 patches are made available. The two patches >> are independent of one another which is why there are two >> separate temporary work arounds. However, we're putting the >> temporary work arounds in place because the 7u6 project window >> is closing fast. >> >> Here is the webrev URL for the JDK8-T&L version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7170449-webrev/0/ >> >> This fix will also be backported to 7u6-T&L and I expect the >> changes to virtually identical. >> >> Thanks, in advance, for any reviews! >> >> Dan >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From daniel.daugherty at oracle.com Thu May 24 13:04:45 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 24 May 2012 07:04:45 -0600 Subject: code review for second hotspot FDS gobjcopy work around (7165598) In-Reply-To: <4FBDE8B9.2090406@oracle.com> References: <4FBD41A0.4080408@oracle.com> <4FBDE8B9.2090406@oracle.com> Message-ID: <4FBE31ED.3040101@oracle.com> Thanks Serguei! Dan On 5/24/12 1:52 AM, serguei.spitsyn at oracle.com wrote: > I do not see any issues with that webrev. > Looks good. > > Thanks, > Serguei > > On 5/23/12 12:59 PM, Daniel D. Daugherty wrote: >> Greetings, >> >> This is a hotspot code review request for the second of a pair of >> Full Debug Symbols gobjcopy work arounds on Solaris. The first >> hotspot FDS gobjcopy work around was reviewed using bug 7165060 >> and that fixed the dtrace test failures. >> >> The gobjcopy utility also crashes due to empty sections with the >> SHF_ALLOC flagset on Solaris X64 objects. This causes build >> failures. >> >> The first new temporary work around tool is add_gnu_debuglink >> and it was added by 7165060.The second new temporary work around >> tool is: >> >> fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty >> sections in ELF objects. >> >> These temporary work arounds are only needed until the proper >> Solaris 10 Update 6 patches are made available. The two patches >> are independent of one another which is why there are two >> separate temporary work arounds. However, we're putting the >> temporary work arounds in place because the 7u6/HSX-23.2 project >> window is closing fast. >> >> Here is the webrev URL for the HSX-24 version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/ >> >> This fix will also be backported to 7u6/HSX-23.2 and I expect the >> changes to virtually identical. >> >> Thanks, in advance, for any reviews! >> >> Dan >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From karen.kinnear at oracle.com Thu May 24 14:28:46 2012 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 24 May 2012 10:28:46 -0400 Subject: code review for second hotspot FDS gobjcopy work around (7165598) In-Reply-To: <4FBD41A0.4080408@oracle.com> References: <4FBD41A0.4080408@oracle.com> Message-ID: <780948D8-5796-4052-932E-D5AA099250A0@oracle.com> Dan, Code looks good. Thank you for the work-around. So is this HDR_FLAGS workaround also needed in all the other jdk repositories? And I assume the windows/makefiles/defs.make change is because you determined that the failing tests actually pre-dated the zipped debuginfo. Did you find the root cause for that yet, or is that an orthogonal topic? And this also appears to have additional modifications for the earlier workaround add_gnu_debuglink. I has assumed in reviewing 7165060 that you only used that for makefiles that built with DOF sections, i.e. libjvm.so and that you had chosen not to use the simpler add_gnu_debuglink in all cases, even though it is generally less risky. Did you change your approach here? Your comment was changed from SUNW_DOF to SUNW_*. That makes sense to me. And are you also changing that for the other jdk repositories? thanks, Karen On May 23, 2012, at 3:59 PM, Daniel D. Daugherty wrote: > Greetings, > > This is a hotspot code review request for the second of a pair of > Full Debug Symbols gobjcopy work arounds on Solaris. The first > hotspot FDS gobjcopy work around was reviewed using bug 7165060 > and that fixed the dtrace test failures. > > The gobjcopy utility also crashes due to empty sections with the > SHF_ALLOC flagset on Solaris X64 objects. This causes build > failures. > > The first new temporary work around tool is add_gnu_debuglink > and it was added by 7165060.The second new temporary work around > tool is: > > fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty > sections in ELF objects. > > These temporary work arounds are only needed until the proper > Solaris 10 Update 6 patches are made available. The two patches > are independent of one another which is why there are two > separate temporary work arounds. However, we're putting the > temporary work arounds in place because the 7u6/HSX-23.2 project > window is closing fast. > > Here is the webrev URL for the HSX-24 version: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/ > > This fix will also be backported to 7u6/HSX-23.2 and I expect the > changes to virtually identical. > > Thanks, in advance, for any reviews! > > Dan > > From daniel.daugherty at oracle.com Thu May 24 16:01:55 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 24 May 2012 10:01:55 -0600 Subject: code review for second hotspot FDS gobjcopy work around (7165598) In-Reply-To: <780948D8-5796-4052-932E-D5AA099250A0@oracle.com> References: <4FBD41A0.4080408@oracle.com> <780948D8-5796-4052-932E-D5AA099250A0@oracle.com> Message-ID: <4FBE5B73.5090702@oracle.com> On 5/24/12 8:28 AM, Karen Kinnear wrote: > Dan, > > Code looks good. Thanks! > Thank you for the work-around. > > So is this HDR_FLAGS workaround also needed in all the other jdk repositories? SHF_ALLOC flag? We know that gobjcopy crashes when running into empty ELF sections where the SHF_ALLOC flag is set. We have only seen the loader (ld) generate empty ELF sections with the SHF_ALLOC flag set when compiling for Solaris X64. However, it seems safer to me to always apply the work around when building on Solaris just to be sure. The fix_empty_sec_hdr_flags prints a diagnostic message when it modifies an ELF object so we can check build logs periodically to verify which Solaris builds are affected. > And I assume the windows/makefiles/defs.make change is because you determined > that the failing tests actually pre-dated the zipped debuginfo. Correct. ZIP'ing the .pdb and .map files was not the cause of library loading failures. > Did you find the root cause for that > yet, or is that an orthogonal topic? Evgeny's team found that several Windows machines were missing the msvcr71.dll library. That version of the MS runtime is needed by the affected testbase(s) (just VM/NSK I think, not sure). > And this also appears to have additional modifications for the earlier workaround add_gnu_debuglink. Yes, after getting hit by the M&M test failures on Solaris 11, I decided to apply the add_gnu_debuglink work around to every FDS use of gobjcopy. > I has assumed in reviewing 7165060 that you only used that for makefiles that built with DOF sections, > i.e. libjvm.so and that you had chosen not to use the simpler add_gnu_debuglink in all cases, even though > it is generally less risky. Did you change your approach here? Yes, I've changed approaches due to the unexpected M&M failures. I was originally balancing the risk of changing more Makefiles to use the add_gnu_debuglink work around versus the risk that gobjcopy would screw up some other ELF section in ways that we couldn't easily detect. In hindsight, I should have gone with using the add_gnu_debuglink because the changes that it makes to an ELF object are rather easy to verify as correct by comparing two elfdump output files. > Your comment was changed from SUNW_DOF to > SUNW_*. That makes sense to me. Yes, Dean's guess is that the SUNW_cap section is what the M&M tests were relying on and when gobjcopy munged it, the tests started to fail on Solaris 11. Interesting data points: the tests don't fail on Solaris 10 or on a recent Solaris 11 Update 1 build (I used jurassic for a quick test). So whatever gobjcopy did to the SUNW_cap section is properly handled by newer Solaris 11 versions... > And are you also changing that for > the other jdk repositories? Yes, please search for 7170449 in your InBox and you'll see that review thread. I would love to have your review there also. Dan > thanks, > Karen > > On May 23, 2012, at 3:59 PM, Daniel D. Daugherty wrote: > >> Greetings, >> >> This is a hotspot code review request for the second of a pair of >> Full Debug Symbols gobjcopy work arounds on Solaris. The first >> hotspot FDS gobjcopy work around was reviewed using bug 7165060 >> and that fixed the dtrace test failures. >> >> The gobjcopy utility also crashes due to empty sections with the >> SHF_ALLOC flagset on Solaris X64 objects. This causes build >> failures. >> >> The first new temporary work around tool is add_gnu_debuglink >> and it was added by 7165060.The second new temporary work around >> tool is: >> >> fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty >> sections in ELF objects. >> >> These temporary work arounds are only needed until the proper >> Solaris 10 Update 6 patches are made available. The two patches >> are independent of one another which is why there are two >> separate temporary work arounds. However, we're putting the >> temporary work arounds in place because the 7u6/HSX-23.2 project >> window is closing fast. >> >> Here is the webrev URL for the HSX-24 version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/ >> >> This fix will also be backported to 7u6/HSX-23.2 and I expect the >> changes to virtually identical. >> >> Thanks, in advance, for any reviews! >> >> Dan >> >> From karen.kinnear at oracle.com Thu May 24 16:33:22 2012 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 24 May 2012 12:33:22 -0400 Subject: code review for JDK FDS gobjcopy work arounds (7170449) In-Reply-To: <4FBD3F7A.4030501@oracle.com> References: <4FBD3F7A.4030501@oracle.com> Message-ID: Looks good. Thank you. thanks, Karen On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote: > Greetings, > > This is a JDK code review request for a pair of Full Debug Symbols > gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10 > corrupts the SUNW_* sections on objects. This has caused dtrace test > failures and Monitoring & Management test failures. The gobjcopy > utility crashes due to empty sections with the SHF_ALLOC flagset on > Solaris X64 objects. This causes build failures. > > There are two new temporary work around tools: > > add_gnu_debuglink - adds the ".gnu_debuglink" section to an ELF > object without corrupting the other sections in the object. > > fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty > sections in ELF objects. > > These temporary work arounds are only needed until the proper > Solaris 10 Update 6 patches are made available. The two patches > are independent of one another which is why there are two > separate temporary work arounds. However, we're putting the > temporary work arounds in place because the 7u6 project window > is closing fast. > > Here is the webrev URL for the JDK8-T&L version: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7170449-webrev/0/ > > This fix will also be backported to 7u6-T&L and I expect the > changes to virtually identical. > > Thanks, in advance, for any reviews! > > Dan > > From daniel.daugherty at oracle.com Thu May 24 16:49:22 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 24 May 2012 10:49:22 -0600 Subject: code review for JDK FDS gobjcopy work arounds (7170449) In-Reply-To: References: <4FBD3F7A.4030501@oracle.com> Message-ID: <4FBE6692.1050706@oracle.com> Thanks for the review! Dan On 5/24/12 10:33 AM, Karen Kinnear wrote: > Looks good. Thank you. > > thanks, > Karen > > On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote: > >> Greetings, >> >> This is a JDK code review request for a pair of Full Debug Symbols >> gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10 >> corrupts the SUNW_* sections on objects. This has caused dtrace test >> failures and Monitoring& Management test failures. The gobjcopy >> utility crashes due to empty sections with the SHF_ALLOC flagset on >> Solaris X64 objects. This causes build failures. >> >> There are two new temporary work around tools: >> >> add_gnu_debuglink - adds the ".gnu_debuglink" section to an ELF >> object without corrupting the other sections in the object. >> >> fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty >> sections in ELF objects. >> >> These temporary work arounds are only needed until the proper >> Solaris 10 Update 6 patches are made available. The two patches >> are independent of one another which is why there are two >> separate temporary work arounds. However, we're putting the >> temporary work arounds in place because the 7u6 project window >> is closing fast. >> >> Here is the webrev URL for the JDK8-T&L version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7170449-webrev/0/ >> >> This fix will also be backported to 7u6-T&L and I expect the >> changes to virtually identical. >> >> Thanks, in advance, for any reviews! >> >> Dan >> >> > From oehrstroem at gmail.com Thu May 24 19:02:34 2012 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Thu, 24 May 2012 21:02:34 +0200 Subject: Review Request: Build-infra update In-Reply-To: <4FBD2676.5090102@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> <4FBD2676.5090102@oracle.com> Message-ID: Not by me anyway. In fact, I think that solution is the best one! //Fredrik 2012/5/23 Jonathan Gibbons : > I wanted to be able to declare fields as native, but that was deemed > unacceptable. > > -- Jon > > > On 05/23/2012 10:05 AM, Alan Bateman wrote: >> >> On 23/05/2012 17:50, Kelly O'Hair wrote: >>> >>> Has anyone tried creating an unused native method declaration in the >>> class to trigger the native header >>> generation? ? public native void GenerateNativeHeader(); ? ??? ?Is that >>> too ugly? >>> >>> -kto >> >> As Jon put it, for the classes in the base module, "we are delicate >> bootstrapping ground" so if you add something like "private static native >> void dummy()" rather than the annotation to the classes in the base module >> then it could be a solution for the short term. This means the following >> sources in the webrev: >> >> src/share/classes/java/lang/Integer.java >> src/share/classes/java/lang/Long.java >> src/share/classes/java/net/SocketOptions.java >> src/windows/classes/sun/nio/ch/PollArrayWrapper.java >> >> Also it would be good to remove it from >> src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation in the >> first round). >> >> -Alan. >> > From jonathan.gibbons at oracle.com Thu May 24 19:04:52 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 24 May 2012 12:04:52 -0700 Subject: Review Request: Build-infra update In-Reply-To: References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> <4FBD2676.5090102@oracle.com> Message-ID: <4FBE8654.2050701@oracle.com> The rationale for not allowing it is that it has no meaning at either the JLS or JVMS level. It would simply be a hint for tools, and hints for tools are best done by annotations. -- Jon On 05/24/2012 12:02 PM, Fredrik ?hrstr?m wrote: > Not by me anyway. In fact, I think that solution is the best one! > > //Fredrik > > 2012/5/23 Jonathan Gibbons: >> I wanted to be able to declare fields as native, but that was deemed >> unacceptable. >> >> -- Jon >> >> >> On 05/23/2012 10:05 AM, Alan Bateman wrote: >>> On 23/05/2012 17:50, Kelly O'Hair wrote: >>>> Has anyone tried creating an unused native method declaration in the >>>> class to trigger the native header >>>> generation? public native void GenerateNativeHeader(); ??? Is that >>>> too ugly? >>>> >>>> -kto >>> As Jon put it, for the classes in the base module, "we are delicate >>> bootstrapping ground" so if you add something like "private static native >>> void dummy()" rather than the annotation to the classes in the base module >>> then it could be a solution for the short term. This means the following >>> sources in the webrev: >>> >>> src/share/classes/java/lang/Integer.java >>> src/share/classes/java/lang/Long.java >>> src/share/classes/java/net/SocketOptions.java >>> src/windows/classes/sun/nio/ch/PollArrayWrapper.java >>> >>> Also it would be good to remove it from >>> src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation in the >>> first round). >>> >>> -Alan. >>> From fredrik.ohrstrom at oracle.com Thu May 24 19:27:12 2012 From: fredrik.ohrstrom at oracle.com (=?UTF-8?B?RnJlZHJpayDDlmhyc3Ryw7Zt?=) Date: Thu, 24 May 2012 12:27:12 -0700 (PDT) Subject: Review Request: Build-infra update Message-ID: <69c3dc3e-8855-44ac-984a-a929bc262545@default> But it has a meaning for JLS+JVMS, if you change the final static and the native code depends on its value, and you forget to rerun javah, then something will break. A final static field that is used from native, is as bound to the running Java program as any native method is. Change something without rerunning javah, and it breaks. The native keyword is good because it tells the programmer that if you change this final static, then you have to verify the C-code as well! The real bad design decision was to export all final statics by default to the generated c header file. //Fredrik ----- jonathan.gibbons at oracle.com skrev: > The rationale for not allowing it is that it has no meaning at either > > the JLS or JVMS level. It would simply be a hint for tools, and hints > > for tools are best done by annotations. > > -- Jon > > On 05/24/2012 12:02 PM, Fredrik ?hrstr?m wrote: > > Not by me anyway. In fact, I think that solution is the best one! > > > > //Fredrik > > > > 2012/5/23 Jonathan Gibbons: > >> I wanted to be able to declare fields as native, but that was > deemed > >> unacceptable. > >> > >> -- Jon > >> > >> > >> On 05/23/2012 10:05 AM, Alan Bateman wrote: > >>> On 23/05/2012 17:50, Kelly O'Hair wrote: > >>>> Has anyone tried creating an unused native method declaration in > the > >>>> class to trigger the native header > >>>> generation? public native void GenerateNativeHeader(); ??? > Is that > >>>> too ugly? > >>>> > >>>> -kto > >>> As Jon put it, for the classes in the base module, "we are > delicate > >>> bootstrapping ground" so if you add something like "private static > native > >>> void dummy()" rather than the annotation to the classes in the > base module > >>> then it could be a solution for the short term. This means the > following > >>> sources in the webrev: > >>> > >>> src/share/classes/java/lang/Integer.java > >>> src/share/classes/java/lang/Long.java > >>> src/share/classes/java/net/SocketOptions.java > >>> src/windows/classes/sun/nio/ch/PollArrayWrapper.java > >>> > >>> Also it would be good to remove it from > >>> src/share/classes/sun/nio/ch/IOStatus.java too (it got the > annotation in the > >>> first round). > >>> > >>> -Alan. > >>> From david.holmes at oracle.com Fri May 25 06:20:09 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 25 May 2012 16:20:09 +1000 Subject: RFR: 7171653 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash Message-ID: <4FBF2499.1040304@oracle.com> This is a tweak to the cross-compilation rules in sun/xawt/Makefile to force correct compilation of the sizers utility. http://cr.openjdk.java.net/~dholmes/7171653/webrev/ webrev is against tl/jdk but I can use a different repo if you prefer. Now that we use CFLAGS_32/64 in the cross compilation case we no longer need different cc commands, other than the actual choice of compiler. Longer term 7153072 will make this fix obsolete but for now we need this for our new build servers, and I wanted to make sure this only affected cross-compilation. Same change will need to go to the 7u train as well. Thanks, David From anthony.petrov at oracle.com Fri May 25 11:27:55 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 25 May 2012 15:27:55 +0400 Subject: RFR: 7171653 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash In-Reply-To: <4FBF2499.1040304@oracle.com> References: <4FBF2499.1040304@oracle.com> Message-ID: <4FBF6CBB.3010706@oracle.com> Hi David, The fix looks fine to me. Is the empty line 281 OK in Makefiles? I'd remove it just in case. Besides it would make it more clearer that the SIZERS_CC commands are related to the SIZERS target. -- best regards, Anthony On 5/25/2012 10:20 AM, David Holmes wrote: > This is a tweak to the cross-compilation rules in sun/xawt/Makefile to > force correct compilation of the sizers utility. > > http://cr.openjdk.java.net/~dholmes/7171653/webrev/ > > webrev is against tl/jdk but I can use a different repo if you prefer. > > Now that we use CFLAGS_32/64 in the cross compilation case we no longer > need different cc commands, other than the actual choice of compiler. > > Longer term 7153072 will make this fix obsolete but for now we need this > for our new build servers, and I wanted to make sure this only affected > cross-compilation. > > Same change will need to go to the 7u train as well. > > Thanks, > David From tom.deneau at amd.com Wed May 23 15:54:01 2012 From: tom.deneau at amd.com (Deneau, Tom) Date: Wed, 23 May 2012 15:54:01 +0000 Subject: Building sunpkcs11.jar Message-ID: I want to be able to modify and rebuild lib/ext/sunpkcs11.jar. When I do a "make all; make images" everything completes successfully. With javap, I can see my modified class in the build/linux-amd64/j2sdk-image/jre/lib/ext When I use this built ext directory as a replacement of the Oracle 7U4 JRE, and run some code that does KeyGenerator gen = KeyGenerator.getInstance("AES"); I get Test1,java.security.NoSuchAlgorithmException: AES KeyGenerator not available at javax.crypto.KeyGenerator.(KeyGenerator.java:158) at javax.crypto.KeyGenerator.getInstance(KeyGenerator.java:207) This code runs successfully with the regular Oracle 7U4 JRE. Am I missing something in the build process? -- Tom Deneau From dhd at exnet.com Wed May 23 16:12:16 2012 From: dhd at exnet.com (Damon Hart-Davis) Date: Wed, 23 May 2012 17:12:16 +0100 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: <4FBD09CD.3020001@oracle.com> References: <4FBD09CD.3020001@oracle.com> Message-ID: <99F32F72-3D99-49A2-A062-38468AD75FAA@exnet.com> Hi, FWIW, and I have not looked at any of the build system for this, when building large optimised cross-platform critical C++ projects I had the option to turn down or off optimisation for individual files for individual compilers/platforms. At worst you might accomplish that (with other maintenance risks) with an explicit build rule in the makefile for that .cpp file for that platform/compiler, but only if the macro is local to that .cpp file. Anyhow, I'm speaking from ignorance of all the detail here, so please ignore me! Rgds Damon On 23 May 2012, at 17:01, Phil Race wrote: > I suppose the problem that some new version of GCC enables this option by default and > we could run into a problem at run time if we don't disable it ? > > But this patch would appear to disable it for the whole ICU library .. and any other C++ code in the .so > which I would have to suppose impacts the compiler's ability to optimise the code, in order to > eliminate a single warning. > > Can you devise a more targeted fix ? > > -phil. > > On 5/23/2012 5:59 AM, Andrew Hughes wrote: >> At present, the building of ExtensionSubtables.cpp produces a warning: >> >> ../../../src/share/native/sun/font/layout/ExtensionSubtables.cpp:57:31: >> warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] >> >> due to this code: >> >> // read a 32-bit value that might only be 16-bit-aligned in memory >> #define READ_LONG(code) (le_uint32)((SWAPW(*(le_uint16*)&code)<< 16) + SWAPW(*(((le_uint16*)&code) + 1))) >> >> where code is a le_uint32. >> >> This can be avoided by setting -fno-strict-aliasing, as done in this webrev: >> >> http://cr.openjdk.java.net/~andrew/no-strict-aliasing/ >> >> making the code safer in the process. >> >> Ok for jdk8? If so, can I have a bug ID for this please? >> >> Thanks, > From valerie.peng at oracle.com Fri May 25 19:11:01 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 25 May 2012 12:11:01 -0700 Subject: Building sunpkcs11.jar In-Reply-To: References: Message-ID: <4FBFD945.3010805@oracle.com> The provider built from OpenJDK workspace is unsigned. It can't be used with Oracle 7u4 JRE which require crypto provider to be signed for export/import conformance. If Your company has a JCE code signing keypair, you can sign the provider built using OpenJDK with that keypair and then use it w/ Oracle 7u4 JRE. Thanks, Valerie On 05/23/12 08:54, Deneau, Tom wrote: > I want to be able to modify and rebuild lib/ext/sunpkcs11.jar. > > When I do a "make all; make images" everything completes successfully. > With javap, I can see my modified class in the build/linux-amd64/j2sdk-image/jre/lib/ext > > When I use this built ext directory as a replacement of the Oracle 7U4 JRE, and run some code that does > > KeyGenerator gen = KeyGenerator.getInstance("AES"); > I get > Test1,java.security.NoSuchAlgorithmException: AES KeyGenerator not available > at javax.crypto.KeyGenerator.(KeyGenerator.java:158) > at javax.crypto.KeyGenerator.getInstance(KeyGenerator.java:207) > > This code runs successfully with the regular Oracle 7U4 JRE. > > Am I missing something in the build process? > > -- Tom Deneau > From tom.deneau at amd.com Fri May 25 22:13:30 2012 From: tom.deneau at amd.com (Deneau, Tom) Date: Fri, 25 May 2012 22:13:30 +0000 Subject: Building sunpkcs11.jar In-Reply-To: <4FBFD945.3010805@oracle.com> References: <4FBFD945.3010805@oracle.com> Message-ID: Valerie -- I don't believe we have a JCE code signing keypair (where would we have gotten one?) Is there any test flag that tells the Oracle 7u4 jre to not require a signed crypto provider -- Tom -----Original Message----- From: Valerie (Yu-Ching) Peng [mailto:valerie.peng at oracle.com] Sent: Friday, May 25, 2012 12:11 PM To: Deneau, Tom Cc: build-dev at openjdk.java.net Subject: Re: Building sunpkcs11.jar The provider built from OpenJDK workspace is unsigned. It can't be used with Oracle 7u4 JRE which require crypto provider to be signed for export/import conformance. If Your company has a JCE code signing keypair, you can sign the provider built using OpenJDK with that keypair and then use it w/ Oracle 7u4 JRE. Thanks, Valerie On 05/23/12 08:54, Deneau, Tom wrote: > I want to be able to modify and rebuild lib/ext/sunpkcs11.jar. > > When I do a "make all; make images" everything completes successfully. > With javap, I can see my modified class in the build/linux-amd64/j2sdk-image/jre/lib/ext > > When I use this built ext directory as a replacement of the Oracle 7U4 JRE, and run some code that does > > KeyGenerator gen = KeyGenerator.getInstance("AES"); > I get > Test1,java.security.NoSuchAlgorithmException: AES KeyGenerator not available > at javax.crypto.KeyGenerator.(KeyGenerator.java:158) > at javax.crypto.KeyGenerator.getInstance(KeyGenerator.java:207) > > This code runs successfully with the regular Oracle 7U4 JRE. > > Am I missing something in the build process? > > -- Tom Deneau > From valerie.peng at oracle.com Fri May 25 23:50:14 2012 From: valerie.peng at oracle.com (Valerie (Yu-Ching) Peng) Date: Fri, 25 May 2012 16:50:14 -0700 Subject: Building sunpkcs11.jar In-Reply-To: References: <4FBFD945.3010805@oracle.com> Message-ID: <4FC01AB6.7030604@oracle.com> There is no such flag; otherwise it'd be an easy way to circumvent existing checks for enforcing export/import control. Cryptographic vendors who develop JCE providers can apply for JCE code signing certificates through a process documented in the JCE guide. The easiest route may be just to test against your OpenJDK build since the JCE framework in the OpenJDK can accept unsigned providers. Valerie On 05/25/12 15:13, Deneau, Tom wrote: > Valerie -- > > I don't believe we have a JCE code signing keypair (where would we have gotten one?) > > Is there any test flag that tells the Oracle 7u4 jre to not require a signed crypto provider > > -- Tom > > -----Original Message----- > From: Valerie (Yu-Ching) Peng [mailto:valerie.peng at oracle.com] > Sent: Friday, May 25, 2012 12:11 PM > To: Deneau, Tom > Cc: build-dev at openjdk.java.net > Subject: Re: Building sunpkcs11.jar > > The provider built from OpenJDK workspace is unsigned. > It can't be used with Oracle 7u4 JRE which require crypto provider to be > signed for export/import conformance. > > If Your company has a JCE code signing keypair, you can sign the > provider built using OpenJDK with that keypair and then use it w/ Oracle > 7u4 JRE. > Thanks, > Valerie > > On 05/23/12 08:54, Deneau, Tom wrote: >> I want to be able to modify and rebuild lib/ext/sunpkcs11.jar. >> >> When I do a "make all; make images" everything completes successfully. >> With javap, I can see my modified class in the build/linux-amd64/j2sdk-image/jre/lib/ext >> >> When I use this built ext directory as a replacement of the Oracle 7U4 JRE, and run some code that does >> >> KeyGenerator gen = KeyGenerator.getInstance("AES"); >> I get >> Test1,java.security.NoSuchAlgorithmException: AES KeyGenerator not available >> at javax.crypto.KeyGenerator.(KeyGenerator.java:158) >> at javax.crypto.KeyGenerator.getInstance(KeyGenerator.java:207) >> >> This code runs successfully with the regular Oracle 7U4 JRE. >> >> Am I missing something in the build process? >> >> -- Tom Deneau >> > > From kelly.ohair at oracle.com Sat May 26 05:49:13 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Sat, 26 May 2012 05:49:13 +0000 Subject: hg: jdk8/build/jdk: 7172014: Remove empty and unused javah include files Message-ID: <20120526054937.8FA564754A@hg.openjdk.java.net> Changeset: edb02bee325e Author: ihse Date: 2012-05-25 18:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/edb02bee325e 7172014: Remove empty and unused javah include files Reviewed-by: ohair, erikj ! src/share/native/sun/awt/image/cvutils/img_dcm.h ! src/share/native/sun/awt/image/cvutils/img_dcm8.h ! src/share/native/sun/java2d/pipe/SpanClipRenderer.c ! src/solaris/native/sun/awt/initIDs.c From david.holmes at oracle.com Mon May 28 01:10:56 2012 From: david.holmes at oracle.com (David Holmes) Date: Mon, 28 May 2012 11:10:56 +1000 Subject: RFR: 7171653 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash In-Reply-To: <4FBF2499.1040304@oracle.com> References: <4FBF2499.1040304@oracle.com> Message-ID: <4FC2D0A0.3040005@oracle.com> I have a review from AWT (thanks Anthony), can I have one from build please. Any preference as to where to push this? Thanks, David On 25/05/2012 4:20 PM, David Holmes wrote: > This is a tweak to the cross-compilation rules in sun/xawt/Makefile to > force correct compilation of the sizers utility. > > http://cr.openjdk.java.net/~dholmes/7171653/webrev/ > > webrev is against tl/jdk but I can use a different repo if you prefer. > > Now that we use CFLAGS_32/64 in the cross compilation case we no longer > need different cc commands, other than the actual choice of compiler. > > Longer term 7153072 will make this fix obsolete but for now we need this > for our new build servers, and I wanted to make sure this only affected > cross-compilation. > > Same change will need to go to the 7u train as well. > > Thanks, > David From magnus.ihse.bursie at oracle.com Tue May 29 08:50:13 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 29 May 2012 10:50:13 +0200 Subject: Bug in FDS for Solaris? Message-ID: <4FC48DC5.6030507@oracle.com> When converting old makefiles to the new build-infra, we discovered what seems to be a bug for Full Debug Symbols on Solaris. In the file make/common/Defs-solaris.gmk, the following code (somewhat edited) was added: ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) ifeq ($(LIBRARY_SUPPORTS_FULL_DEBUG_SYMBOLS),1) ifeq ($(VARIANT), OPT) CC_OPT = -g -xs $(CC_OPT/$(FASTDEBUG_OPTIMIZATION_LEVEL)) CXX_OPT = -g0 -xs $(CXX_OPT/$(FASTDEBUG_OPTIMIZATION_LEVEL)) endif endif endif However, much further down in the file is the following: # Default optimization settings based on level. CC_OPT = $(CC_OPT/$(OPTIMIZATION_LEVEL)) CXX_OPT = $(CXX_OPT/$(OPTIMIZATION_LEVEL)) This is an unconditional assignment to CC[XX]_OPT, which completely overrides the FDS specialization. So, either this is unintended (seems most likely), or the FDS stanza is unnecessary. The net result is anyway that, as far as we call tell, even with FDS, compilations on Solaris happens without -g. /Magnus From ahughes at redhat.com Tue May 29 13:13:40 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Tue, 29 May 2012 09:13:40 -0400 (EDT) Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: <4FBD3024.60800@oracle.com> Message-ID: <6c755de2-ebf0-4cb0-a231-1ca0e81e442f@zmail17.collab.prod.int.phx2.redhat.com> ----- Original Message ----- > In anticipation of the updated fix I created > 7171223 : Building ExtensionSubtables.cpp should use > -fno-strict-aliasing > > -phil. > > > Ok for jdk8? If so, can I have a bug ID for this please? > > > > Thanks, > > Thanks for the bug ID, Phil. Here's the revised webrev: http://cr.openjdk.java.net/~andrew/no-strict-aliasing/webrev.02/ Sorry for the delay. I found when trying to build the build tree that HotSpot had regressed and become unbuildable: http://mail.openjdk.java.net/pipermail/hotspot-dev/2012-May/005945.html All patched now. Is build the preferred tree to push this too, or would you prefer somewhere else? Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From philip.race at oracle.com Tue May 29 13:50:06 2012 From: philip.race at oracle.com (Phil Race) Date: Tue, 29 May 2012 06:50:06 -0700 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: <6c755de2-ebf0-4cb0-a231-1ca0e81e442f@zmail17.collab.prod.int.phx2.redhat.com> References: <6c755de2-ebf0-4cb0-a231-1ca0e81e442f@zmail17.collab.prod.int.phx2.redhat.com> Message-ID: <4FC4D40E.4090406@oracle.com> I have one concern It sounds like the option is new in gcc 4.4 : http://gcc.gnu.org/gcc-4.4/porting_to.html I am not sure you can assume that since .. http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html#gcc " The GNU gcc compiler version should be 4.3 or newer." And I suggest a push to 2d-dev since its in the 2d code we get a warning and the "build" change is in 2D build files, specifically to work around that warning .. its really precious little to do with the build system. -phil. On 5/29/12 6:13 AM, Andrew Hughes wrote: > ----- Original Message ----- >> In anticipation of the updated fix I created >> 7171223 : Building ExtensionSubtables.cpp should use >> -fno-strict-aliasing >> >> -phil. >> >>> Ok for jdk8? If so, can I have a bug ID for this please? >>> >>> Thanks, >> > Thanks for the bug ID, Phil. > > Here's the revised webrev: > > http://cr.openjdk.java.net/~andrew/no-strict-aliasing/webrev.02/ > > Sorry for the delay. I found when trying to build the build tree > that HotSpot had regressed and become unbuildable: > > http://mail.openjdk.java.net/pipermail/hotspot-dev/2012-May/005945.html > > All patched now. Is build the preferred tree to push this too, > or would you prefer somewhere else? > > Thanks, -------------- next part -------------- An HTML attachment was scrubbed... URL: From kelly.ohair at oracle.com Tue May 29 16:54:00 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 29 May 2012 09:54:00 -0700 Subject: RFR: 7171653 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash In-Reply-To: <4FC2D0A0.3040005@oracle.com> References: <4FBF2499.1040304@oracle.com> <4FC2D0A0.3040005@oracle.com> Message-ID: Build-dev please. -kto On May 27, 2012, at 6:10 PM, David Holmes wrote: > I have a review from AWT (thanks Anthony), can I have one from build please. > > Any preference as to where to push this? > > Thanks, > David > > On 25/05/2012 4:20 PM, David Holmes wrote: >> This is a tweak to the cross-compilation rules in sun/xawt/Makefile to >> force correct compilation of the sizers utility. >> >> http://cr.openjdk.java.net/~dholmes/7171653/webrev/ >> >> webrev is against tl/jdk but I can use a different repo if you prefer. >> >> Now that we use CFLAGS_32/64 in the cross compilation case we no longer >> need different cc commands, other than the actual choice of compiler. >> >> Longer term 7153072 will make this fix obsolete but for now we need this >> for our new build servers, and I wanted to make sure this only affected >> cross-compilation. >> >> Same change will need to go to the 7u train as well. >> >> Thanks, >> David From kelly.ohair at oracle.com Tue May 29 17:12:29 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 29 May 2012 10:12:29 -0700 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: <4FC4D40E.4090406@oracle.com> References: <6c755de2-ebf0-4cb0-a231-1ca0e81e442f@zmail17.collab.prod.int.phx2.redhat.com> <4FC4D40E.4090406@oracle.com> Message-ID: You should be able to do something like: # Turn off aliasing with GCC for ExtensionSubtables.cpp ifeq ($(PLATFORM), linux) CXXFLAGS += $(CXXFLAGS_$(@F)) CC_NEWER_THAN_43 := \ $(shell $(EXPR) $(CC_MAJORVER) \> 4 \| \ \( $(CC_MAJORVER) = 4 \& $(CC_MINORVER) \> 3 \) ) ifeq ($(CC_NEWER_THAN_43),1) CXXFLAGS_ExtensionSubtables.o = -fno-strict-aliasing endif endif -kto On May 29, 2012, at 6:50 AM, Phil Race wrote: > I have one concern > > It sounds like the option is new in gcc 4.4 : http://gcc.gnu.org/gcc-4.4/porting_to.html > > I am not sure you can assume that since .. > > http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html#gcc > " The GNU gcc compiler version should be 4.3 or newer." > > And I suggest a push to 2d-dev since its in the 2d code we get > a warning and the "build" change is in 2D build files, specifically to work > around that warning .. its really precious little to do with the build system. > > -phil. > > On 5/29/12 6:13 AM, Andrew Hughes wrote: >> >> ----- Original Message ----- >>> In anticipation of the updated fix I created >>> 7171223 : Building ExtensionSubtables.cpp should use >>> -fno-strict-aliasing >>> >>> -phil. >>> >>>> Ok for jdk8? If so, can I have a bug ID for this please? >>>> >>>> Thanks, >>> >> Thanks for the bug ID, Phil. >> >> Here's the revised webrev: >> >> http://cr.openjdk.java.net/~andrew/no-strict-aliasing/webrev.02/ >> >> Sorry for the delay. I found when trying to build the build tree >> that HotSpot had regressed and become unbuildable: >> >> http://mail.openjdk.java.net/pipermail/hotspot-dev/2012-May/005945.html >> >> All patched now. Is build the preferred tree to push this too, >> or would you prefer somewhere else? >> >> Thanks, > -------------- next part -------------- An HTML attachment was scrubbed... URL: From daniel.daugherty at oracle.com Tue May 29 17:26:21 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 29 May 2012 11:26:21 -0600 Subject: Bug in FDS for Solaris? In-Reply-To: <4FC48DC5.6030507@oracle.com> References: <4FC48DC5.6030507@oracle.com> Message-ID: <4FC506BD.9060507@oracle.com> Definitely something wrong here... When I originally did these changes, here was the thinking: 230 # If Full Debug Symbols is enabled, then we want the same debug and 231 # optimization flags as used by FASTDEBUG. We also want all the 232 # debug info in one place (-xs). 233 # 234 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) 235 ifeq ($(LIBRARY_SUPPORTS_FULL_DEBUG_SYMBOLS),1) 236 ifeq ($(VARIANT), OPT) 237 CC_OPT = -g -xs $(CC_OPT/$(FASTDEBUG_OPTIMIZATION_LEVEL)) 238 CXX_OPT = -g0 -xs $(CXX_OPT/$(FASTDEBUG_OPTIMIZATION_LEVEL)) 239 endif 240 CFLAGS_DEBUG_OPTION += -xs 241 CXXFLAGS_DEBUG_OPTION += -xs 242 endif 243 endif and a little bit lower: 257 # Optimization flags 258 CFLAGS_OPT = $(CC_OPT) and a little bit lower: 295 CXXFLAGS_OPT = $(CXX_OPT) so my early settings of CC_OPT and CXX_OPT were squirreled away in the early CFLAGS_OPT and CXXFLAGS_OPT settings. That used to work... However, that little trick no longer seems to be working... confirmed by grep'ing for the '-g' option in my most recent JPRT build log on Solaris... Thanks for spotting this... Do you happen to already have a suggested fix for this? Dan On 5/29/12 2:50 AM, Magnus Ihse Bursie wrote: > When converting old makefiles to the new build-infra, we discovered > what seems to be a bug for Full Debug Symbols on Solaris. > > In the file make/common/Defs-solaris.gmk, the following code (somewhat > edited) was added: > > ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) > ifeq ($(LIBRARY_SUPPORTS_FULL_DEBUG_SYMBOLS),1) > ifeq ($(VARIANT), OPT) > CC_OPT = -g -xs $(CC_OPT/$(FASTDEBUG_OPTIMIZATION_LEVEL)) > CXX_OPT = -g0 -xs $(CXX_OPT/$(FASTDEBUG_OPTIMIZATION_LEVEL)) > endif > endif > endif > > However, much further down in the file is the following: > # Default optimization settings based on level. > CC_OPT = $(CC_OPT/$(OPTIMIZATION_LEVEL)) > CXX_OPT = $(CXX_OPT/$(OPTIMIZATION_LEVEL)) > > This is an unconditional assignment to CC[XX]_OPT, which completely > overrides the FDS specialization. > > So, either this is unintended (seems most likely), or the FDS stanza > is unnecessary. The net result is anyway that, as far as we call tell, > even with FDS, compilations on Solaris happens without -g. > > /Magnus From aph at redhat.com Tue May 29 17:55:55 2012 From: aph at redhat.com (Andrew Haley) Date: Tue, 29 May 2012 18:55:55 +0100 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: References: <6c755de2-ebf0-4cb0-a231-1ca0e81e442f@zmail17.collab.prod.int.phx2.redhat.com> <4FC4D40E.4090406@oracle.com> Message-ID: <4FC50DAB.4070603@redhat.com> On 05/29/2012 06:12 PM, Kelly O'Hair wrote: > > You should be able to do something like: > > # Turn off aliasing with GCC for ExtensionSubtables.cpp > ifeq ($(PLATFORM), linux) > CXXFLAGS += $(CXXFLAGS_$(@F)) > CC_NEWER_THAN_43 := \ > $(shell $(EXPR) $(CC_MAJORVER) \> 4 \| \ > \( $(CC_MAJORVER) = 4 \& $(CC_MINORVER) \> 3 \) ) > ifeq ($(CC_NEWER_THAN_43),1) > CXXFLAGS_ExtensionSubtables.o = -fno-strict-aliasing > endif > endif No way: -fno-strict-aliasing has been in GCC for a very long time, and it's certainly in 4.0. You'll need it in 4.3. Andrew. From dhd at exnet.com Tue May 29 18:06:07 2012 From: dhd at exnet.com (Damon Hart-Davis) Date: Tue, 29 May 2012 19:06:07 +0100 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: References: <6c755de2-ebf0-4cb0-a231-1ca0e81e442f@zmail17.collab.prod.int.phx2.redhat.com> <4FC4D40E.4090406@oracle.com> Message-ID: <400DDA1B-3FBA-4C02-AF93-7D0DB563CFB0@exnet.com> That is indeed the sort of horror we used to implement out DontOptimise(something.cpp) and DontOptimiseMuch(somethingelse.cpp) macros at a now-famously-defunct investment bank. The code outlived the bank... B^> Rgds Damon On 29 May 2012, at 18:12, Kelly O'Hair wrote: > > You should be able to do something like: > > # Turn off aliasing with GCC for ExtensionSubtables.cpp > ifeq ($(PLATFORM), linux) > CXXFLAGS += $(CXXFLAGS_$(@F)) > CC_NEWER_THAN_43 := \ > $(shell $(EXPR) $(CC_MAJORVER) \> 4 \| \ > \( $(CC_MAJORVER) = 4 \& $(CC_MINORVER) \> 3 \) ) > ifeq ($(CC_NEWER_THAN_43),1) > CXXFLAGS_ExtensionSubtables.o = -fno-strict-aliasing > endif > endif > > -kto > > On May 29, 2012, at 6:50 AM, Phil Race wrote: > >> I have one concern >> >> It sounds like the option is new in gcc 4.4 : http://gcc.gnu.org/gcc-4.4/porting_to.html >> >> I am not sure you can assume that since .. >> >> http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html#gcc >> " The GNU gcc compiler version should be 4.3 or newer." >> >> And I suggest a push to 2d-dev since its in the 2d code we get >> a warning and the "build" change is in 2D build files, specifically to work >> around that warning .. its really precious little to do with the build system. >> >> -phil. >> >> On 5/29/12 6:13 AM, Andrew Hughes wrote: >>> ----- Original Message ----- >>> >>>> In anticipation of the updated fix I created >>>> 7171223 : Building ExtensionSubtables.cpp should use >>>> -fno-strict-aliasing >>>> >>>> -phil. >>>> >>>> >>>>> Ok for jdk8? If so, can I have a bug ID for this please? >>>>> >>>>> Thanks, >>>>> >>> Thanks for the bug ID, Phil. >>> >>> Here's the revised webrev: >>> >>> >>> http://cr.openjdk.java.net/~andrew/no-strict-aliasing/webrev.02/ >>> >>> >>> Sorry for the delay. I found when trying to build the build tree >>> that HotSpot had regressed and become unbuildable: >>> >>> >>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2012-May/005945.html >>> >>> >>> All patched now. Is build the preferred tree to push this too, >>> or would you prefer somewhere else? >>> >>> Thanks, >>> >> > From kelly.ohair at oracle.com Tue May 29 18:53:37 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 29 May 2012 11:53:37 -0700 Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: <4FC50DAB.4070603@redhat.com> References: <6c755de2-ebf0-4cb0-a231-1ca0e81e442f@zmail17.collab.prod.int.phx2.redhat.com> <4FC4D40E.4090406@oracle.com> <4FC50DAB.4070603@redhat.com> Message-ID: <9095AC5A-A4CB-4BFA-AB09-E25CDE905F8E@oracle.com> On May 29, 2012, at 10:55 AM, Andrew Haley wrote: > On 05/29/2012 06:12 PM, Kelly O'Hair wrote: >> >> You should be able to do something like: >> >> # Turn off aliasing with GCC for ExtensionSubtables.cpp >> ifeq ($(PLATFORM), linux) >> CXXFLAGS += $(CXXFLAGS_$(@F)) >> CC_NEWER_THAN_43 := \ >> $(shell $(EXPR) $(CC_MAJORVER) \> 4 \| \ >> \( $(CC_MAJORVER) = 4 \& $(CC_MINORVER) \> 3 \) ) >> ifeq ($(CC_NEWER_THAN_43),1) >> CXXFLAGS_ExtensionSubtables.o = -fno-strict-aliasing >> endif >> endif > > No way: -fno-strict-aliasing has been in GCC for a very long time, and it's > certainly in 4.0. You'll need it in 4.3. In which case, I'd rather not add this kind of ugly make logic. Although I'm not sure if we have anyone building with really old GCC versions anymore, or even if we have a sanity check that says "FATAL: Please don;t build with older GCC versions than 4.3" :^( I was just thinking how to handle new GCC options in Makefiles, didn't investigate GCC versions. -kto > > Andrew. From david.holmes at oracle.com Wed May 30 05:32:09 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 30 May 2012 05:32:09 +0000 Subject: hg: jdk8/build/jdk: 7171653: 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash Message-ID: <20120530053229.85799475B0@hg.openjdk.java.net> Changeset: 8b4dd321b8a2 Author: dholmes Date: 2012-05-30 00:37 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8b4dd321b8a2 7171653: 32-bit cross-compile on 64-bit build host generates 64-bit data for awt/X11 leading to crash Reviewed-by: ohair, anthony ! make/sun/xawt/Makefile ! makefiles/sun/xawt/Makefile From ahughes at redhat.com Wed May 30 12:27:41 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Wed, 30 May 2012 08:27:41 -0400 (EDT) Subject: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing In-Reply-To: <9095AC5A-A4CB-4BFA-AB09-E25CDE905F8E@oracle.com> Message-ID: <15deb5a6-cc45-4be2-b1a0-97cdb839c342@zmail17.collab.prod.int.phx2.redhat.com> ----- Original Message ----- > > On May 29, 2012, at 10:55 AM, Andrew Haley wrote: > > > On 05/29/2012 06:12 PM, Kelly O'Hair wrote: > >> > >> You should be able to do something like: > >> > >> # Turn off aliasing with GCC for ExtensionSubtables.cpp > >> ifeq ($(PLATFORM), linux) > >> CXXFLAGS += $(CXXFLAGS_$(@F)) > >> CC_NEWER_THAN_43 := \ > >> $(shell $(EXPR) $(CC_MAJORVER) \> 4 \| \ > >> \( $(CC_MAJORVER) = 4 \& $(CC_MINORVER) \> 3 \) ) > >> ifeq ($(CC_NEWER_THAN_43),1) > >> CXXFLAGS_ExtensionSubtables.o = -fno-strict-aliasing > >> endif > >> endif > > > > No way: -fno-strict-aliasing has been in GCC for a very long time, > > and it's > > certainly in 4.0. You'll need it in 4.3. > > In which case, I'd rather not add this kind of ugly make logic. > Although I'm not sure > if we have anyone building with really old GCC versions anymore, or > even if we have > a sanity check that says "FATAL: Please don;t build with older GCC > versions than 4.3" :^( > > I was just thinking how to handle new GCC options in Makefiles, > didn't investigate GCC versions. > It's not only not new to 4.4, you already use it in make/common/Defs-linux.gmk: # # Misc compiler options # ifneq ($(ARCH),ppc) CFLAGS_COMMON = -fno-strict-aliasing endif I'll push to 2D. > -kto > > > > > Andrew. > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From david.katleman at oracle.com Wed May 30 23:18:43 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 May 2012 23:18:43 +0000 Subject: hg: jdk8/build: Added tag jdk8-b40 for changeset a2b2d435f1d2 Message-ID: <20120530231843.88D3E4762C@hg.openjdk.java.net> Changeset: 1a8c7c530f8a Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/1a8c7c530f8a Added tag jdk8-b40 for changeset a2b2d435f1d2 ! .hgtags From david.katleman at oracle.com Wed May 30 23:18:48 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 May 2012 23:18:48 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b40 for changeset 56d030e5035f Message-ID: <20120530231849.B09EF4762D@hg.openjdk.java.net> Changeset: 113f0d5f0a08 Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/113f0d5f0a08 Added tag jdk8-b40 for changeset 56d030e5035f ! .hgtags From david.katleman at oracle.com Wed May 30 23:20:05 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 May 2012 23:20:05 +0000 Subject: hg: jdk8/build/hotspot: 23 new changesets Message-ID: <20120530232056.6053B4762E@hg.openjdk.java.net> Changeset: 48064e53e997 Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/48064e53e997 Added tag jdk8-b40 for changeset ff9decc8235d ! .hgtags Changeset: 03d61caacd1e Author: amurillo Date: 2012-05-18 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/03d61caacd1e 7170006: new hotspot build - hs24-b12 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 0251d217257f Author: sla Date: 2012-05-08 20:28 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0251d217257f 7162726: Wrong filter predicate of visible locals in SA JSJavaFrame Reviewed-by: sla, dcubed Contributed-by: Krystal Mok ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaFrame.java Changeset: 7f410b6ea66c Author: dholmes Date: 2012-05-09 00:28 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7f410b6ea66c 7167406: (Zero) Fix for InvokeDynamic needed Reviewed-by: chrisphi, dholmes Contributed-by: Andrew Dinn ! src/cpu/zero/vm/cppInterpreter_zero.cpp Changeset: d506b2cf2ad0 Author: dholmes Date: 2012-05-09 04:32 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d506b2cf2ad0 Merge Changeset: 78d2ae5ab35b Author: nloodin Date: 2012-05-09 16:24 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/78d2ae5ab35b 7163117: Agent can't connect to process on Mac OSX Reviewed-by: dholmes, coleenp, sla, minqi, kvn ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java Changeset: 037973617842 Author: kevinw Date: 2012-05-11 17:24 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/037973617842 7157734: hotspot test scripts not testing 64-bit JVM under JPRT/JTREG. Reviewed-by: kvn ! test/compiler/6894807/Test6894807.sh ! test/gc/6941923/test6941923.sh ! test/runtime/6626217/Test6626217.sh ! test/runtime/6878713/Test6878713.sh ! test/runtime/6929067/Test6929067.sh ! test/runtime/7020373/Test7020373.sh ! test/runtime/7051189/Xchecksig.sh ! test/runtime/7158988/TestFieldMonitor.sh Changeset: 2f4819f92dc7 Author: zgu Date: 2012-05-10 18:19 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2f4819f92dc7 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp Changeset: b4f7c4315c36 Author: zgu Date: 2012-05-12 06:50 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b4f7c4315c36 Merge Changeset: 7d4e6dabc6bf Author: dcubed Date: 2012-05-15 10:52 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7d4e6dabc6bf 7165060: dtrace tests fail with FDS debug info files Summary: Work around 'gobjcopy --add-gnu-debuglink' failure by adding a temporary tool that adds the '.gnu_debuglink' section and nothing more. Reviewed-by: sspitsyn, acorn + make/solaris/makefiles/add_gnu_debuglink.make ! make/solaris/makefiles/vm.make + src/os/solaris/add_gnu_debuglink/add_gnu_debuglink.c Changeset: 80b9cc90b643 Author: dcubed Date: 2012-05-15 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/80b9cc90b643 Merge ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/vm.make Changeset: 9793f47cdebc Author: dcubed Date: 2012-05-15 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9793f47cdebc 7169102: 7165060 merge lost changes to make/windows/makefiles/defs.make Reviewed-by: sspitsyn, acorn ! make/windows/makefiles/defs.make Changeset: 7432b9db36ff Author: nloodin Date: 2012-05-10 15:44 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7432b9db36ff 7165755: OS Information much longer on linux than other platforms Reviewed-by: sla, dholmes ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/posix/vm/os_posix.cpp + src/os/posix/vm/os_posix.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/share/vm/runtime/os.hpp Changeset: 198dcc84088c Author: dcubed Date: 2012-05-16 12:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/198dcc84088c 7169409: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Windows X86 Summary: Disable ZIP_DEBUGINFO_FILES by default on Windows. Reviewed-by: acorn ! make/windows/makefiles/defs.make Changeset: 4b37c0dafe3a Author: dcubed Date: 2012-05-18 09:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4b37c0dafe3a 7170010: conditional "ZIP_DEBUGINFO_FILES ?= 0" setting is not reliable on Windows Summary: Always disable ZIP_DEBUGINFO_FILES on Windows. Reviewed-by: acorn ! make/windows/makefiles/defs.make Changeset: cee14a6fc5ac Author: zgu Date: 2012-05-22 20:29 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cee14a6fc5ac Merge Changeset: 6759698e3140 Author: roland Date: 2012-05-15 10:10 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6759698e3140 7133857: exp() and pow() should use the x87 ISA on x86 Summary: use x87 instructions to implement exp() and pow() in interpreter/c1/c2. Reviewed-by: kvn, never, twisti ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/sparc/vm/interpreter_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_LinearScan_x86.cpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/interpreter_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/subnode.cpp Changeset: 4073d9478a90 Author: roland Date: 2012-05-18 15:50 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4073d9478a90 7167254: Crash on OSX in Enumerator.nextElement() with compressed oops Summary: null checks in "compressed oops with base" mode may trigger a SIGBUS rather than a SIGSEGV. Reviewed-by: dsamersoff, dcubed, rbackman, kvn ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: cdd249497b34 Author: twisti Date: 2012-05-18 12:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cdd249497b34 7170053: crash in C2 when using -XX:+CountCompiledCalls Reviewed-by: kvn, twisti Contributed-by: Krystal Mok ! src/share/vm/opto/doCall.cpp Changeset: e2961d14584b Author: roland Date: 2012-05-21 09:46 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e2961d14584b 7169934: pow(x,y) or x64 computes incorrect result when x<0 and y is an odd integer Summary: bad test for parity of y in pow(x,y) (c1, interpreter) Reviewed-by: kvn, twisti ! src/cpu/x86/vm/assembler_x86.cpp Changeset: 7089278210e2 Author: kvn Date: 2012-05-24 18:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7089278210e2 Merge Changeset: 785573170238 Author: amurillo Date: 2012-05-25 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/785573170238 Merge Changeset: 37add4fa0296 Author: amurillo Date: 2012-05-25 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/37add4fa0296 Added tag hs24-b12 for changeset 785573170238 ! .hgtags From david.katleman at oracle.com Wed May 30 23:23:18 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 May 2012 23:23:18 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b40 for changeset 9ecfdbd6aed4 Message-ID: <20120530232323.06A0B4762F@hg.openjdk.java.net> Changeset: 6f5c0e17415d Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/6f5c0e17415d Added tag jdk8-b40 for changeset 9ecfdbd6aed4 ! .hgtags From david.katleman at oracle.com Wed May 30 23:23:28 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 May 2012 23:23:28 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b40 for changeset 09a0ddda03cb Message-ID: <20120530232332.3D9A247630@hg.openjdk.java.net> Changeset: f2072b164b05 Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/f2072b164b05 Added tag jdk8-b40 for changeset 09a0ddda03cb ! .hgtags From david.katleman at oracle.com Wed May 30 23:23:42 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 May 2012 23:23:42 +0000 Subject: hg: jdk8/build/jdk: 2 new changesets Message-ID: <20120530232418.ED5B747631@hg.openjdk.java.net> Changeset: 7def50698e78 Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7def50698e78 Added tag jdk8-b40 for changeset b88fc3359dc7 ! .hgtags Changeset: 4eac56f073ea Author: katleman Date: 2012-05-30 15:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4eac56f073ea Merge From david.katleman at oracle.com Wed May 30 23:25:53 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 30 May 2012 23:25:53 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b40 for changeset 86e0dad6aadf Message-ID: <20120530232557.C293147632@hg.openjdk.java.net> Changeset: 179fa85aeefa Author: katleman Date: 2012-05-24 16:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/179fa85aeefa Added tag jdk8-b40 for changeset 86e0dad6aadf ! .hgtags