Solaris-only flag with newer gcc = build failed

[David Holmes]

Hi Pierre,

Only just saw your email turn up on the list!

This is bug 7150392 and was fixed about 6 weeks ago.

 From the eval:

This option is causing some confusion as it was listed as a GCC sparc 
option and so we had concerns about its need on linux-sparc, but then it 
was changed to a Solaris2 option in 2010:

http://gcc.gnu.org/onlinedocs/gcc/Solaris-2-Options.html#index-mimpure_002dtext-2103

http://old.nabble.com/Correctly-document-Solaris-2-options-td29851048.html

So it's applicability to linux-sparc is unclear. As we only used this 
option for linux builds and not Solaris builds I find this even more 
confusing!

---

Cheers,
David Holmes



On 12/05/2012 11:52 PM, Pierre Laporte wrote:
> Hi OpenJDK people !
>
> I tried to build the latest version of OpenJDK on my machine, but ran
> into a problem during the compilation.
> The error I got was "gcc: error: unrecognized command line option
> '-mimpure-text'".
>
> I am not a C/C++ programmer but I found out that this option is for
> Solaris only. It is used at line 70 in the
> file ./jdk/make/common/shared/Compiler-gcc.gmk
> It seems that the problem is related to gcc v4.7, which is the version I
> used. I found a JIRA on JRuby where a user had the same problem (see
> "References" below).
>
> I removed that option form the file Compiler-gcc.gmk and the build
> was successful. Was that the right thing to do or should I expect JVM
> crashes ?
>
> I did not try to build the package using older versions of gcc, so I
> suppose that previous versions did tolerate the presence of this flag
> even if it is useful only on Solaris. Can someone confirm this ?
>
> Sources :
> - http://gcc.gnu.org/onlinedocs/gcc/Option-Summary.html
> - http://jira.codehaus.org/browse/JRUBY-6633
>
> Regards.
>
> --
>
> Pierre Laporte
> pierre at pingtimeout.fr <mailto:pierre at pingtimeout.fr>
> http://www.pingtimeout.fr/