Need reviewer - @GenerateNativeHeader

Fredrik Öhrström oehrstroem at gmail.com
Wed May 23 07:03:13 UTC 2012


Looks good.

Since the annotation is a compile time only annotation, it should not
affect any future modularization efforts. Right Alan?

//Fredrik


2012/5/23 Kelly O'Hair <kelly.ohair at oracle.com>:
>
> 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI
> http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/
>
> The new build infrastructure wants to fully automate the generation of the JNI header files (running javah).
> On classes that have "native" methods this is obvious, but class that only export constants, and whose constants
> are needed in the JNI native code, we need to mark these classes as needing their native header file generated.
>
> This change is adding:
>
> import javax.tools.annotation.GenerateNativeHeader;
>
> /* No native methods here, but the constants are needed in the supporting JNI code */
> @GenerateNativeHeader
>
> To any class without a native method, but needing to expose it's constants to the native code.
>
> -kto
>



More information about the build-dev mailing list