code review for JDK FDS gobjcopy work arounds (7170449)

[Karen Kinnear]

Looks good. Thank you.

thanks,
Karen

On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote:

> Greetings,
> 
> This is a JDK code review request for a pair of Full Debug Symbols
> gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10
> corrupts the SUNW_* sections on objects. This has caused dtrace test
> failures and Monitoring & Management test failures. The gobjcopy
> utility crashes due to empty sections with the SHF_ALLOC flagset on
> Solaris X64 objects. This causes build failures.
> 
> There are two new temporary work around tools:
> 
> add_gnu_debuglink - adds the ".gnu_debuglink" section to an ELF
>    object without corrupting the other sections in the object.
> 
> fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty
>    sections in ELF objects.
> 
> These temporary work arounds are only needed until the proper
> Solaris 10 Update 6 patches are made available. The two patches
> are independent of one another which is why there are two
> separate temporary work arounds. However, we're putting the
> temporary work arounds in place because the 7u6 project window
> is closing fast.
> 
> Here is the webrev URL for the JDK8-T&L version:
> 
> http://cr.openjdk.java.net/~dcubed/fds_revamp/7170449-webrev/0/
> 
> This fix will also be backported to 7u6-T&L and I expect the
> changes to virtually identical.
> 
> Thanks, in advance, for any reviews!
> 
> Dan
> 
>