RFR 8003161: Cannot build jdk8/build using the new build system after latest merge.
Fredrik Öhrström
fredrik.ohrstrom at oracle.com
Thu Nov 8 11:11:20 UTC 2012
2012-11-08 11:52, David Holmes skrev:
> I don't understand this:
>
> $$(shell $(MKDIR) -p $$($1_BIN) && $(RM)
> $$($1_BIN)/_the.$$($1_JARNAME)_include)
>
> If you have to create the directory there can't possibly be anything
> to rm. ???
Two things need to be established before ListPathsSafely is executed.
The output dir must exist, and the previous file must be empty/removed.
So you are right and to do it properly, you shoud not execute the RM
if you successfully created the dir. That command line would look like this:
$$(shell $(MKDIR) $$($1_BIN) 2> /dev/null || $(RM)
$$($1_BIN)/_the.$$($1_JARNAME)_include)
The extra complexity is just not worth it methinks, since saving a
single RM per jar will not give you a noticeable speedup....
//Fredrik
More information about the build-dev
mailing list