Review Request: 8003177: build-infra: Compare reports diff in LocaleDataMetaInfo.class

Erik Joelsson erik.joelsson at oracle.com
Fri Nov 9 09:18:50 UTC 2012


Well, to your defense, we can't run comparisons outside of the 
build-infra forest because of JDK-8001103, so I never pointed you to the 
compare script for verifying this.

Thanks for the review!

/Erik

On 2012-11-08 19:05, Naoto Sato wrote:
> My bad. This should have been fixed with 8001231. Looks good to me.
>
> Naoto
>
> On 11/8/12 8:40 AM, Erik Joelsson wrote:
>> Small fix for class file diff that was introduced with the changes to
>> locales.
>>
>> http://cr.openjdk.java.net/~erikj/8003177/webrev.01/
>> <http://cr.openjdk.java.net/%7Eerikj/8003177/webrev.01/>
>>
>> Before this change, LocaleDataMetaInfo.java was generated with an extra
>> space in the list of locales for CollationData.
>>
>> The change prevents sed from inserting a space when the list of locales
>> is empty.
>>
>> /Erik
>



More information about the build-dev mailing list