Review Request: 8002028: build-infra: need no-hotspot partial build

[David Holmes]

On 9/11/2012 7:53 PM, Erik Joelsson wrote:
> On 2012-11-09 04:39, David Holmes wrote:
>> On 9/11/2012 12:27 AM, Erik Joelsson wrote:
>>> New webrev for root:
>>>
>>> http://cr.openjdk.java.net/~erikj/8002028/webrev.root.02/
>>> <http://cr.openjdk.java.net/%7Eerikj/8002028/webrev.root.02/>
>>>
>>
>> But with regard to the import, you are forcing the import location to
>> be a full JDK:
>>
>> + if ! (test -d $HOTSPOT_DIST/lib && test -d $HOTSPOT_DIST/jre/lib); then
>> + AC_MSG_ERROR([You have to import hotspot from a full jdk image or
>> hotspot build dist dir!])
>>
>> and I don't understand why. Why can't I import from a JRE or from a
>> custom build location that doesn't contain lib/jre/... ?
>>
> Ah, I see. The requirements I put in configure matches what Import.gmk
> is expecting, which I assumed was the layout hotspot will always use in
> the dist directory. Apart from importing from a JRE, do you know of a
> case where this wouldn't work? Do we need support for importing from a JRE?

I'm not aware of any specific need, it just seemed unnecessarily 
restrictive. But if that is the way things already work that is fine.

David

> /Erik
>
>> David
>> -----
>>
>>> Improved the description and fail message in configure.
>>>
>>> /Erik
>>>
>>> On 2012-11-08 11:41, Erik Joelsson wrote:
>>>>
>>>>
>>>> On 2012-11-08 04:19, David Holmes wrote:
>>>>> Hi Erik,
>>>>>
>>>>> Two queries:
>>>>>
>>>>> 1. In Main.gmk wouldn't it be better to move the hotspot targets
>>>>> inside the conditional - that way if you ask to build hotspot when
>>>>> you are not configured to build it you will get an error.
>>>>>
>>>> I figured there would be errors when other targets depended on
>>>> hotspot, but it seems to handle it fine. In fact, I can't get it to
>>>> cause any errors at all even when trying to make hotspot explicitly.
>>>> It looks better having the complete set of rules inside the ifdefs
>>>> though.
>>>>
>>>>> 2. Why do you have to import hotspot from a full JDK ??
>>>>>
>>>> You don't. I just assumed that's how this feature was used before.
>>>> Another valid value would be the dist directory of any hotspot build.
>>>> Are there other possible ways to use this in the old build?
>>>>
>>>> /Erik
>>>>> David
>>>>>
>>>>> On 8/11/2012 1:08 AM, Erik Joelsson wrote:
>>>>>> Adding support for importing the hotspot binaries from a prebuilt
>>>>>> j2sdk
>>>>>> image. Use configure option --with-import-hotspot=/path/to/j2sdkimage
>>>>>> and the build will skip building hotspot.
>>>>>>
>>>>>> http://cr.openjdk.java.net/~erikj/8002028/webrev.jdk.01/
>>>>>> <http://cr.openjdk.java.net/%7Eerikj/8002028/webrev.jdk.01/>
>>>>>> http://cr.openjdk.java.net/~erikj/8002028/webrev.root.01/
>>>>>> <http://cr.openjdk.java.net/%7Eerikj/8002028/webrev.root.01/>
>>>>>>
>>>>>> Note that if trying this patch (or before committing it) make sure to
>>>>>> regenerate configure first and if committing, commit in
>>>>>> jdk/make/closed
>>>>>> too.
>>>>>>
>>>>>> /Erik