Review Request: 8003844: build-infra: docs target isn't working properly

Jonathan Gibbons jonathan.gibbons at oracle.com
Mon Nov 26 16:37:41 UTC 2012


OK, as long as you're picking up the right bits, the packaging details 
do not matter quite so much, since these jars are only used temporarily 
during the build process.

-- Jon

On 11/26/2012 08:25 AM, Erik Joelsson wrote:
> Yes, and the bootstrap jar for javadoc does actually contain all of 
> it. The only difference between bootstrap javac.jar and bootstrap 
> javadoc.jar is the manifest. I'm not sure this is a good idea, but 
> it's the way it currently works in build-infra.
>
> /Erik
>
> On 2012-11-26 17:16, Jonathan Gibbons wrote:
>> The changes to common/makefiles/javadoc/Javadoc.gmk look suspect.
>> One way or another, you need all of the classes from javadoc, javac
>> and doclets on the bootclasspath.
>>
>> -- Jon
>>
>> On 11/26/2012 08:10 AM, Kelly O'Hair wrote:
>>> Looks good to me.
>>>
>>> -kto
>>>
>>> On Nov 26, 2012, at 3:01 AM, Erik Joelsson wrote:
>>>
>>>> I have fixed the docs target and added support for comparing the 
>>>> generated docs with the old build.
>>>>
>>>> http://cr.openjdk.java.net/~erikj/8003844/webrev.01/
>>>>
>>>> /Erik
>>




More information about the build-dev mailing list