Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

[Anthony Petrov]

CC'ing awt-dev@, Yuri, and Artem.

--
best regards,
Anthony

On 11/29/12 18:27, Fredrik Öhrström wrote:
> The GensrcX11Wrapper.gmk makefile creates a new sizes.32 or sizes.64 by
> running a generated C program
> that performs many sizeof calculations on X11 structures. This is cross
> compileable.
>
> Fortunately the sizes.32 and sizes.64 offset files are very stable. Thus
> we can commit them to the
> source code repository. When not cross compiling we perform a
> verification step that
> regenerates the offset file for the build platforms bits, and checks
> that it is the same
> as the committed version.
>
> Patch is here:
> http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper/
> (do not read the diff of the makefile, read the new makefile, too many
> changes.)
>
> Question: by always supplying both sizes.32 and sizes.64 to the
> generator tool, it
> seems like it is encoding both offsets into the java classes. This might
> not always
> have been done before. Good or bad?
>
> //Fredrik