Make File Changes For CR4239752

[Dan Xu]

Thank you for all your good comments. After adding the 
@GenerateNativeHeader annotation, I am able to build the jdk using the 
new build.

But where can I check whether this class is part of the base module in 
jigsaw? Or should I just use the annotation as the concerns will go 
away soon?

-Dan

On Tue 23 Oct 2012 06:12:58 AM PDT, Alan Bateman wrote:
> On 23/10/2012 09:16, Erik Joelsson wrote:
>> :
>>
>> The first question then is whether a native header is still needed
>> for java_io_FileSystem? Are the constants used in native code? Do
>> they still belong in this class given that the method moved? I have
>> no idea, so I'm asking you.
>>
> Yes, with Dan's changes it means this is another case of constants
> referenced in native code but without any native methods on the
> defining class. If it wasn't a candidate to include in the base module
> then it would be a candidate for @GenerativeNativeHeaders. I believe
> that annotation will soon be changed and will move to
> java.lang.annotation, in which case the concerns about putting it on
> core classes will go away.
>
> -Alan