Request for Review: Add hotspot support for building with mingw/msys on build-infra (the new build)

[Kelly O'Hair]

It has been my experience that using cygpath -w created problems with shell escape logic,
and that is why cygpath -m with a make level subst change is done, it was less problematic.

I don't understand why you would even want to change the cygwin logic at all, if it isn't broken why mess with it?

So my suggestion would be to add the msys logic, and leave the old cygwin logic alone.

I could have sworn that Tim Bell already did this change, and yes, if I look at:

    http://hg.openjdk.java.net/jdk8/build/hotspot/file/dccd40de8db1/make/windows/makefiles/defs.make

These changes are there already, or something equivalent.

Have you talked with Tim Bell about this change?

-kto

On Oct 25, 2012, at 6:49 AM, Magnus Ihse Bursie wrote:

> The following patch will allow build-infra to perform builds on MinGW/MSys.
> 
> It also updates the case for cygwin, with the two changes:
> 
> 1) It replaces a $(subst) from / to \ which acted on output from cygpath -m (mixed mode), with just cygpath -w (windows mode, i.e. mixed mode but with \ instead of /).
> 
> 2) In analogy with the msys case, we only do path convertion of the first word (i.e. the executable), not any possibly following arguments. In reality, there are no argument in the cygwin case (in contrary to the msys case, where the build infra solution requires passing additional arguments to the binaries).
> 
> If these are problematic, they can be dropped. The important part, from build-infras point of view, is the mingw case.
> 
> http://cr.openjdk.java.net/~ihse/hotspot-build-infra-msys-support/webrev.00/
> 
> /Magnus