Makefile changes

[Kelly O'Hair]

If these changes are integrated and on their way to jdk8/jdk8 already, it's water under the bridge, we need to
see them earlier in the future.

I appreciate the information though, I looked at these changesets and they look fine, but it is extremely
hard to review makefile changes and know that they are correct, as you well know. :(

I don't think we need to see copyright changes.

What I will observe is that there appears to be many extremely minor, maybe cosmetic changes being made
to makefiles that probably are unnecessary.

What I will suggest from  now on is that developers should strive to NOT change any makefiles unless the changes
have been deemed critical or necessary for some kind of bug fix.
Cleanups and misc format changes to makefiles would not be a good idea right now.

Thanks for the heads up on these changes.

-kto


On Oct 18, 2012, at 11:40 AM, Chris Gruszka wrote:

> I saw your other email, that it does apply to closed repos.
> 
> In our current JDK8 PIT (b62/b63?), we have makefile/.gmk file changes in:
> 7184404: MacOS AU needs to support a scheduled update check
> 
> 7197469: update copyright year to match last edit in jdk8 install repository
> 
> 7198150: install inclusion of JavaFX cobundle must fail if cobundle isn't available in ALT_JAVAFX_ZIP_DIR
> 
> 7200833: After JavaFX truly cobundle, DS NEXTVER builds fail
>         7196306: After JavaFX truly cobundle, JavaFX_VERSION in ds_build_versions is wrong
>         7195616: JavaFX files are not signed during DS build
> 
> 8000536: [Mac] JavaFX missing from install (JDK and private JRE)
> 
> 7200140: Install repo for JDK8 has SUNWj7* directories
> 
> 7199651: 7u10 win64 build failed at rebase process by including a signed
>         7192948: bin/installer.dll has wrong versions and is not signed
> 
> -ChrisG
> 
> On 10/18/2012 2:23 PM, Chris Gruszka wrote:
>> 
>> Kelly, 
>> Does this include closed repositories like install? 
>> My understanding was that no changes had been made for closed repos. 
>> 
>> -ChrisG 
>> 
>> On 10/18/2012 1:47 PM, Kelly O'Hair wrote: 
>>> If you are making any changes to the Makefiles or build process in jdk8, please let us know in the build group 
>>> build-dev at openjdk.java.net. We will need to review and approve ALL Makefile and build changes from now 
>>> until we change over to the new build-infra Makefiles. 
>>> The build-infra team can help you determine the equivalent change needed in the new build-infra Makefiles. 
>>> 
>>> -kto 
>>>