Request for Review: Support build-infra output directory in langtools test

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Oct 26 08:13:06 UTC 2012


On 2012-10-26 02:22, Jonathan Gibbons wrote:
> I note that there are some notes on the OpenJDK website about running 
> tests.
> See here: http://openjdk.java.net/jtreg/#makefile
>
> In particular, it includes this text:
>>
>> When using these targets, it is recommended to set the following 
>> variables, either as environment variables or on the "make" command 
>> line:
>>
>>   * |JT_HOME|: the jtreg installation directory
>>   * |PRODUCT_HOME|: the JDK build to be tested: this is typically a
>>     file path ending in /j2sdk-image/
>>
>
> If someone makes any changes such that this is no longer true, please 
> let me know so that I can update these notes.

The PRODUCT_HOME is definitiely still correct, I set this when running 
test from the build-infra makefile. However, the documentation does not 
seem to mention what this is about: some way to override were test 
output/logs are stored. This is currently hard-coded in langtools. In 
jdk, there is a default but it is possible to override, which is used by 
the build-infra makefile.

It would probably make sense to make such a override mechanism official 
and documented, once you all have agreed on a good name on the variable. ;-)

/Magnus



More information about the build-dev mailing list