review request - 7196361 add hotspot/make/closed to hgforest.sh

Chris Hegarty chris.hegarty at oracle.com
Wed Sep 5 20:15:10 UTC 2012


On 05/09/2012 21:13, John Coomes wrote:
> Chris Hegarty (chris.hegarty at oracle.com) wrote:
>> +1
>
> Thanks Chris.  Apologies for not including you in the cset comment; I
> committed the cset and started the push before getting your message.

No problem. More eyes always help ;-)

-Chris.

>
> -John
>
>> On 05/09/2012 20:40, Kelly O'Hair wrote:
>>> Looks fine to me.
>>>
>>> -kto
>>>
>>> On Sep 5, 2012, at 12:08 PM, John Coomes wrote:
>>>
>>>> Please review this small change to keep the script in sync with the
>>>> forest structure.
>>>>
>>>> webrev:
>>>>
>>>> http://cr.openjdk.java.net/~jcoomes/7196361-hs-make-closed/
>>>>
>>>> inline diff:
>>>>
>>>> diff -r d5e73011bde2 -r e177daf578bd make/scripts/hgforest.sh
>>>> --- a/make/scripts/hgforest.sh	Thu Aug 30 10:26:55 2012 -0700
>>>> +++ b/make/scripts/hgforest.sh	Wed Sep 05 11:51:52 2012 -0700
>>>> @@ -60,3 +60,3 @@
>>>>     if [ "${pull_extra_base}" != "" ] ; then
>>>> -    subrepos_extra="jdk/src/closed jdk/make/closed jdk/test/closed hotspot/src/closed hotspot/test/closed deploy install sponsors pubs"
>>>> +    subrepos_extra="jdk/src/closed jdk/make/closed jdk/test/closed hotspot/make/closed hotspot/src/closed hotspot/test/closed deploy install sponsors pubs"
>>>>       pull_default_tail=`echo ${pull_default} | sed -e 's@^.*://[^/]*/\(.*\)@\1@'`
>>>>
>>>> -John
>>>



More information about the build-dev mailing list